Labyricorn/voicebox
1
0
Fork 0
mirror of https://github.com/jamiepine/voicebox.git synced 2026-09-29 15:15:27 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): resolve release tag from tauri.conf.json, not GITHUB_REF_NAME

Browse Source 
GITHUB_REF_NAME is the branch name when the workflow runs via
workflow_dispatch, so the gh release upload targeted the wrong thing
on manual runs. tauri-action derives its tag from tauri.conf.json's
version field via the v__VERSION__ template; use the same source so
the two always agree.
This commit is contained in:
Jamie Pine
2026-04-20 23:21:15 -07:00
parent 870396ac67
commit b0e1c00c60
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/release.yml
+4 -1
View File
@@ -243,6 +243,9 @@ jobs:
KEY_PATH="$HOME/.appstoreconnect/private_keys/AuthKey_${APPLE_API_KEY_ID}.p8" KEY_PATH="$HOME/.appstoreconnect/private_keys/AuthKey_${APPLE_API_KEY_ID}.p8"
TARGET=$(echo "${{ matrix.args }}" | sed -n 's/.*--target \([a-z0-9_-]*\).*/\1/p') TARGET=$(echo "${{ matrix.args }}" | sed -n 's/.*--target \([a-z0-9_-]*\).*/\1/p')
DMG_DIR="tauri/src-tauri/target/${TARGET}/release/bundle/dmg" DMG_DIR="tauri/src-tauri/target/${TARGET}/release/bundle/dmg"
# Match the release tag tauri-action resolved from tauri.conf.json's
# version field; GITHUB_REF_NAME is a branch name under workflow_dispatch.
RELEASE_TAG="v$(jq -r '.version' tauri/src-tauri/tauri.conf.json)"
shopt -s nullglob shopt -s nullglob
dmgs=("${DMG_DIR}"/*.dmg) dmgs=("${DMG_DIR}"/*.dmg)
if [ ${#dmgs[@]} -eq 0 ]; then if [ ${#dmgs[@]} -eq 0 ]; then
@@ -258,7 +261,7 @@ jobs:
--wait --timeout 20m --wait --timeout 20m
xcrun stapler staple "$dmg" xcrun stapler staple "$dmg"
spctl -a -t open --context context:primary-signature -vv "$dmg" spctl -a -t open --context context:primary-signature -vv "$dmg"
gh release upload "${GITHUB_REF_NAME}" "$dmg" --clobber \ gh release upload "${RELEASE_TAG}" "$dmg" --clobber \
--repo "${GITHUB_REPOSITORY}" --repo "${GITHUB_REPOSITORY}"
echo "::endgroup::" echo "::endgroup::"
done done