From b0e1c00c606a026a609f91c61f29d3a23cfd7949 Mon Sep 17 00:00:00 2001 From: Jamie Pine Date: Mon, 20 Apr 2026 23:21:15 -0700 Subject: [PATCH] fix(release): resolve release tag from tauri.conf.json, not GITHUB_REF_NAME GITHUB_REF_NAME is the branch name when the workflow runs via workflow_dispatch, so the gh release upload targeted the wrong thing on manual runs. tauri-action derives its tag from tauri.conf.json's version field via the v__VERSION__ template; use the same source so the two always agree. --- .github/workflows/release.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3f0d0398..4f864c55 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -243,6 +243,9 @@ jobs: KEY_PATH="$HOME/.appstoreconnect/private_keys/AuthKey_${APPLE_API_KEY_ID}.p8" TARGET=$(echo "${{ matrix.args }}" | sed -n 's/.*--target \([a-z0-9_-]*\).*/\1/p') DMG_DIR="tauri/src-tauri/target/${TARGET}/release/bundle/dmg" + # Match the release tag tauri-action resolved from tauri.conf.json's + # version field; GITHUB_REF_NAME is a branch name under workflow_dispatch. + RELEASE_TAG="v$(jq -r '.version' tauri/src-tauri/tauri.conf.json)" shopt -s nullglob dmgs=("${DMG_DIR}"/*.dmg) if [ ${#dmgs[@]} -eq 0 ]; then @@ -258,7 +261,7 @@ jobs: --wait --timeout 20m xcrun stapler staple "$dmg" spctl -a -t open --context context:primary-signature -vv "$dmg" - gh release upload "${GITHUB_REF_NAME}" "$dmg" --clobber \ + gh release upload "${RELEASE_TAG}" "$dmg" --clobber \ --repo "${GITHUB_REPOSITORY}" echo "::endgroup::" done