As written, the strftime module's `getSuffix` method (responsible for
returning a date's ordinal string) works correctly for all dates in a
month _except_ 11, 12, and 13.
The existing code would return a string based on the last digit of the
date. In American English, these three dates use the `th` suffix rather
than `st`, `nd`, or `rd`.
This refactor/bug fix draws inspiration from Rails' ActiveSupport
ordinal inflector:
https://github.com/rails/rails/blob/main/activesupport/lib/active_support/locale/en.rb
The Ruby code above is designed to work with any number, so the bug fix
to this library is simpler.
The test suite is also updated with additional examples to verify the
correctness of these changes.
Once #615 is merged, the build script should work on macOS just as well as it does on Ubuntu and with this GitHub Actions matrix we can keep ensuring that it continues to work as it should.
This should help anyone looking to test their changes they made to LiquidJS via the Playground site also provided in the repository.
I have also added basic information on where the Playground is and how to run it in general.
* fix: sed invocations to work out of the box on macOS
These fixes make the sed invocations run on macOS but I am not sure if they will break the GNU sed invocations in return…
* fix: add macOS branches to the shell scripts
The sed command line was difficult (impossible?) to be made portable so I just added macOS conditions.
* Prototype the solution using an alias
It seems that this will not work because I keep getting "sedi: command not found".
* fix: use a Bash function instead of an alias to run sed portably
This seems to work on my local so let's see if it runs in the CI on GitHub.
* fix: use 2 spaces like the original scripts did
Not sure why VS Code went with 4.
* fix: use sedi for the build-changelog `1i\` part as well
I am curious if Ubuntu will handle the newline…
* fix: sed invocations to work out of the box on macOS
These fixes make the sed invocations run on macOS but I am not sure if they will break the GNU sed invocations in return…
* fix: add macOS branches to the shell scripts
The sed command line was difficult (impossible?) to be made portable so I just added macOS conditions.
* Prototype the solution using an alias
It seems that this will not work because I keep getting "sedi: command not found".
* fix: use a Bash function instead of an alias to run sed portably
This seems to work on my local so let's see if it runs in the CI on GitHub.
* fix: use 2 spaces like the original scripts did
Not sure why VS Code went with 4.
* fix: use sedi for the build-changelog `1i\` part as well
I am curious if Ubuntu will handle the newline…
* Add support for the Jekyll sample filter
See https://jekyllrb.com/docs/liquid/filters
I am sorting the array randomly and then picking the first N items or all items if there is no sample limit.
* Add tests for `push`
I thought `push` was broken because it doesn't work on the Playground but that's not the case. Here are the tests to prove it. Taken from the `concat` tests.
* Remove the sample experiment
This got in from another branch lol.
* Recommend the build:dist command over the whole build
This one works for me locally whereas build:docs is reporting some issues.
* Return the full `build` command and explain how to use `commitlint` to workshop the message
I am working on a PR to make `build` run on macOS because it is a part of the pre-commit hook anyway so all contributors should make it work for them.
I have also shown how to check your messages against `commitlint` from the CLI because it is faster than using the VS Code GUI.
* Add support for the Jekyll sample filter
See https://jekyllrb.com/docs/liquid/filters
I am sorting the array randomly and then picking the first N items or all items if there is no sample limit.
* Remove incorrect spaces before parens
Typo and copy-paste meet
