Rename {% doc %} constant strictly validates the abscense of args

.github/workflows/liquid.yml

@@ -14,21 +14,8 @@ jobs:
           - { ruby: 3.0, allowed-failure: false } # minimum supported
           - { ruby: 3.2, allowed-failure: false }
           - { ruby: 3.3, allowed-failure: false }
-          - { ruby: 3.3, allowed-failure: false }
           - { ruby: 3.4, allowed-failure: false } # latest
-          - {
-              ruby: 3.4,
-              allowed-failure: false,
-              rubyopt: "--enable-frozen-string-literal",
-            }
-          - { ruby: 3.4, allowed-failure: false, rubyopt: "--yjit" }
           - { ruby: ruby-head, allowed-failure: false }
-          - {
-              ruby: ruby-head,
-              allowed-failure: false,
-              rubyopt: "--enable-frozen-string-literal",
-            }
-          - { ruby: ruby-head, allowed-failure: false, rubyopt: "--yjit" }
     name: Test Ruby ${{ matrix.entry.ruby }}
     steps:
       - uses: actions/checkout@v3
@@ -39,8 +26,6 @@ jobs:
           bundler: latest
       - run: bundle exec rake
         continue-on-error: ${{ matrix.entry.allowed-failure }}
-        env:
-          RUBYOPT: ${{ matrix.entry.rubyopt }}
 
   memory_profile:
     runs-on: ubuntu-latest

History.md

@@ -1,34 +1,24 @@
 # Liquid Change Log
 
-## 5.8.1 (unreleased)
+## 5.7.3 (unreleased)
 
-## 5.8.1
-
-* Fix `{% doc %}` tag to be visitable [Guilherme Carreiro]
-
-## 5.8.0
-
-* Introduce the new `{% doc %}` tag [Guilherme Carreiro]
-
-## 5.7.3
-
-* Raise Liquid::SyntaxError when parsing invalidly encoded strings [Chris AtLee]
+* Raise Liquid::SyntaxError when parsing invalidly encoded strings
 
 ## 5.7.2 2025-01-31
 
-* Fix array filters to not support nested properties [Guilherme Carreiro]
+* Fix array filters to not support nested properties
 
 ## 5.7.1 2025-01-24
 
-* Fix the `find` and `find_index`filters to return `nil` when filtering empty arrays [Guilherme Carreiro]
-* Fix the `has` filter to return `false` when filtering empty arrays [Guilherme Carreiro]
+* Fix the `find` and `find_index`filters to return `nil` when filtering empty arrays
+* Fix the `has` filter to return `false` when filtering empty arrays
 
 ## 5.7.0 2025-01-16
 
 ### Features
 
-* Add `find`, `find_index`, `has`, and `reject` filters to arrays [Guilherme Carreiro]
-* Compatibility with Ruby 3.4 [Ian Ker-Seymer]
+* Add `find`, `find_index`, `has`, and `reject` filters to arrays
+* Compatibility with Ruby 3.4
 
 ## 5.6.4 2025-01-14
 

lib/liquid/context.rb

@@ -64,33 +64,6 @@ module Liquid
       @warnings ||= []
     end
 
-    def after_render_jobs
-      @registers.static[:after_render_jobs] ||= []
-    end
-
-    def next_after_render_id
-      @registers.static[:after_render_sequence] ||= 0
-      @registers.static[:after_render_sequence] += 1
-      "liquid-after-#{@registers.static[:after_render_sequence]}"
-    end
-
-    def enqueue_after_render(job)
-      after_render_jobs << job
-    end
-
-    def render_after_tags_to_output_buffer(output)
-      while (job = after_render_jobs.shift)
-        output << %(<template for="#{job[:id]}">)
-        job[:renderer].call(output)
-        output << %(</template>)
-      end
-      output
-    end
-
-    def render_after_tags
-      render_after_tags_to_output_buffer(+'')
-    end
-
     def strainer
       @strainer ||= @environment.create_strainer(self, @filters)
     end

lib/liquid/standardfilters.rb

@@ -3,6 +3,7 @@
 require 'cgi'
 require 'base64'
 require 'bigdecimal'
+
 module Liquid
   module StandardFilters
     MAX_I32 = (1 << 31) - 1
@@ -711,16 +712,7 @@ module Liquid
       input.gsub(/\r?\n/, "<br />\n")
     end
 
-    # @liquid_public_docs
-    # @liquid_type filter
-    # @liquid_category date
-    # @liquid_summary
-    #   Formats a date according to a specified format string.
-    # @liquid_description
-    #   This filter formats a date using various format specifiers. If the format string is empty,
-    #   the original input is returned. If the input cannot be converted to a date, the original input is returned.
-    #
-    #   The following format specifiers can be used:
+    # Reformat a date using Ruby's core Time#strftime( string ) -> string
     #
     #   %a - The abbreviated weekday name (``Sun'')
     #   %A - The  full  weekday  name (``Sunday'')
@@ -749,8 +741,8 @@ module Liquid
     #   %Y - Year with century
     #   %Z - Time zone name
     #   %% - Literal ``%'' character
-    # @liquid_syntax date | date: string
-    # @liquid_return [string]
+    #
+    #   See also: http://www.ruby-doc.org/core/Time.html#method-i-strftime
     def date(input, format)
       str_format = Utils.to_s(format)
       return input if str_format.empty?
@@ -997,7 +989,7 @@ module Liquid
     end
 
     def raise_property_error(property)
-      raise Liquid::ArgumentError, "cannot select the property '#{Utils.to_s(property)}'"
+      raise Liquid::ArgumentError, "cannot select the property '#{property}'"
     end
 
     def apply_operation(input, operand, operation)
@@ -1069,10 +1061,7 @@ module Liquid
       end
 
       def uniq(&block)
-        to_a.uniq do |item|
-          item = Utils.to_liquid_value(item)
-          block ? yield(item) : item
-        end
+        to_a.uniq(&block)
       end
 
       def compact

lib/liquid/tags/decrement.rb

@@ -10,7 +10,7 @@ module Liquid
   # @liquid_description
   #   Variables that are declared with `decrement` are unique to the [layout](/themes/architecture/layouts), [template](/themes/architecture/templates),
   #   or [section](/themes/architecture/sections) file that they're created in. However, the variable is shared across
-  #   [snippets](/themes/architecture/snippets) included in the file.
+  #   [snippets](/themes/architecture#snippets) included in the file.
   #
   #   Similarly, variables that are created with `decrement` are independent from those created with [`assign`](/docs/api/liquid/tags/assign)
   #   and [`capture`](/docs/api/liquid/tags/capture). However, `decrement` and [`increment`](/docs/api/liquid/tags/increment) share

lib/liquid/tags/doc.rb

@@ -13,20 +13,17 @@ module Liquid
   #   Liquid code inside will be parsed but not executed. This facilitates
   #   tooling support for features like code completion, linting, and inline
   #   documentation.
-  #
-  #   For detailed documentation syntax and examples, see the
-  #   [`LiquidDoc` reference](/docs/storefronts/themes/tools/liquid-doc).
-  #
   # @liquid_syntax
   #   {% doc %}
   #     Renders a message.
   #
-  #     @param {string} foo - A string value.
-  #     @param {string} [bar] - An optional string value.
+  #     @param {string} foo - A foo value.
+  #     @param {string} [bar] - An optional bar value.
   #
   #     @example
   #     {% render 'message', foo: 'Hello', bar: 'World' %}
   #   {% enddoc %}
+  #   {{ foo }}, {{ bar }}!
   class Doc < Block
     NO_UNEXPECTED_ARGS = /\A\s*\z/
 
@@ -58,10 +55,6 @@ module Liquid
       true
     end
 
-    def nodelist
-      []
-    end
-
     private
 
     def ensure_valid_markup(tag_name, markup, parse_context)

lib/liquid/tags/include.rb

@@ -6,7 +6,7 @@ module Liquid
   # @liquid_category theme
   # @liquid_name include
   # @liquid_summary
-  #   Renders a [snippet](/themes/architecture/snippets).
+  #   Renders a [snippet](/themes/architecture#snippets).
   # @liquid_description
   #   Inside the snippet, you can access and alter variables that are [created](/docs/api/liquid/tags/variable-tags) outside of the
   #   snippet.

lib/liquid/tags/increment.rb

@@ -10,7 +10,7 @@ module Liquid
   # @liquid_description
   #   Variables that are declared with `increment` are unique to the [layout](/themes/architecture/layouts), [template](/themes/architecture/templates),
   #   or [section](/themes/architecture/sections) file that they're created in. However, the variable is shared across
-  #   [snippets](/themes/architecture/snippets) included in the file.
+  #   [snippets](/themes/architecture#snippets) included in the file.
   #
   #   Similarly, variables that are created with `increment` are independent from those created with [`assign`](/docs/api/liquid/tags/assign)
   #   and [`capture`](/docs/api/liquid/tags/capture). However, `increment` and [`decrement`](/docs/api/liquid/tags/decrement) share

lib/liquid/tags/render.rb

@@ -6,7 +6,7 @@ module Liquid
   # @liquid_category theme
   # @liquid_name render
   # @liquid_summary
-  #   Renders a [snippet](/themes/architecture/snippets) or [app block](/themes/architecture/sections/section-schema#render-app-blocks).
+  #   Renders a [snippet](/themes/architecture#snippets) or [app block](/themes/architecture/sections/section-schema#render-app-blocks).
   # @liquid_description
   #   Inside snippets and app blocks, you can't directly access variables that are [created](/docs/api/liquid/tags/variable-tags) outside
   #   of the snippet or app block. However, you can [specify variables as parameters](/docs/api/liquid/tags/render#render-passing-variables-to-a-snippet)
@@ -27,11 +27,7 @@ module Liquid
   # @liquid_syntax_keyword filename The name of the snippet to render, without the `.liquid` extension.
   class Render < Tag
     FOR = 'for'
-    AFTER = 'after'
-    AFTER_MARKUP = /\s+#{AFTER}(?=\s|,|\z)/o
-    WITH_OR_FOR_MARKUP = /\s+(with|#{FOR})\s+(#{QuotedFragment}+)/o
-    ALIAS_MARKUP = /\s+(?:as)\s+(#{VariableSegment}+)/o
-    SYNTAX = /(#{QuotedString}+)(#{AFTER_MARKUP})?(#{WITH_OR_FOR_MARKUP})?(#{ALIAS_MARKUP})?/o
+    SYNTAX = /(#{QuotedString}+)(\s+(with|#{FOR})\s+(#{QuotedFragment}+))?(\s+(?:as)\s+(#{VariableSegment}+))?/o
 
     disable_tags "include"
 
@@ -43,11 +39,10 @@ module Liquid
       raise SyntaxError, options[:locale].t("errors.syntax.render") unless markup =~ SYNTAX
 
       template_name = Regexp.last_match(1)
-      @after = !!Regexp.last_match(2)
-      with_or_for = Regexp.last_match(4)
-      variable_name = Regexp.last_match(5)
+      with_or_for = Regexp.last_match(3)
+      variable_name = Regexp.last_match(4)
 
-      @alias_name = Regexp.last_match(7)
+      @alias_name = Regexp.last_match(6)
       @variable_name_expr = variable_name ? parse_expression(variable_name) : nil
       @template_name_expr = parse_expression(template_name)
       @is_for_loop = (with_or_for == FOR)
@@ -66,10 +61,6 @@ module Liquid
       render_tag(context, output)
     end
 
-    def after?
-      @after
-    end
-
     def render_tag(context, output)
       # The expression should be a String literal, which parses to a String object
       template_name = @template_name_expr
@@ -83,43 +74,26 @@ module Liquid
 
       context_variable_name = @alias_name || template_name.split('/').last
 
-      evaluated_attributes = @attributes.transform_values { |value| context.evaluate(value) }
-
-      render_partial_func = ->(var, forloop, render_output) {
+      render_partial_func = ->(var, forloop) {
         inner_context               = context.new_isolated_subcontext
         inner_context.template_name = partial.name
         inner_context.partial       = true
         inner_context['forloop']    = forloop if forloop
 
-        evaluated_attributes.each do |key, value|
-          inner_context[key] = value
+        @attributes.each do |key, value|
+          inner_context[key] = context.evaluate(value)
         end
         inner_context[context_variable_name] = var unless var.nil?
-        partial.render_to_output_buffer(inner_context, render_output)
+        partial.render_to_output_buffer(inner_context, output)
         forloop&.send(:increment!)
       }
 
       variable = @variable_name_expr ? context.evaluate(@variable_name_expr) : nil
-
-      if @after
-        id = context.next_after_render_id
-        context.enqueue_after_render(
-          id: id,
-          renderer: ->(after_output) {
-            if @is_for_loop && variable.respond_to?(:each) && variable.respond_to?(:count)
-              forloop = Liquid::ForloopDrop.new(template_name, variable.count, nil)
-              variable.each { |var| render_partial_func.call(var, forloop, after_output) }
-            else
-              render_partial_func.call(variable, nil, after_output)
-            end
-          }
-        )
-        output << %(<?marker name="#{id}">)
-      elsif @is_for_loop && variable.respond_to?(:each) && variable.respond_to?(:count)
+      if @is_for_loop && variable.respond_to?(:each) && variable.respond_to?(:count)
         forloop = Liquid::ForloopDrop.new(template_name, variable.count, nil)
-        variable.each { |var| render_partial_func.call(var, forloop, output) }
+        variable.each { |var| render_partial_func.call(var, forloop) }
       else
-        render_partial_func.call(variable, nil, output)
+        render_partial_func.call(variable, nil)
       end
 
       output

lib/liquid/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Liquid
-  VERSION = "5.8.6"
+  VERSION = "5.7.3"
 end

proposals/render-after.md

@@ -1,208 +0,0 @@
-# Proposal: Deferred `render` with `after`
-
-## Summary
-
-Add an optional `after` modifier to Liquid's `{% render %}` tag:
-
-```liquid
-{% render 'product-card' after, product: product %}
-```
-
-When `after` is present, Liquid does not render the partial inline. Instead, it emits a stable HTML placeholder marker into the output and records enough information on the current `Liquid::Context` to render the partial later. A new context API then renders all deferred partials, ideally as a stream of out-of-order HTML replacement patches.
-
-This is inspired by Chrome's Declarative Partial Updates proposal: https://developer.chrome.com/blog/declarative-partial-updates. The browser-side idea is to let HTML declare patch targets and stream their replacement content later, enabling the initial shell to be sent quickly while slower islands arrive when ready.
-
-For Liquid, the equivalent is server-side syntax for declaring that a snippet can be delayed without changing template structure.
-
-## Motivation
-
-Liquid templates often have a mix of cheap layout work and expensive isolated snippets. Today, an expensive snippet blocks all subsequent output because `{% render %}` is synchronous and inline.
-
-`render after` would allow templates to produce the main document quickly, reserve exact DOM locations for deferred snippets, and render those snippets later using the same Liquid render semantics.
-
-Example use cases:
-
-- Product recommendations below the fold.
-- Expensive merchandising or personalization blocks.
-- Analytics or SEO metadata fragments that can be patched into known locations.
-- App blocks where the outer page shell should not wait on the block.
-
-## Goals
-
-- Add a small, Liquid-native API for deferring isolated snippet rendering.
-- Preserve existing `{% render %}` isolation semantics.
-- Emit processing-instruction placeholders that can be targeted by a later replacement patch.
-- Store deferred render work in `Liquid::Context`.
-- Add a context method to flush/enumerate/render deferred work.
-- Keep the first prototype simple and non-streaming, while shaping the API so true streaming can be added later.
-
-## Non-goals
-
-- Implement browser support for Declarative Partial Updates.
-- Require JavaScript for the Liquid-side primitive.
-- Make arbitrary tags asynchronous.
-- Allow deferred snippets to mutate the parent scope after the placeholder is emitted.
-- Solve scheduling, prioritization, cancellation, or parallel execution in the first prototype.
-
-## Syntax
-
-The proposed syntax is:
-
-```liquid
-{% render 'snippet' after %}
-{% render 'snippet' after, product: product %}
-{% render 'snippet' after with product as item %}
-{% render 'snippet' after for products as product %}
-```
-
-`after` is a render modifier with no value. It is intentionally boolean and reserved in this position.
-
-The prototype supports bare `after` immediately after the rendered template name, because it reads like a render modifier rather than data passed into the snippet. `after: value` remains a normal named argument passed to the snippet.
-
-## Output shape
-
-When a deferred render is encountered, Liquid emits a Chrome-style processing-instruction placeholder marker with a unique id:
-
-```html
-<?marker name="liquid-after-1">
-```
-
-Later, flushing the deferred renders produces replacement patches. The target shape should be compatible with the direction of Declarative Partial Updates. For example:
-
-```html
-<template for="liquid-after-1">
-  ...rendered snippet HTML...
-</template>
-```
-
-The exact patch attribute names should track the platform proposal as it evolves. Until browser APIs stabilize, Liquid can expose a server-side patch format behind a small formatter object.
-
-For the prototype, the replacement payload is a concatenated HTML patch string:
-
-```ruby
-context.render_after_tags
-# => "<template for=...>...</template>"
-```
-
-## Semantics
-
-### Evaluation timing
-
-When `{% render 'snippet' after ... %}` is encountered:
-
-1. Liquid evaluates the snippet name expression.
-2. Liquid evaluates the `with` / `for` expression, if present.
-3. Liquid evaluates all named render arguments.
-4. Liquid records a deferred render job containing the evaluated values and render metadata.
-5. Liquid emits a placeholder marker.
-
-This means deferred renders capture values at enqueue time, not flush time. That avoids surprising behavior when variables change later in the template.
-
-### Isolation
-
-Deferred render jobs should use the same isolation semantics as normal `{% render %}`:
-
-- The snippet receives only explicitly-passed variables plus globals/environments available to render today.
-- Variables assigned inside the snippet do not leak into the parent template.
-- The `include` tag remains disabled inside rendered snippets.
-
-### Ordering
-
-The queue is FIFO by default. Placeholder ids are monotonically increasing per context render:
-
-```html
-<?marker name="liquid-after-1">
-<?marker name="liquid-after-2">
-```
-
-The streaming API may later render jobs as they become ready, but the prototype can preserve source order.
-
-### Error handling
-
-Deferred renders should use Liquid's existing error handling through `Context#handle_error` and `exception_renderer`.
-
-Open question: if an error occurs while flushing deferred renders after the main template was already sent, should the replacement patch contain the rendered error string, an empty patch, or an out-of-band error? The prototype should match inline render behavior and place the rendered error into the patch body.
-
-## Proposed API
-
-Add queue APIs to `Liquid::Context`:
-
-```ruby
-context.enqueue_after_render(job) # internal
-context.after_render_jobs         # inspection/testing
-context.render_after_tags         # prototype: returns a string of patches
-context.render_after_tags_to_output_buffer(output) # streaming-ready shape
-```
-
-Possible streaming-oriented API:
-
-```ruby
-context.each_after_render_patch do |patch|
-  response.write(patch)
-end
-```
-
-or:
-
-```ruby
-context.render_after_tags_to_output_buffer(response_stream)
-```
-
-The first implementation may buffer each snippet internally. The API should still write to an output object so callers can later stream each completed patch without changing template code.
-
-## Example
-
-Template:
-
-```liquid
-<h1>{{ product.title }}</h1>
-
-{% render 'price', product: product %}
-
-<section>
-  {% render 'recommendations' after, product: product %}
-</section>
-```
-
-Initial output:
-
-```html
-<h1>Snowboard</h1>
-
-<span>$699.00</span>
-
-<section>
-  <?marker name="liquid-after-1">
-</section>
-```
-
-Deferred patch output:
-
-```html
-<template for="liquid-after-1">
-  <ul class="recommendations">...</ul>
-</template>
-```
-
-A Rack-like integration could do:
-
-```ruby
-context = Liquid::Context.build(...)
-body = template.render!(context)
-response.write(body)
-context.render_after_tags_to_output_buffer(response)
-```
-
-The prototype can buffer `body` first. A production integration would stream `body` immediately, then stream each deferred patch as soon as it completes.
-
-## Compatibility
-
-Existing templates are unaffected unless they use bare `after` immediately after the rendered template name.
-
-Because bare `after` becomes reserved syntax for the render tag in that position, this could conflict with unusual templates that currently rely on that token being ignored. Snippets currently receiving an `after:` keyword argument continue to work:
-
-```liquid
-{% render 'divider', after: 'label' %}
-```
-
-This proposal only reserves bare `after`; `after: value` continues to be passed as a normal snippet attribute. That minimizes compatibility risk.

test/integration/standard_filter_test.rb

@@ -560,23 +560,12 @@ class StandardFiltersTest < Minitest::Test
     end
   end
 
-  def test_map_with_value_property
-    array = [
-      { "handle" => "alpha", "value" => "A" },
-      { "handle" => "beta", "value" => "B" },
-      { "handle" => "gamma", "value" => "C" }
-    ]
-
-    assert_template_result("A B C", "{{ array | map: 'value' | join: ' ' }}", { "array" => array })
-  end
-
-  def test_map_returns_input_with_no_property
+  def test_map_returns_empty_with_no_property
     foo = [
       [1],
       [2],
       [3],
     ]
-
     assert_raises(Liquid::ArgumentError) do
       @filters.map(foo, nil)
     end
@@ -1044,23 +1033,6 @@ class StandardFiltersTest < Minitest::Test
     assert_template_result(expected_output, template, { "array" => array })
   end
 
-  def test_where_with_empty_string_is_a_no_op
-    environment = { "array" => ["alpha", "beta", "gamma"] }
-    expected_output = "alpha beta gamma"
-    template = "{{ array | where: '' | join: ' ' }}"
-
-    assert_template_result(expected_output, template, environment)
-  end
-
-  def test_where_with_nil_is_a_no_op
-    environment = { "array" => ["alpha", "beta", "gamma"] }
-    template = "{{ array | where: nil | join: ' ' }}"
-
-    assert_raises(Liquid::ArgumentError) do
-      assert_template_result("alpha beta gamma", template, environment)
-    end
-  end
-
   def test_where_with_value
     array = [
       { "handle" => "alpha", "ok" => true },
@@ -1296,33 +1268,6 @@ class StandardFiltersTest < Minitest::Test
     assert_template_result("0", "{{ input | sum: 'subtotal' }}", { "input" => input })
   end
 
-  def test_sum_with_non_string_property
-    input = [{ true => 1 }, { 1.0 => 0.2, 1 => -0.3 }, { 1..5 => 0.4 }]
-
-    assert_equal(1, @filters.sum(input, true))
-    assert_equal(0.2, @filters.sum(input, 1.0))
-    assert_equal(-0.3, @filters.sum(input, 1))
-    assert_equal(0.4, @filters.sum(input, (1..5)))
-    assert_equal(0, @filters.sum(input, nil))
-    assert_equal(0, @filters.sum(input, ""))
-  end
-
-  def test_uniq_with_to_liquid_value
-    input = [StringDrop.new("foo"), StringDrop.new("bar"), "foo"]
-    expected = [StringDrop.new("foo"), StringDrop.new("bar")]
-    result = @filters.uniq(input)
-
-    assert_equal(expected, result)
-  end
-
-  def test_uniq_with_to_liquid_value_pick_correct_classes
-    input = ["foo", StringDrop.new("foo"), StringDrop.new("bar")]
-    expected = [String, StringDrop]
-    result = @filters.uniq(input).map(&:class)
-
-    assert_equal(expected, result)
-  end
-
   private
 
   def with_timezone(tz)

test/integration/tags/render_tag_test.rb

@@ -46,70 +46,6 @@ class RenderTagTest < Minitest::Test
     )
   end
 
-  def test_render_after_defers_partial_until_context_flush
-    file_system = StubFileSystem.new('snippet' => 'deferred {{ value }}')
-    environment = Liquid::Environment.build(file_system: file_system)
-    template = Liquid::Template.parse('before {% render "snippet" after, value: 1 %} after', environment: environment)
-    registers = Liquid::Registers.new(file_system: file_system)
-    context = Liquid::Context.build(registers: registers, environment: environment)
-
-    assert_equal('before <?marker name="liquid-after-1"> after', template.render(context))
-    assert_equal('<template for="liquid-after-1">deferred 1</template>', context.render_after_tags)
-    assert_empty(context.after_render_jobs)
-  end
-
-  def test_render_after_evaluates_attributes_when_enqueued
-    file_system = StubFileSystem.new('snippet' => '{{ value }}')
-    environment = Liquid::Environment.build(file_system: file_system)
-    template = Liquid::Template.parse('{% assign value = 1 %}{% render "snippet" after, value: value %}{% assign value = 2 %}', environment: environment)
-    registers = Liquid::Registers.new(file_system: file_system)
-    context = Liquid::Context.build(registers: registers, environment: environment)
-
-    assert_equal('<?marker name="liquid-after-1">', template.render(context))
-    assert_equal('<template for="liquid-after-1">1</template>', context.render_after_tags)
-  end
-
-  def test_render_after_supports_with_and_as
-    file_system = StubFileSystem.new('snippet' => '{{ item }}')
-    environment = Liquid::Environment.build(file_system: file_system)
-    template = Liquid::Template.parse('{% render "snippet" after with value as item %}', environment: environment)
-    registers = Liquid::Registers.new(file_system: file_system)
-    context = Liquid::Context.build(static_environments: { 'value' => 'captured' }, registers: registers, environment: environment)
-
-    assert_equal('<?marker name="liquid-after-1">', template.render(context))
-    assert_equal('<template for="liquid-after-1">captured</template>', context.render_after_tags)
-  end
-
-  def test_render_after_supports_for_and_as
-    file_system = StubFileSystem.new('snippet' => '{{ forloop.index }}:{{ item }};')
-    environment = Liquid::Environment.build(file_system: file_system)
-    template = Liquid::Template.parse('{% render "snippet" after for values as item %}', environment: environment)
-    registers = Liquid::Registers.new(file_system: file_system)
-    context = Liquid::Context.build(static_environments: { 'values' => ['a', 'b'] }, registers: registers, environment: environment)
-
-    assert_equal('<?marker name="liquid-after-1">', template.render(context))
-    assert_equal('<template for="liquid-after-1">1:a;2:b;</template>', context.render_after_tags)
-  end
-
-  def test_render_after_preserves_fifo_order
-    file_system = StubFileSystem.new('snippet' => '{{ value }}')
-    environment = Liquid::Environment.build(file_system: file_system)
-    template = Liquid::Template.parse('{% render "snippet" after, value: 1 %}{% render "snippet" after, value: 2 %}', environment: environment)
-    registers = Liquid::Registers.new(file_system: file_system)
-    context = Liquid::Context.build(registers: registers, environment: environment)
-
-    assert_equal('<?marker name="liquid-after-1"><?marker name="liquid-after-2">', template.render(context))
-    assert_equal('<template for="liquid-after-1">1</template><template for="liquid-after-2">2</template>', context.render_after_tags)
-  end
-
-  def test_render_after_colon_remains_a_named_argument
-    assert_template_result(
-      'later',
-      '{% render "snippet", after: "later" %}',
-      partials: { 'snippet' => '{{ after }}' },
-    )
-  end
-
   def test_render_does_not_inherit_parent_scope_variables
     assert_template_result(
       '',

test/test_helper.rb

@@ -146,35 +146,6 @@ class BooleanDrop < Liquid::Drop
   end
 end
 
-class StringDrop < Liquid::Drop
-  include Comparable
-
-  def initialize(value)
-    super()
-    @value = value
-  end
-
-  def to_liquid_value
-    @value
-  end
-
-  def to_s
-    @value
-  end
-
-  def to_str
-    @value
-  end
-
-  def inspect
-    "#<StringDrop @value=#{@value.inspect}>"
-  end
-
-  def <=>(other)
-    to_liquid_value <=> Liquid::Utils.to_liquid_value(other)
-  end
-end
-
 class ErrorDrop < Liquid::Drop
   def standard_error
     raise Liquid::StandardError, 'standard error'

test/unit/tags/doc_tag_unit_test.rb

@@ -157,28 +157,4 @@ class DocTagUnitTest < Minitest::Test
     assert_template_result('', "{% doc %}123{% enddoc\nxyz %}")
     assert_template_result('', "{% doc %}123{% enddoc\n   xyz  enddoc %}")
   end
-
-  def test_doc_tag_visitor
-    template_source = '{% doc %}{% enddoc %}'
-
-    assert_equal(
-      [Liquid::Doc],
-      visit(template_source),
-    )
-  end
-
-  private
-
-  def traversal(template)
-    ParseTreeVisitor
-      .for(Template.parse(template).root)
-      .add_callback_for(Liquid::Doc) do |tag|
-        tag_class = tag.class
-        tag_class
-      end
-  end
-
-  def visit(template)
-    traversal(template).visit.flatten.compact
-  end
 end