Anders Søgaard and GitHub
f17c49776d
Merge branch 'Shopify:master' into master
2021-09-16 19:14:10 +02:00
Anders Søgaard
aead4c5daa
Refactor filter
2021-09-16 19:10:50 +02:00
Anders Søgaard
d81f7f04ce
Add tests to make sure it returns original string on no replacement
2021-09-16 18:42:18 +02:00
Anders Søgaard and GitHub
db3999a008
Improve where filter tests ( #1472 )
2021-09-16 10:02:39 -04:00
Marc-André Cournoyer and GitHub
10e2aa8d5b
Merge pull request #1471 from Shopify/bump-5.1.0
...
Prep for 5.1.0 release
2021-09-15 15:15:13 -04:00
Anders Søgaard
e3c82a9e4e
Favor unless over if for negative conditions
2021-09-13 18:07:29 +02:00
Anders Søgaard
986391cb7d
start_index will never be -1
2021-09-13 18:00:03 +02:00
7c4114671b
Remove to_liquid_value fixes in changelog
...
Co-authored-by: Dylan Thacker-Smith <[email protected]
2021-09-13 10:53:46 -04:00
Anders Søgaard
b5abd145e3
Remove default value for replacement argument
2021-09-10 18:02:35 +02:00
Anders Søgaard
f5e77b6d1d
Update test to support third argument
2021-09-10 18:02:23 +02:00
Anders Søgaard
dc7818f371
Update filter to use rindex
2021-09-10 09:55:08 +02:00
Anders Søgaard
f72cfb13ab
Delegate functions to corresponding replace functions
2021-09-10 08:24:50 +02:00
Marc-André Cournoyer
b01de9d325
Prep for 5.1.0 release
2021-09-09 14:28:45 -04:00
Zac Clay and GitHub
a5369c26a8
Add missing quote in comment ( #1468 )
2021-09-09 14:23:11 -04:00
Charles-Philippe Clermont and GitHub
a03de8f9ea
Merge pull request #1470 from Shopify/fix/range-parse-tree-visitor
...
Add ParseTreeVisitor to RangeLookup
2021-09-09 11:39:14 -04:00
Charles-P. Clermont
e86fe27259
Fix lint
2021-09-09 11:22:39 -04:00
Charles-P. Clermont
c8906d05b9
Add ParseTreeVisitor to RangeLookup
2021-09-09 11:22:39 -04:00
Anders Søgaard and GitHub
d5ecf00a8c
Update History.md
2021-09-09 09:28:22 +02:00
Anders Søgaard and GitHub
973aa9f1b5
Merge branch 'Shopify:master' into master
2021-09-09 08:59:07 +02:00
Michael Go and GitHub
50d1a2ffc9
Merge pull request #1458 from Shopify/use-to-liquid-value-with-conditions
...
use Utils.to_liquid_value on conditionals
2021-06-15 12:18:14 -03:00
Michael Go
f686c5dec7
use Utils.to_liquid_value on conditionals
2021-06-14 18:19:37 -03:00
Michael Go and GitHub
aa8ce87b96
Merge pull request #1454 from Shopify/default-filter-with-to-liquid-value
...
utilize input's to_liquid_value on default filter
2021-06-14 15:43:56 -03:00
Peter Zhu and GitHub
698f5e0d96
Merge pull request #1456 from Shopify/pz-psych-4-unsafe-load
...
Fix benchmark for breaking change in Psych 4
2021-06-10 13:14:13 -04:00
Peter Zhu
996bfe0c82
Fix benchmark for breaking change in Psych 4
...
Psych 4 introduces a breaking change (ruby/psych#487 ) where
`Psych#load`/`Psych#load_file` now default to safe loading,
meaning that YAML references are not allowed anymore. This
commit changes the benchmark to use `Psych#unsafe_load_file`
when it's available.
2021-06-10 13:01:16 -04:00
Michael Go and GitHub
be81c9ae5a
Merge pull request #1457 from Shopify/fix-unless-to-use-to-liquid-value-helper
...
fix unless to use to_liquid_value helper with multiple conditions
2021-06-10 14:00:19 -03:00
Michael Go
edd4d70aee
fix unless to use to_liquid_value helper with multiple conditions
2021-06-10 13:28:17 -03:00
Michael Go
ac66dbbafe
utilize input's to_liquid_value on default filter
2021-06-08 15:20:53 -03:00
Daniel Insley and GitHub
017c1b5e83
Base64 Decode & Encode Filters ( #1450 )
2021-06-03 13:23:11 -04:00
Michael Go and GitHub
250555c9a8
Merge pull request #1441 from Shopify/to-raw-value
...
Implement to_liquid_value to Liquid::Drop
2021-05-27 10:21:05 -03:00
Michael Go
e361a4d53c
introduce to_liquid_value on variable look and conditional statements
2021-05-26 17:27:18 -03:00
Dylan Thacker-Smith
b9e0d28729
rubocop: Clarify that a config is a rubocop-shopify backport
2021-04-20 09:01:06 -07:00
Dylan Thacker-Smith
020f6b93c5
rubocop: Fix unsupported ruby version in TargetRubyVersion error
2021-04-20 09:00:20 -07:00
Dylan Thacker-Smith and GitHub
cfe1637bdd
Translate RangeError to Liquid::Error for truncatewords with large int ( #1431 )
2021-04-20 11:48:22 -04:00
Anders Søgaard and ADTC
b3d14e5b49
Update tests
...
Co-Authored-By: ADTC <[email protected]
2021-04-06 07:34:36 +02:00
Anders Søgaard
effee1ed50
Update tests
2021-04-02 20:15:13 +02:00
Anders Søgaard
38b7364f96
Improve tests
2021-04-02 20:11:38 +02:00
Anders Søgaard
7754a0fbee
Use correct method
2021-03-30 12:37:44 +02:00
Anders Søgaard
e575c1f131
Add replace_last and remove_last filters
2021-03-30 12:34:01 +02:00
Anders Søgaard
832516fb31
Add replace_last and remove_last tests
2021-03-30 12:23:45 +02:00
Dylan Thacker-Smith
eab13a07d9
Add changelog entry for a recent fix
2021-03-29 13:43:01 -07:00
Dylan Thacker-Smith and GitHub
ca96ca0fef
Fix support for using a String subclass for the liquid source ( #1421 )
2021-03-29 16:22:05 -04:00
Marc-André Cournoyer and GitHub
4e7a953e73
Merge pull request #1417 from Shopify/prep-release
...
Bump to 5.0.1 and add changelog for release
2021-03-24 16:55:10 -04:00
6ac2499f7f
Remove internal tokenizer fix from History.md
...
Co-authored-by: Dylan Thacker-Smith <[email protected]
2021-03-24 16:53:45 -04:00
ff70161512
Remove internal fixes from History.md
...
Co-authored-by: Dylan Thacker-Smith <[email protected]
2021-03-24 16:52:57 -04:00
Marc-André Cournoyer
026157e128
Bump to 5.0.1 and add changelog for release
2021-03-24 16:19:19 -04:00
Charles-Philippe Clermont and GitHub
bf64239ea6
Merge pull request #1414 from Shopify/fix/echo-parse-tree-visitor
...
Add ParseTreeVisitor to Echo tag
2021-03-24 09:38:48 -04:00
Charles-P. Clermont
c270a6f378
Add ParseTreeVisitor to Echo tag
...
This fixes theme-check#218, wherein variables used in echo tags are not
considered used by the linter. It is because our visitor doesn't see the
:variable_lookup's in the echo tag since the children array is empty.
But this array is empty because it is swallowed by the @variable.
2021-03-24 09:35:43 -04:00
Dylan Thacker-Smith and GitHub
4fba61a802
Merge pull request #1402 from Shopify/rubocop-shopify
...
Use the rubocop-shopify gem and autocorrect
2021-03-16 17:39:09 -04:00
Dylan Thacker-Smith and GitHub
6b6baece25
Merge pull request #1406 from ADTC/patch-2
...
Add a line to Sign the CLA as the first step in Workflow
2021-02-26 09:03:40 -05:00
15b2d193ec
Add a hint to sign CLA only if it's the first time
...
The CLA isn't signed per repository. They might have done so for another repository. In which case, they won't need to do that again.
Change attributed to @dylanahsmith
Co-authored-by: Dylan Thacker-Smith <[email protected]
2021-02-26 16:31:16 +08:00
