Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-10-03 00:55:11 -07:00
Code Issues Packages Projects Releases Wiki Activity
1,980 Commits 318 Branches 71 Tags
ef13b2dfd5886f9af680129fbe2e4626ae54355f
Commit Graph
3 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantin TennhardandGitHub 64fca66ef5 Merge pull request #797 from Shopify/truncatewords-resiliency 
Standard filter truncate / truncatewords: force truncate_string to string
 2016-09-13 10:43:55 -04:00
Konstantin Tennhard 95d5c24bfc Standard filter truncate: truncate_string string coercion 
The argument `truncate_string` is now coerced into a string to avoid
`NoMethodError`s. This is mostly for added resiliency. It is doubtful
that someone would actually intent to use a number as truncate string,
but accidentally supplying one is entirely possible.
 2016-09-12 12:13:12 -04:00
Konstantin Tennhard 302185a7fc Standard filter truncatewords: force truncate_string to string 
Currently, `truncatewords` raises a TypeError when the argument
`truncate_string` is an interger. This PR forces string coercion for any
value provided for this argument. Thus,

```ruby
assert_equal 'one two1', @filters.truncatewords("one two three", 2, 1)
```

holds true. Another option would be to raise a `Liquid::ArgumentError`.

What is preferred?
 2016-09-09 16:50:50 -04:00