4 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Charles-P. Clermont	1310c4978d	Fix kwarg parsing inconsistency with Liquid::C ... Liquid::C parses liquid filter arguments with dashes in them, Liquid does not. For tags that accept kwargs and dumps them on the HTML tag, this is an important feature. e.g. {{ ... | image_tag: loading: 'lazy', data-something: 'value!' }} Without this change, Liquid would incorrectly parse the `data-something` kwarg as a single argument and would skip over the invalid characters. See https://github.com/Shopify/theme-check/issues/539 for more context	2022-02-11 15:10:07 -05:00
Charles-P. Clermont	e86fe27259	Fix lint	2021-09-09 11:22:39 -04:00
Charles-P. Clermont	c8906d05b9	Add ParseTreeVisitor to RangeLookup	2021-09-09 11:22:39 -04:00
Charles-P. Clermont	c270a6f378	Add ParseTreeVisitor to Echo tag ... This fixes theme-check#218, wherein variables used in echo tags are not considered used by the linter. It is because our visitor doesn't see the :variable_lookup's in the echo tag since the children array is empty. But this array is empty because it is swallowed by the @variable.	2021-03-24 09:35:43 -04:00