Tobi Lutke
b195d09212
Replace @blocks.each with while loop in If render — avoids block proc allocation per render\n\nResult: {"status":"keep","combined_µs":3496,"parse_µs":2356,"render_µs":1140,"allocations":24530}
2026-03-12 17:31:41 -04:00
Tobi Lutke
db348e0dac
Inline to_liquid_value in If render — avoids one method dispatch per condition evaluation\n\nResult: {"status":"keep","combined_µs":3459,"parse_µs":2318,"render_µs":1141,"allocations":24647}
2026-03-12 17:31:20 -04:00
Tobi Lutke
99454a9be2
Replace simple_lookup? byte scan with match? regex — 8x faster per call, cleaner code\n\nResult: {"status":"keep","combined_µs":3489,"parse_µs":2353,"render_µs":1136,"allocations":24647}
2026-03-12 17:27:17 -04:00
Tobi Lutke
ca327b01b1
Condition#evaluate: skip loop block for simple conditions (no child_relation) — saves 235 allocs\n\nResult: {"status":"keep","combined_µs":3445,"parse_µs":2284,"render_µs":1161,"allocations":24647}
2026-03-12 17:24:51 -04:00
Tobi Lutke
ae9a2e26b0
Clean confirmation run: 3,314µs (-55% from main), stable\n\nResult: {"status":"keep","combined_µs":3314,"parse_µs":2203,"render_µs":1111,"allocations":24882}
2026-03-12 17:22:24 -04:00
Tobi Lutke
46927b9e90
update autoresearch docs with current progress
2026-03-12 17:21:28 -04:00
Tobi Lutke
f6baeaed1e
parse_tag_token without StringScanner: pure byte ops avoid reset(token) overhead, -12% combined\n\nResult: {"status":"keep","combined_µs":3350,"parse_µs":2212,"render_µs":1138,"allocations":24882}
2026-03-12 17:17:10 -04:00
Tobi Lutke
b37fa98c91
Clean up tokenizer: remove unused StringScanner setup and regex constants\n\nResult: {"status":"keep","combined_µs":3490,"parse_µs":2331,"render_µs":1159,"allocations":24882}
2026-03-12 17:12:08 -04:00
Tobi Lutke
e25f2f1d52
Confirmation run: byteindex tokenizer consistently 3,400-3,600µs\n\nResult: {"status":"keep","combined_µs":3464,"parse_µs":2335,"render_µs":1129,"allocations":24882}
2026-03-12 17:11:29 -04:00
Tobi Lutke
b7ae55f7a9
Replace StringScanner tokenizer with String#byteindex — 12% faster parse, no regex overhead for delimiter finding\n\nResult: {"status":"keep","combined_µs":3556,"parse_µs":2388,"render_µs":1168,"allocations":24882}
2026-03-12 17:11:15 -04:00
Tobi Lutke
c09e722f9b
Baseline: 3,818µs combined, 24,881 allocs\n\nResult: {"status":"keep","combined_µs":3818,"parse_µs":2722,"render_µs":1096,"allocations":24881}
2026-03-12 16:48:10 -04:00
Tobi Lutke
8f2f0ee035
Skip context.evaluate for String lookup keys in VariableLookup — avoids respond_to? dispatch\n\nResult: {"status":"keep","combined_µs":4103,"parse_µs":2881,"render_µs":1222,"allocations":24881}
2026-03-11 10:52:07 -04:00
Tobi Lutke
38d8055c3b
update autoresearch.md with current progress
2026-03-11 10:51:39 -04:00
Tobi Lutke
228ecdb6a2
Cache no-arg filter tuples [name, EMPTY_ARRAY] — reuse frozen tuples across templates\n\nResult: {"status":"keep","combined_µs":4147,"parse_µs":2992,"render_µs":1155,"allocations":24881}
2026-03-11 10:49:44 -04:00
Tobi Lutke
76afdf154f
Replace manual blank_string? with regex match — cleaner code\n\nResult: {"status":"keep","combined_µs":4196,"parse_µs":3042,"render_µs":1154,"allocations":25535}
2026-03-11 10:44:43 -04:00
Tobi Lutke
22b5ff1587
Skip to_liquid_value for String/Integer keys in VariableLookup — avoids respond_to? dispatch\n\nResult: {"status":"keep","combined_µs":4131,"parse_µs":2893,"render_µs":1238,"allocations":25535}
2026-03-11 10:44:05 -04:00
Tobi Lutke
1a019151eb
Minor cleanup: optimize expect_id with while loop and early return\n\nResult: {"status":"keep","combined_µs":4184,"parse_µs":2921,"render_µs":1263,"allocations":25535}
2026-03-11 10:43:20 -04:00
Tobi Lutke
71e22e6a84
Replace manual scan_dotted_id with regex\n\nResult: {"status":"keep","combined_µs":4121,"parse_µs":2812,"render_µs":1309,"allocations":25535}
2026-03-11 10:42:07 -04:00
Tobi Lutke
fd4a7af290
Replace manual scan_quoted_string with regex capture groups\n\nResult: {"status":"keep","combined_µs":4102,"parse_µs":2849,"render_µs":1253,"allocations":25535}
2026-03-11 10:41:44 -04:00
Tobi Lutke
e15b163f1a
Replace manual rest_blank? with regex skip + eos? check\n\nResult: {"status":"keep","combined_µs":4047,"parse_µs":2795,"render_µs":1252,"allocations":25535}
2026-03-11 10:41:20 -04:00
Tobi Lutke
11c22eb75d
Replace manual scan_comparison_op with regex — cleaner and avoids byteslice allocation for op strings\n\nResult: {"status":"keep","combined_µs":4007,"parse_µs":2808,"render_µs":1199,"allocations":25535}
2026-03-11 10:40:47 -04:00
Tobi Lutke
f8b08b5b64
Replace manual scan_fragment/scan_quoted_string_raw/skip_fragment with regex — cleaner, same/better perf\n\nResult: {"status":"keep","combined_µs":4132,"parse_µs":2890,"render_µs":1242,"allocations":25535}
2026-03-11 10:40:10 -04:00
Tobi Lutke
6db20e908b
Replace manual byte-level scan_number with regex — cleaner code, same performance\n\nResult: {"status":"keep","combined_µs":4184,"parse_µs":2931,"render_µs":1253,"allocations":25535}
2026-03-11 10:39:14 -04:00
Tobi Lutke
ecc23184ce
Replace manual byte-level scan_id/skip_id with regex — C-level StringScanner.scan is faster than Ruby-level byte scanning\n\nResult: {"status":"keep","combined_µs":4185,"parse_µs":2943,"render_µs":1242,"allocations":25535}
2026-03-11 10:37:09 -04:00
Tobi Lutke
4df608a12f
Fast-path Hash lookups in VariableLookup#evaluate — skip respond_to? checks for Hash objects\n\nResult: {"status":"keep","combined_µs":4110,"parse_µs":2922,"render_µs":1188,"allocations":25535}
2026-03-11 10:35:29 -04:00
Tobi Lutke
b058f79cbf
Skip to_liquid/context= for primitives in VariableLookup#evaluate\n\nResult: {"status":"keep","combined_µs":4334,"parse_µs":3062,"render_µs":1272,"allocations":25535}
2026-03-11 10:32:37 -04:00
Tobi Lutke
94562eae32
Fast return for primitive types in find_variable — skip to_liquid and respond_to?(:context=)\n\nResult: {"status":"keep","combined_µs":4225,"parse_µs":3009,"render_µs":1216,"allocations":25535}
2026-03-11 10:31:59 -04:00
Tobi Lutke
0e84955531
Skip find_index when only one scope in find_variable — go straight to environments\n\nResult: {"status":"keep","combined_µs":4323,"parse_µs":3055,"render_µs":1268,"allocations":25535}
2026-03-11 10:31:35 -04:00
Tobi Lutke
c4593ceeb6
Skip respond_to?(:context=) for primitive types in find_variable — avoids method lookup overhead\n\nResult: {"status":"keep","combined_µs":4207,"parse_µs":2943,"render_µs":1264,"allocations":25535}
2026-03-11 10:30:41 -04:00
Tobi Lutke
9e2937945b
Use EMPTY_ARRAY for empty static_environments in Context — avoids 60 array allocs per render cycle\n\nResult: {"status":"keep","combined_µs":4262,"parse_µs":3079,"render_µs":1183,"allocations":25535}
2026-03-11 10:26:30 -04:00
Tobi Lutke
cd308b8b01
Lazy @changes hash in Registers — only allocate when a register is actually written\n\nResult: {"status":"keep","combined_µs":4287,"parse_µs":3059,"render_µs":1228,"allocations":25595}
2026-03-11 10:25:29 -04:00
Tobi Lutke
e3fc735de7
Cache block_delimiter strings per tag name — avoids repeated string interpolation\n\nResult: {"status":"keep","combined_µs":4372,"parse_µs":3127,"render_µs":1245,"allocations":25605}
2026-03-11 10:23:56 -04:00
Tobi Lutke
9af3ba3aa7
Lazy Context init: defer StringScanner and @interrupts array allocation until needed\n\nResult: {"status":"keep","combined_µs":4299,"parse_µs":3057,"render_µs":1242,"allocations":26015}
2026-03-11 10:22:29 -04:00
Tobi Lutke
99e55c2eb5
Cache small integer to_s (0-999): avoids 267 Integer#to_s allocations per render cycle\n\nResult: {"status":"keep","combined_µs":4158,"parse_µs":2920,"render_µs":1238,"allocations":26128}
2026-03-11 10:20:45 -04:00
Tobi Lutke
b48615f4a7
Replace split+join in truncatewords with manual word scan — avoids array + string allocations\n\nResult: {"status":"keep","combined_µs":4280,"parse_µs":3009,"render_µs":1271,"allocations":26395}
2026-03-11 10:20:11 -04:00
Tobi Lutke
6723d4fa15
Extend fast-path filter parsing to handle comma-separated multi-arg filters (e.g. pluralize: 'item', 'items')\n\nResult: {"status":"keep","combined_µs":4266,"parse_µs":3032,"render_µs":1234,"allocations":26480}
2026-03-11 10:16:39 -04:00
Tobi Lutke
c252d50aa0
Avoid expr_markup byteslice when name is entire markup string (no whitespace, no filters)\n\nResult: {"status":"keep","combined_µs":4277,"parse_µs":3057,"render_µs":1220,"allocations":27026}
2026-03-11 10:12:26 -04:00
Tobi Lutke
a249010cef
Fast-path single-arg filter parsing: handle quoted strings, numbers, identifiers without Lexer/Parser\n\nResult: {"status":"keep","combined_µs":4427,"parse_µs":3181,"render_µs":1246,"allocations":27235}
2026-03-11 10:09:59 -04:00
Tobi Lutke
18a72db820
fix rubocop offenses: autocorrect style/layout violations
2026-03-11 09:53:44 -04:00
Tobi Lutke
1f59732aee
update autoresearch.md with full progress log
2026-03-11 09:24:26 -04:00
Tobi Lutke
cdc34388e3
For tag: migrate lax_parse to Cursor with zero-alloc skip_id/expect_id
2026-03-11 09:19:59 -04:00
Tobi Lutke
bf1f5cb62d
Cursor: add skip_id, expect_id, skip_fragment for zero-alloc scanning
2026-03-11 09:19:27 -04:00
Tobi Lutke
0596591fdf
REVERTED: Cursor for For tag adds 148 allocs from scan_id/scan_fragment string creation\n\nResult: {"status":"discard","combined_µs":5049,"parse_us":3765,"render_us":1284,"allocations":29793,"parse_µs":3765,"render_µs":1284}
2026-03-11 09:18:35 -04:00
Tobi Lutke
dd4a100346
remove dead BlockBody.parse_tag_token and If SIMPLE_CONDITION - now in Cursor
2026-03-11 09:17:29 -04:00
Tobi Lutke
9de1527099
introduce Cursor class: centralize byte-level scanning for tag/variable/condition parsing
2026-03-11 09:15:21 -04:00
Tobi Lutke
091534f981
add parse_simple to skip simple_lookup? check when caller validates
2026-03-11 09:10:05 -04:00
Tobi Lutke
0b07487e0c
fast-path VariableLookup init: skip scan_variable for simple identifier chains
2026-03-11 09:08:44 -04:00
Tobi Lutke
3799d4c488
avoid allocating seen={} hash in Utils.to_s/inspect when not needed
2026-03-11 09:02:42 -04:00
Tobi Lutke
c4186a16fc
update autoresearch.sh: 3-run best-of, skip liquid-spec for speed
2026-03-11 09:01:57 -04:00
Tobi Lutke
b90d7f0a08
optimize Context init: avoid unnecessary array wrapping for environments
2026-03-11 08:56:45 -04:00
Tobi Lutke
405e3dca48
use frozen EMPTY_ARRAY/EMPTY_HASH for Context @filters/@disabled_tags
2026-03-11 08:55:55 -04:00
Tobi Lutke
69430e9a88
replace INTEGER_REGEX/FLOAT_REGEX with byte-level parse_number
2026-03-11 08:54:31 -04:00
Tobi Lutke
79840b1eaa
replace SIMPLE_CONDITION regex with manual byte parser in if/elsif lax_parse
2026-03-11 08:52:49 -04:00
Tobi Lutke
4cda1a578c
fast-path slice_collection: skip copy for full Array without offset/limit
2026-03-11 08:50:34 -04:00
Tobi Lutke
d574f193dc
add invoke_two fast path for single-arg filter invocation, avoids splat chain
2026-03-11 08:49:37 -04:00
Tobi Lutke
76ae8f13e9
fast-path find_variable: check top scope first before find_index
2026-03-11 08:48:16 -04:00
Tobi Lutke
526af22574
add invoke_single fast path for no-arg filter invocation, avoids splat alloc
2026-03-11 08:47:21 -04:00
Tobi Lutke
03a1977ffe
fast-path simple if truthiness: use byte scanner before SIMPLE_CONDITION regex
2026-03-11 08:36:28 -04:00
Tobi Lutke
b03adefb1c
update autoresearch.md progress log
2026-03-11 08:35:43 -04:00
Tobi Lutke
2e207e6844
replace WhitespaceOrNothing regex with byte-level blank_string? check
2026-03-11 08:34:15 -04:00
Tobi Lutke
e5933fc6e4
avoid array allocation in parse_tag_token: return tag_name, store markup/newlines as class ivars
2026-03-11 08:33:19 -04:00
Tobi Lutke
1882edb1e1
clean up filter parsing: Lexer fallback for args, no-arg fast scan stays
2026-03-11 08:31:30 -04:00
Tobi Lutke
83037f978b
autoresearch.md: add strategic direction toward single-pass scanner architecture
2026-03-11 08:29:12 -04:00
Tobi Lutke
ad98d1f329
add security constraint to autoresearch.md, fix strict mode gate
2026-03-11 08:26:40 -04:00
Tobi Lutke
9fd7cec564
split filter parsing: scan no-arg filters directly, only invoke Lexer when args present
2026-03-11 08:26:04 -04:00
Tobi Lutke
2543fdc1a1
autoresearch: add autoresearch.md/sh, increase benchmark warmup to 20 iterations
2026-03-11 08:23:51 -04:00
Tobi Lutke
17daac92da
extend fast-path to handle quoted string literal variables (262 more fast-pathed)
2026-03-11 08:20:39 -04:00
Tobi Lutke
283961d6c9
skip filter arg splat for no-arg filters, trim render loop comments
2026-03-11 08:06:23 -04:00
Tobi Lutke
db434923d0
hoist write score check out of render loop: skip increment_write_score when no limits active
2026-03-11 08:04:40 -04:00
Tobi Lutke
b86143eb0e
use frozen EMPTY_ARRAY for disabled_tags in Variable
2026-03-11 07:47:51 -04:00
Tobi Lutke
58d2514521
return [tag_name, markup, newlines] from parse_tag_token: avoid 2 whitespace string allocs
2026-03-11 07:45:15 -04:00
Tobi Lutke
82407092cc
use getbyte dispatch instead of start_with? in parse_for_document
2026-03-11 07:44:12 -04:00
Tobi Lutke
544d8f1c17
avoid empty array allocation in evaluate_filter_expressions for no-arg filters
2026-03-11 07:43:09 -04:00
Tobi Lutke
cfa0dfe3ca
replace For tag Syntax regex with manual byte-level parser
2026-03-11 07:39:36 -04:00
Tobi Lutke
2d3b856b36
expose expression_cache/string_scanner via attr_reader, skip regex in filter args without colon
2026-03-11 07:38:16 -04:00
Tobi Lutke
8a92a4e451
unified fast-path Variable parsing: handle both plain lookups and filter chains without full Lexer pass for name
2026-03-11 07:36:29 -04:00
Tobi Lutke
f8b015646a
fast-path render for filter-less variables: skip render method overhead
2026-03-11 07:33:18 -04:00
Tobi Lutke
6bcc2936a2
skip TagAttributes scan in for tag when no colon present
2026-03-11 07:32:39 -04:00
Tobi Lutke
fe7a2f5aa8
fast-path simple if conditions: skip ExpressionsAndOperators scan for single conditions
2026-03-11 07:31:26 -04:00
Tobi Lutke
3939d74531
replace SIMPLE_VARIABLE regex with byte-level scanner to avoid MatchData
2026-03-11 07:30:34 -04:00
Tobi Lutke
25f9224c85
fast-path simple variable parsing: skip Lexer/Parser for plain dot-separated lookups
2026-03-11 07:29:47 -04:00
Tobi Lutke
5da223275a
use frozen EMPTY_ARRAY for Variable filters when no filters present
2026-03-11 07:28:04 -04:00
Tobi Lutke
1a79cf6266
fast-path variable_lookups: skip mutable string alloc when no dot/bracket follows
2026-03-11 07:26:40 -04:00
Tobi Lutke
c1113ad2f8
fast-path String in render_obj_to_output, avoid Utils.to_s dispatch for common case
2026-03-11 07:24:30 -04:00
Tobi Lutke
fa412245f7
short-circuit parse_number with first-byte check before regex
2026-03-11 07:23:41 -04:00
Tobi Lutke
d79b9fa254
avoid unnecessary strip allocation in Expression.parse, use byteslice for string literals
2026-03-11 07:23:08 -04:00
Tobi Lutke
d291e63006
use equal? for frozen array comparison in Lexer, skip whitespace with \s+
2026-03-11 07:21:55 -04:00
Tobi Lutke
2b78e4bf72
use getbyte instead of string indexing in whitespace_handler and create_variable
2026-03-11 07:19:26 -04:00
Tobi Lutke
7aded8e61f
add auto/bench.sh: unit tests + liquid-spec + perf benchmark
2026-03-11 07:17:01 -04:00
Tobi Lutke
97e6893c1a
replace VariableParser regex scan with manual byte parser in VariableLookup
2026-03-11 07:14:14 -04:00
Tobi Lutke
3329b09dd4
replace FullToken regex with manual byte parsing in parse_for_document
2026-03-11 07:12:38 -04:00
Tobi Lutke
4ea835ae04
add quick benchmark script for autoresearch
2026-03-11 07:10:28 -04:00
Tobi Lutke and Claude Opus 4.5
eaa9f215bf
Add lax and YJIT liquid-spec adapters
...
- ruby_liquid_lax.rb: Tests lax parsing mode with :lax_parsing feature
- ruby_liquid_yjit.rb: Tests YJIT + strict mode + ActiveSupport
Matrix results: 4483 matched, 18 different (lax edge cases), 61 skipped
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <[email protected]
2026-01-05 15:11:29 -10:00
Tobi Lutke and Claude Opus 4.5
ccd05e869c
Make blank/empty comparisons invariant to ActiveSupport
...
- Implement liquid_blank? and liquid_empty? methods in Condition
to emulate ActiveSupport's behavior when it's not loaded
- This ensures templates like `{% if x == blank %}` work identically
whether ActiveSupport is loaded or not
- Update liquid-spec adapters for new API (ctx parameter)
- Add rake spec task for running liquid-spec matrix
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <[email protected]
2026-01-05 14:54:43 -10:00
Tobias Lütke and GitHub
a4a29f3e08
Merge pull request #2034 from Shopify/fix-liquid-spec-without-activesupport
...
Require liquid-spec to be run on commit automatically and related fixes
2026-01-01 22:32:38 -05:00
Tobi Lutke
0058e4322b
Add fail-fast: false to prevent job cancellation
2026-01-01 22:30:14 -05:00
Tobi Lutke
50e1789537
Use liquid-spec feature branch until PR is merged
2026-01-01 22:29:32 -05:00
Tobi Lutke
79a2e042ff
Use liquid-spec main branch
2026-01-01 22:24:00 -05:00
Tobi Lutke
ddee08fb95
Add activesupport feature to with_active_support adapter
...
Both adapters now pass with 0 failures:
- ruby_liquid.rb: 4194 passed (skips activesupport and shopify_error_handling specs)
- ruby_liquid_with_active_support.rb: 4203 passed (skips shopify_error_handling specs)
2026-01-01 22:21:47 -05:00
Tobi Lutke
2988f1a500
Update liquid-spec to branch with per-spec required_features support
2026-01-01 22:15:38 -05:00
Tobi Lutke