 Michael Go
|
18710d7c43
|
debug: track expression parse time
|
2024-11-20 13:37:09 -04:00 |
|
|
Michael GoandGitHub
|
e5d18c83bb
|
Merge pull request #1848 from Shopify/env-warn-cleanup
clean up all warnings by using new Environment
|
2024-11-04 16:17:17 -04:00 |
|
|
Michael Go
|
c77ff68573
|
clean up all warnings by using new Environment
|
2024-11-04 16:15:05 -04:00 |
|
|
Michael GoandGitHub
|
8d8661349a
|
Merge pull request #1843 from Shopify/empty-array
avoid allocating new empty array
|
2024-11-04 15:36:46 -04:00 |
|
|
Michael Go
|
1f3ea7322b
|
avoid allocating new empty array
|
2024-11-04 15:35:45 -04:00 |
|
|
Michael GoandGitHub
|
06f44226c0
|
Merge pull request #1846 from Shopify/env-propgating
propagate Environment on new Context creation
|
2024-11-04 15:33:50 -04:00 |
|
|
Michael GoandGitHub
|
4bd22a26dc
|
Merge pull request #1845 from Shopify/remove-tag-registry
remove TagRegistry
|
2024-11-04 15:33:30 -04:00 |
|
|
Michael Go
|
3ed54bfdf9
|
propagate Environment on new Context creation
|
2024-11-04 15:32:07 -04:00 |
|
|
Michael Go
|
29986d3704
|
remove TagRegistry
|
2024-11-04 15:22:56 -04:00 |
|
|
Michael GoandGitHub
|
8e40f8050a
|
Merge pull request #1838 from Shopify/quirky-lexer-parsing
fix parsing quirky incomplete expressions
|
2024-10-30 13:52:47 -03:00 |
|
|
Michael Go
|
ffce6de8bb
|
avoid using StringScanner eos
|
2024-10-30 13:45:10 -03:00 |
|
|
Michael Go
|
f00670cb01
|
refactor lexer unit test
|
2024-10-30 13:44:36 -03:00 |
|
|
Michael Go
|
f6a3e25e2e
|
fix parsing quirky incomplete expressions
|
2024-10-30 13:44:35 -03:00 |
|
|
Michael GoandGitHub
|
f6ffc37cf2
|
Merge pull request #1840 from Shopify/fix-lexer-contains-as-id
fix lexer parsing ID 'contains' as comparison
|
2024-10-30 13:43:48 -03:00 |
|
|
Michael Go
|
1375a9e4dc
|
fix lexer parsing ID 'contains' as comparison
|
2024-10-30 13:39:55 -03:00 |
|
|
Michael GoandGitHub
|
c626dfa1a1
|
Merge pull request #1839 from Shopify/lexer-parse-error-with-utf8
raise syntax error from lexer parser with UTF-8 character
|
2024-10-30 13:39:05 -03:00 |
|
|
Michael Go
|
8a9f33a060
|
raise syntax error from lexer parser with utf8 character
|
2024-10-29 22:04:37 -03:00 |
|
|
Michael GoandGitHub
|
1943441361
|
Merge pull request #1835 from Shopify/fix-multibyte-variable-parsing
fix parsing Variable blockbody with multibyte character
|
2024-10-28 19:31:21 -03:00 |
|
|
Michael GoandGitHub
|
36251e640c
|
Merge pull request #1837 from Shopify/lexer-comparison-fix
fix lexer parsing comparison without whitespaces
|
2024-10-28 19:31:11 -03:00 |
|
|
Michael Go
|
d94293a464
|
fix lexer parsing comparison without whitespaces
|
2024-10-28 19:30:12 -03:00 |
|
|
Michael Go
|
6c13805a60
|
fix parsing Variable blockbody with multibyte character
|
2024-10-28 17:33:55 -03:00 |
|
|
Michael GoandGitHub
|
b4196489c2
|
Merge pull request #1833 from Shopify/fast-variable-parse
Faster Variable BlockBody Matching
|
2024-10-28 15:28:04 -03:00 |
|
|
Michael Go
|
fb6ac72520
|
use byteslice to create Variable BlockBody
|
2024-10-25 15:41:35 -03:00 |
|
|
Michael Go
|
cb16219552
|
faster BlockBody variable matching
|
2024-10-25 15:22:56 -03:00 |
|
|
Michael GoandGitHub
|
4a4fe3c72a
|
Merge pull request #1781 from Shopify/contextualize-before-to-liquid
update variable's context before invoking its to_liquid
|
2024-02-12 16:58:54 -04:00 |
|
|
Michael Go
|
4f35b0bc66
|
update liquid-c
|
2024-02-12 16:49:52 -04:00 |
|
|
Michael Go
|
a5e5fab82a
|
update variable's context before invoking its to_liquid
|
2024-02-12 16:48:20 -04:00 |
|
|
Michael GoandGitHub
|
9b38a15282
|
Merge pull request #1776 from Shopify/refactor/invalid-encoding-error
add new TemplateEncodingError
|
2024-01-12 12:38:34 -04:00 |
|
|
Michael Go
|
7b25b770af
|
add new TemplateEncodingError
|
2024-01-12 12:17:20 -04:00 |
|
|
Michael GoandGitHub
|
cf76c0bbec
|
Merge pull request #1775 from Shopify/allow-nil-template-source
allow non-string template source
|
2024-01-12 10:48:30 -04:00 |
|
|
Michael Go
|
6a0fe3f7e3
|
convert template source to string to ensure encoding validity
|
2024-01-10 16:50:31 -04:00 |
|
|
Michael Go
|
730ad3684a
|
allow nil template source
|
2024-01-10 16:32:08 -04:00 |
|
|
Michael GoandGitHub
|
3ac7e470e6
|
Merge pull request #1774 from Shopify/check-utf8-validity
check template UTF8 validity before parsing
|
2024-01-10 15:27:49 -04:00 |
|
|
Michael Go
|
369a6c55e3
|
check template UTF8 validity before parsing
|
2024-01-10 18:58:15 +00:00 |
|
|
Michael GoandGitHub
|
f5ed5404b5
|
Merge pull request #1773 from Shopify/liquid-tag-whitespace-control-with-comment
don't reset Liquid tag's whitespace control from comment tag
|
2024-01-05 10:54:32 -04:00 |
|
|
Michael Go
|
a3c837687e
|
don't reset Liquid tag's whitespace control from comment tag
|
2024-01-05 10:21:33 -04:00 |
|
|
Michael GoandGitHub
|
96a036372d
|
Merge pull request #1770 from Shopify/revert-invalid-comment-body
don't allow invalid syntax inside comment tag
|
2024-01-02 11:07:05 -04:00 |
|
|
Michael Go
|
fc9c338682
|
refactor: rename comment tag unit test
|
2023-12-14 17:08:26 -04:00 |
|
|
Michael Go
|
3c5ad7db61
|
don't allow invalid syntax inside comment tag
|
2023-12-14 17:01:03 -04:00 |
|
|
Michael GoandGitHub
|
c658bf970a
|
Merge pull request #1769 from Shopify/comment-tag-with-extra-string
fix parsing comment tag with extra string
|
2023-12-13 14:16:44 -04:00 |
|
|
Michael Go
|
c618ac1c9f
|
fix parsing comment tag with extra string
|
2023-12-12 16:23:37 -04:00 |
|
|
Michael GoandGitHub
|
11a1f8e673
|
Merge pull request #1764 from Shopify/fix-comment-tag-whitespace-control
implement whitespace control to comment tag
|
2023-12-06 14:30:16 -05:00 |
|
|
Michael Go
|
24d461a9e3
|
implement whitespace control to comment tag
|
2023-12-01 16:04:03 -04:00 |
|
|
Michael GoandGitHub
|
cbb422e5d3
|
Merge pull request #1763 from Shopify/fix-comment-tag-delim-parsing
fix parsing comment tag delimiter
|
2023-12-01 15:35:32 -04:00 |
|
|
Michael Go
|
bf0f79f36c
|
fix parsing comment tag delimiter
|
2023-11-30 13:24:54 -04:00 |
|
|
Michael GoandGitHub
|
cf2787791e
|
Merge pull request #1755 from Shopify/non-parsing-comment
Don't parse nodes inside a comment tag
|
2023-11-29 14:10:20 -04:00 |
|
|
Michael Go
|
6a5ebb0e85
|
fix parsing nested comment tag with extra strings
|
2023-11-11 12:19:44 -04:00 |
|
|
Michael Go
|
6dafc19b6d
|
fix parsing comment tag delimiter with extra strings
|
2023-11-10 15:42:54 -04:00 |
|
|
Michael Go
|
41f65173b0
|
fix parsing comment block body inside a liquid tag
|
2023-11-09 16:27:23 -04:00 |
|
|
Michael Go
|
e180535784
|
allow incomplete tags inside a comment tag
|
2023-11-08 16:50:41 -04:00 |
|
|
Michael Go
|
a681e73aec
|
refactor comment tag unit test to use test helper
|
2023-11-08 16:45:11 -04:00 |
|
|
Michael Go
|
2abf52d546
|
add a quirky comment tag unit test
|
2023-11-08 11:23:00 -04:00 |
|
|
|
eada2b65a2
|
clean up comment tag body parsing
Co-authored-by: Peter Zhu <[email protected]>
|
2023-11-08 11:13:13 -04:00 |
|
|
Michael GoandAlex Coco
|
dbf0aa8cd5
|
don't parse nodes inside a comment tag
Co-authored-by: Alex Coco <[email protected]>
|
2023-11-07 18:38:13 -04:00 |
|
|
Michael GoandGitHub
|
c44d1d9193
|
Merge pull request #1727 from Shopify/partial-cache-with-error-mode
include parse mode to partial cache key
|
2023-06-27 15:06:58 -03:00 |
|
|
Michael Go
|
dd7bbf26bc
|
include error mode to partial cache key
|
2023-06-23 18:48:07 -03:00 |
|
|
Michael GoandGitHub
|
48cb643c02
|
Merge pull request #1695 from Shopify/syntax-error-with-filename
render template name with Liquid Syntax errors
|
2023-03-02 17:08:27 -04:00 |
|
|
Michael Go
|
1d97389fb0
|
render template name with Liquid Syntax errors
|
2023-03-02 16:50:55 -04:00 |
|
|
Michael GoandGitHub
|
3ff4170cb0
|
Merge pull request #1692 from Shopify/error-message-with-filepath
set context's template_name with template.name in render and include tag
|
2023-02-28 10:57:24 -04:00 |
|
|
Michael Go
|
24dceef552
|
set context's template_name with template's name
|
2023-02-28 10:55:38 -04:00 |
|
|
Michael Go
|
428c66ffac
|
add name attribute to Template for more flexibility to set context's template name
|
2023-02-27 17:11:52 -04:00 |
|
|
Michael Go
|
0fe4a5d144
|
render error message with actual template path
|
2023-02-27 11:01:21 -04:00 |
|
|
Michael GoandGitHub
|
4599e5459f
|
Merge pull request #1684 from Shopify/fix-variable-lookup-parse-timeout
fix variable lookup parse timing out with missing closing bracket
|
2023-02-02 10:39:46 -04:00 |
|
|
Michael Go
|
bd9c3802c8
|
add variable parser timeout unit tests
|
2023-02-01 21:15:35 -04:00 |
|
|
Michael Go
|
2b40850e4a
|
fix variable lookup parse timing out with missing closing bracket
|
2023-02-01 19:52:30 -04:00 |
|
|
Michael GoandGitHub
|
6a888d4564
|
Merge pull request #1680 from Shopify/recursively-parse-brackets
recursively parse brackets on variable lookup
|
2023-01-31 16:29:54 -04:00 |
|
|
Michael Go
|
dd257b3d66
|
add an unit test for double nest variable lookup
|
2023-01-30 20:36:14 -04:00 |
|
|
Michael Go
|
1aaf6ed019
|
recursively parse brackets on variable lookup
|
2023-01-30 20:19:35 -04:00 |
|
|
Michael GoandGitHub
|
daf93a83c2
|
Merge pull request #1676 from Shopify/tablerow-nil-params
raise invalid integer argument error from tablerow
|
2023-01-18 11:08:04 -04:00 |
|
|
Michael Go
|
e889a9da0b
|
use to_i to parse parameters of tablerow tag
|
2023-01-17 17:48:16 -04:00 |
|
|
Michael Go
|
0f11c97623
|
raise invalid integer argument error from tablerow
|
2023-01-16 18:53:53 -04:00 |
|
|
Michael GoandGitHub
|
eff2a63204
|
Merge pull request #1633 from Shopify/fix-tablerow-drop-cols-last-attr
fix tablerow drop's last attribute with missing cols param
|
2022-10-05 14:15:03 -03:00 |
|
|
Michael Go
|
fbab19ac8c
|
fix tablerow drop's last attribute with missing cols param
|
2022-10-05 11:15:23 -03:00 |
|
|
Michael GoandGitHub
|
50d1a2ffc9
|
Merge pull request #1458 from Shopify/use-to-liquid-value-with-conditions
use Utils.to_liquid_value on conditionals
|
2021-06-15 12:18:14 -03:00 |
|
|
Michael Go
|
f686c5dec7
|
use Utils.to_liquid_value on conditionals
|
2021-06-14 18:19:37 -03:00 |
|
|
Michael GoandGitHub
|
aa8ce87b96
|
Merge pull request #1454 from Shopify/default-filter-with-to-liquid-value
utilize input's to_liquid_value on default filter
|
2021-06-14 15:43:56 -03:00 |
|
|
Michael GoandGitHub
|
be81c9ae5a
|
Merge pull request #1457 from Shopify/fix-unless-to-use-to-liquid-value-helper
fix unless to use to_liquid_value helper with multiple conditions
|
2021-06-10 14:00:19 -03:00 |
|
|
Michael Go
|
edd4d70aee
|
fix unless to use to_liquid_value helper with multiple conditions
|
2021-06-10 13:28:17 -03:00 |
|
|
Michael Go
|
ac66dbbafe
|
utilize input's to_liquid_value on default filter
|
2021-06-08 15:20:53 -03:00 |
|
|
Michael GoandGitHub
|
250555c9a8
|
Merge pull request #1441 from Shopify/to-raw-value
Implement to_liquid_value to Liquid::Drop
|
2021-05-27 10:21:05 -03:00 |
|
|
Michael Go
|
e361a4d53c
|
introduce to_liquid_value on variable look and conditional statements
|
2021-05-26 17:27:18 -03:00 |
|