Fix #warnings taking exponential time to compute

This commit is contained in:
Justin Li
2014-11-12 16:12:00 -05:00
parent 3321cffe08
commit 422bafd66a
2 changed files with 11 additions and 1 deletions
+1 -1
View File
@@ -62,7 +62,7 @@ module Liquid
def warnings
all_warnings = []
nodelist.each do |node|
all_warnings.concat(node.warnings) if node.respond_to?(:warnings) && node.warnings
all_warnings.concat(node.warnings) if node.respond_to?(:warnings)
end
all_warnings
end
+10
View File
@@ -37,6 +37,16 @@ class TemplateTest < Minitest::Test
assert_equal 'from instance assigns', t.parse("{{ foo }}").render!
end
def test_warnings_is_not_exponential_time
str = "false"
100.times do
str = "{% if true %}true{% else %}#{str}{% endif %}"
end
t = Template.parse(str)
assert_equal [], t.warnings
end
def test_instance_assigns_persist_on_same_template_parsing_between_renders
t = Template.new.parse("{{ foo }}{% assign foo = 'foo' %}{{ foo }}")
assert_equal 'foo', t.render!