mirror of
https://github.com/jamiepine/voicebox.git
synced 2026-09-16 13:20:39 -07:00
a3fa9a2784
* fix(backend): return 404 instead of 500 for audio of failed generations
A failed generation stores an empty audio_path. resolve_storage_path("")
resolved to the data directory itself, which exists, so the route's 404
guard passed and FileResponse raised RuntimeError ("File at path .../data
is not a file"), surfacing as a 500.
- resolve_storage_path now returns None for empty paths
- audio routes check is_file() instead of exists() so directories never
reach FileResponse
- GET /audio/{generation_id} reports "Generation failed; no audio
available" when the generation status is failed
Co-Authored-By: Claude Fable 5 <[email protected]>
* fix(backend): reject empty Path objects in resolve_storage_path
Path("") is truthy, so the previous `if not path` guard only caught
None and empty strings. Callers such as database/migrations.py pass
Path objects, so an empty Path could still resolve to the data dir.
Check None separately and reject paths with no parts.
Also add regression tests asserting the version and sample audio
endpoints 404 when a stored path resolves to an existing directory
(guards the is_file() checks against regressing to exists()).
Addresses CodeRabbit review on PR #893.
Co-Authored-By: Claude Fable 5 <[email protected]>
* style(tests): drop parentheses on pytest.fixture decorator (ruff PT001)
Co-Authored-By: Claude Fable 5 <[email protected]>
* style(tests): satisfy Ruff naming rule
---------
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: Jamie Pine <[email protected]>
88 lines
3.0 KiB
Python
88 lines
3.0 KiB
Python
"""Audio file serving endpoints."""
|
|
|
|
import mimetypes
|
|
from pathlib import Path
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException
|
|
from fastapi.responses import FileResponse
|
|
from sqlalchemy.orm import Session
|
|
|
|
from .. import config, models
|
|
from ..services import history
|
|
from ..database import get_db
|
|
|
|
router = APIRouter()
|
|
|
|
|
|
def _audio_media_type(path: Path) -> str:
|
|
"""Derive the Content-Type from the file extension.
|
|
|
|
Imported audio retains its source format (.mp3, .m4a, .ogg, …) so a
|
|
blanket ``audio/wav`` would mislead strict clients trying to decode
|
|
via the response header instead of sniffing the bytes."""
|
|
guessed, _ = mimetypes.guess_type(path.name)
|
|
return guessed or "audio/wav"
|
|
|
|
|
|
@router.get("/audio/version/{version_id}")
|
|
async def get_version_audio(version_id: str, db: Session = Depends(get_db)):
|
|
"""Serve audio for a specific version."""
|
|
from ..services import versions as versions_mod
|
|
|
|
version = versions_mod.get_version(version_id, db)
|
|
if not version:
|
|
raise HTTPException(status_code=404, detail="Version not found")
|
|
|
|
audio_path = config.resolve_storage_path(version.audio_path)
|
|
if audio_path is None or not audio_path.is_file():
|
|
raise HTTPException(status_code=404, detail="Audio file not found")
|
|
|
|
return FileResponse(
|
|
audio_path,
|
|
media_type=_audio_media_type(audio_path),
|
|
filename=f"generation_{version.generation_id}_{version.label}{audio_path.suffix}",
|
|
)
|
|
|
|
|
|
@router.get("/audio/{generation_id}")
|
|
async def get_audio(generation_id: str, db: Session = Depends(get_db)):
|
|
"""Serve generated audio file (serves the default version)."""
|
|
generation = await history.get_generation(generation_id, db)
|
|
if not generation:
|
|
raise HTTPException(status_code=404, detail="Generation not found")
|
|
|
|
audio_path = config.resolve_storage_path(generation.audio_path)
|
|
if audio_path is None or not audio_path.is_file():
|
|
detail = (
|
|
"Generation failed; no audio available"
|
|
if generation.status == "failed"
|
|
else "Audio file not found"
|
|
)
|
|
raise HTTPException(status_code=404, detail=detail)
|
|
|
|
return FileResponse(
|
|
audio_path,
|
|
media_type=_audio_media_type(audio_path),
|
|
filename=f"generation_{generation_id}{audio_path.suffix}",
|
|
)
|
|
|
|
|
|
@router.get("/samples/{sample_id}")
|
|
async def get_sample_audio(sample_id: str, db: Session = Depends(get_db)):
|
|
"""Serve profile sample audio file."""
|
|
from ..database import ProfileSample as DBProfileSample
|
|
|
|
sample = db.query(DBProfileSample).filter_by(id=sample_id).first()
|
|
if not sample:
|
|
raise HTTPException(status_code=404, detail="Sample not found")
|
|
|
|
audio_path = config.resolve_storage_path(sample.audio_path)
|
|
if audio_path is None or not audio_path.is_file():
|
|
raise HTTPException(status_code=404, detail="Audio file not found")
|
|
|
|
return FileResponse(
|
|
audio_path,
|
|
media_type="audio/wav",
|
|
filename=f"sample_{sample_id}.wav",
|
|
)
|