chore(backend): Ruff lint pass — deprecated APIs, exception leaks, dead patterns

Mechanical sweep of items called out in the PR review:

- qwen_llm_backend: AutoModelForCausalLM.from_pretrained(torch_dtype=…) is deprecated in transformers ≥4.41 in favor of dtype=. Renamed.
- routes/llm: try/except around backend.generate() raised HTTPException(500, detail=str(e)) which leaks stack traces / paths to clients and trips Ruff B904. Now logs the original exception server-side and hands the client a generic message; chained via `from e` to preserve traceback context.
- mcp_bindings + mcp_server/context: datetime.utcnow() is deprecated since 3.12. Switched the two assignment sites to datetime.now(timezone.utc). The schema-level `default=datetime.utcnow` defaults in database/models.py are left for a later schema-aware pass.
- routes/generations: `logger = …` sat between two import blocks (Ruff E402). Moved below imports.
- mcp_server/server + tests/test_refinement_samples: typing.Callable / typing.Iterable have been preferred-via collections.abc since 3.9 (Ruff UP035).
- routes/events: `except asyncio.TimeoutError` aliases plain `TimeoutError` since 3.11 (UP041).
- services/captures: hoisted WHISPER_NATIVE_FORMATS to module scope (was a function-local UPPER_SNAKE that tripped N806) and replaced the raw_path.unlink try/except OSError-pass with contextlib.suppress (SIM105). Semantic equivalence preserved — written_files.remove(raw_path) still only runs when unlink succeeds because it sits inside the suppressed block after the unlink call.
- database/migrations: hoisted the duplicate `import sqlite3` from inside two helper bodies to a single module-level import.
This commit is contained in:
Jamie Pine
2026-04-25 01:40:34 -07:00
parent 6cf8da2698
commit fe14df5fda
10 changed files with 27 additions and 22 deletions
+1 -1
View File
@@ -34,7 +34,7 @@ async def speak_events(request: Request):
return
try:
event = await asyncio.wait_for(queue.get(), timeout=15.0)
except asyncio.TimeoutError:
except TimeoutError:
# Heartbeat so proxies don't reap idle streams.
yield {"event": "ping", "data": "{}"}
continue
+2 -2
View File
@@ -8,8 +8,6 @@ from fastapi import APIRouter, Depends, HTTPException
from fastapi.responses import StreamingResponse
from sqlalchemy.orm import Session
logger = logging.getLogger(__name__)
from .. import models
from ..services import history, personality, profiles, tts
from ..database import Generation as DBGeneration, VoiceProfile as DBVoiceProfile, get_db
@@ -17,6 +15,8 @@ from ..services.generation import run_generation
from ..services.task_queue import cancel_generation as cancel_generation_job, enqueue_generation
from ..utils.tasks import get_task_manager
logger = logging.getLogger(__name__)
router = APIRouter()
+8 -1
View File
@@ -1,5 +1,7 @@
"""LLM inference endpoints."""
import logging
from fastapi import APIRouter, HTTPException
from fastapi.responses import JSONResponse
@@ -9,6 +11,8 @@ from ..services import llm
from ..services.task_queue import create_background_task
from ..utils.tasks import get_task_manager
logger = logging.getLogger(__name__)
router = APIRouter()
@@ -70,4 +74,7 @@ async def llm_generate(request: models.LLMGenerateRequest):
)
return models.LLMGenerateResponse(text=text, model_size=model_size)
except Exception as e:
raise HTTPException(status_code=500, detail=str(e))
# The backend exception text can include filesystem paths and stack
# frames — log it server-side and hand the client a generic message.
logger.exception("LLM generate failed")
raise HTTPException(status_code=500, detail="LLM generation failed") from e
+2 -2
View File
@@ -6,7 +6,7 @@ column is the same value the MCP client sends in ``X-Voicebox-Client-Id``
(or the stdio shim pulls from ``VOICEBOX_CLIENT_ID``).
"""
from datetime import datetime
from datetime import datetime, timezone
from fastapi import APIRouter, Depends, HTTPException
from sqlalchemy.orm import Session
@@ -56,7 +56,7 @@ async def upsert_mcp_binding(
row.profile_id = data.profile_id
row.default_engine = data.default_engine
row.default_personality = data.default_personality
row.updated_at = datetime.utcnow()
row.updated_at = datetime.now(timezone.utc)
db.commit()
db.refresh(row)
return models.MCPClientBindingResponse.model_validate(row)