fix: address PR review feedback from CodeRabbit

- Upgrade softprops/action-gh-release@v1 to @v2 (Node 16 EOL)
- Fail-fast on checksum fetch failure instead of extracting unverified archives
- Abort packaging if no NVIDIA files found (prevents empty cuda-libs archive)
- Fix nvidia/ path detection bug (list membership vs substring check)
- Fix justfile Copy-Item nesting (copy contents, not the directory itself)
This commit is contained in:
Jamie Pine
2026-03-17 06:53:54 -07:00
parent 7d53699c96
commit f96eae2567
4 changed files with 12 additions and 9 deletions
+4 -2
View File
@@ -64,7 +64,7 @@ def is_nvidia_file(rel_path: str) -> bool:
return False
# Files under nvidia/ subdirectory tree (older torch layout)
if rel_lower.startswith("nvidia/") or "nvidia/" in rel_lower.split("/", 1)[-1:]:
if rel_lower.startswith("nvidia/") or "/nvidia/" in rel_lower:
# Only DLLs/shared objects — not .py, .dist-info, etc.
if rel_lower.endswith((".dll", ".so")):
return True
@@ -127,13 +127,15 @@ def package(
if not nvidia_files:
print(
"WARNING: No NVIDIA files found! The CUDA libs archive will be empty.",
f"ERROR: No NVIDIA files found in {onedir_path}. "
"Refusing to create an empty CUDA libs archive.",
file=sys.stderr,
)
print(
"Make sure you built with --cuda and the NVIDIA packages are present.",
file=sys.stderr,
)
sys.exit(1)
# Create server core archive
# Files are stored relative to the archive root (no parent directory prefix)