Labyricorn/voicebox
1
0
Fork 0
mirror of https://github.com/jamiepine/voicebox.git synced 2026-10-03 09:05:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: always clean up temp archive on failure and fix justfile data dir path

Browse Source 
- Wrap download/verify/extract in try/finally so .download-*.tmp is
  always deleted, even on mid-download or extraction failures
- Fix justfile build-server-cuda to use sh.voicebox.app (production path)
This commit is contained in:
Jamie Pine
2026-03-17 09:15:23 -07:00
parent 7bd72ea9f7
commit 81864e831a
2 changed files with 50 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/services/cuda.py
+8 -4
View File
@@ -167,8 +167,9 @@ async def _download_and_extract_archive(
except Exception as e: except Exception as e:
raise RuntimeError(f"{label}: failed to fetch checksum from {sha256_url}") from e raise RuntimeError(f"{label}: failed to fetch checksum from {sha256_url}") from e
# Stream download # Stream download, verify, and extract — always clean up temp file
downloaded = 0 downloaded = 0
try:
async with client.stream("GET", url) as response: async with client.stream("GET", url) as response:
response.raise_for_status() response.raise_for_status()
with open(temp_path, "wb") as f: with open(temp_path, "wb") as f:
@@ -201,8 +202,9 @@ async def _download_and_extract_archive(
sha256.update(data) sha256.update(data)
actual = sha256.hexdigest() actual = sha256.hexdigest()
if actual != expected_sha: if actual != expected_sha:
temp_path.unlink() raise ValueError(
raise ValueError(f"{label} integrity check failed: expected {expected_sha[:16]}..., got {actual[:16]}...") f"{label} integrity check failed: expected {expected_sha[:16]}..., got {actual[:16]}..."
)
logger.info(f"{label}: integrity verified") logger.info(f"{label}: integrity verified")
# Extract (use data filter for path traversal protection on Python 3.12+) # Extract (use data filter for path traversal protection on Python 3.12+)
@@ -219,8 +221,10 @@ async def _download_and_extract_archive(
else: else:
tar.extractall(path=dest_dir) tar.extractall(path=dest_dir)
temp_path.unlink()
logger.info(f"{label}: extracted to {dest_dir}") logger.info(f"{label}: extracted to {dest_dir}")
finally:
if temp_path.exists():
temp_path.unlink()
return downloaded return downloaded
justfile
+1 -1
View File
@@ -208,7 +208,7 @@ build-server-cuda: _ensure-venv
$env:PATH = "{{ venv_bin }};$env:PATH"; \ $env:PATH = "{{ venv_bin }};$env:PATH"; \
& "{{ python }}" backend/build_binary.py --cuda; \ & "{{ python }}" backend/build_binary.py --cuda; \
if ($LASTEXITCODE -ne 0) { throw "build_binary.py --cuda failed with exit code $LASTEXITCODE" }; \ if ($LASTEXITCODE -ne 0) { throw "build_binary.py --cuda failed with exit code $LASTEXITCODE" }; \
$dest = "$env:APPDATA/com.voicebox.app/backends/cuda"; \ $dest = "$env:APPDATA/sh.voicebox.app/backends/cuda"; \
if (Test-Path $dest) { Remove-Item -Recurse -Force $dest }; \ if (Test-Path $dest) { Remove-Item -Recurse -Force $dest }; \
New-Item -ItemType Directory -Path $dest -Force | Out-Null; \ New-Item -ItemType Directory -Path $dest -Force | Out-Null; \
Copy-Item "backend/dist/voicebox-server-cuda/*" $dest -Recurse -Force; \ Copy-Item "backend/dist/voicebox-server-cuda/*" $dest -Recurse -Force; \