mirror of
https://github.com/jamiepine/voicebox.git
synced 2026-10-04 01:25:18 -07:00
fix(history): don't roll back a delete after version files are already unlinked
Review follow-up: a rollback after a failed main-audio unlink restored version rows whose files were already removed. Treat a locked main file like the failed-generation sweep does: log and continue, leaving at worst an orphaned audio file rather than rows that point at nothing.
This commit is contained in:
committed by
capy-ai-staging[bot]
parent
755c664e66
commit
7e9e88de18
@@ -306,8 +306,10 @@ async def delete_generation(
|
|||||||
try:
|
try:
|
||||||
audio_path.unlink()
|
audio_path.unlink()
|
||||||
except OSError:
|
except OSError:
|
||||||
db.rollback()
|
# Version files are already gone by now, so rolling back would
|
||||||
raise
|
# leave rows pointing at missing audio. Mirror the sweep below:
|
||||||
|
# keep going and leave the locked file as an orphan instead.
|
||||||
|
logger.warning("Could not delete generation audio %s", audio_path)
|
||||||
|
|
||||||
# Delete from database
|
# Delete from database
|
||||||
db.delete(generation)
|
db.delete(generation)
|
||||||
|
|||||||
Reference in New Issue
Block a user