Labyricorn/voicebox
1
0
Fork 0
mirror of https://github.com/jamiepine/voicebox.git synced 2026-10-03 09:05:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(backend): pin miniaudio in requirements-mlx.txt (#505)

Browse Source 
mlx-audio's STT path imports miniaudio, but we install mlx-audio
--no-deps to dodge its transformers>=5.x pin. Nothing else pulls
miniaudio transitively, so fresh Apple Silicon installs fail to
transcribe with ModuleNotFoundError: miniaudio. Listed explicitly
and updated the stale comments in requirements-mlx.txt and
release.yml that claimed it came from other engines.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This commit is contained in:
James Pine
2026-04-20 01:18:51 -07:00
co-authored by Claude Opus 4.7
parent 5aa1677a25
commit 791c0509a9
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/release.yml
+4 -2
View File
@@ -106,8 +106,10 @@ jobs:
# fine on transformers 4.57.x in practice (verified in dev), so install # fine on transformers 4.57.x in practice (verified in dev), so install
# them --no-deps. mlx-audio's other runtime deps (huggingface_hub, # them --no-deps. mlx-audio's other runtime deps (huggingface_hub,
# librosa, numpy, numba, pyloudnorm) are already in requirements.txt; # librosa, numpy, numba, pyloudnorm) are already in requirements.txt;
# the rest (sounddevice, miniaudio, protobuf, sentencepiece, pyyaml, # miniaudio is in requirements-mlx.txt (needed by mlx_audio.stt,
# jinja2) are pulled in by other engines. # not transitively pulled by anything else — see issue #505); the
# rest (sounddevice, protobuf, sentencepiece, pyyaml, jinja2) are
# pulled in by other engines.
pip install --no-deps mlx-lm==0.31.1 pip install --no-deps mlx-lm==0.31.1
pip install --no-deps mlx-audio==0.4.1 pip install --no-deps mlx-audio==0.4.1
backend/requirements-mlx.txt
+10 -3
View File
@@ -3,6 +3,12 @@
mlx>=0.30.0 mlx>=0.30.0
# miniaudio is a runtime dep of mlx-audio's STT path (mlx_audio.stt).
# mlx-audio itself is installed --no-deps (see comment below), so we
# must list miniaudio explicitly here or transcription fails on fresh
# M1 installs with `ModuleNotFoundError: miniaudio` (issue #505).
miniaudio>=1.59
# NOTE: mlx-audio is intentionally not listed here. From 0.3.1 onward it # NOTE: mlx-audio is intentionally not listed here. From 0.3.1 onward it
# declares `transformers==5.0.0rc3` / `>=5.0.0`, which conflicts with the # declares `transformers==5.0.0rc3` / `>=5.0.0`, which conflicts with the
# `transformers<=4.57.6` cap in requirements.txt and breaks CI's clean # `transformers<=4.57.6` cap in requirements.txt and breaks CI's clean
@@ -10,6 +16,7 @@ mlx>=0.30.0
# mlx_audio.stt.load) works fine on transformers 4.57.x in practice. # mlx_audio.stt.load) works fine on transformers 4.57.x in practice.
# #
# Install it via `pip install --no-deps mlx-audio==0.4.1` after this file # Install it via `pip install --no-deps mlx-audio==0.4.1` after this file
# (see .github/workflows/release.yml). All other mlx-audio runtime deps # (see .github/workflows/release.yml). Most other mlx-audio runtime deps
# (huggingface_hub, librosa, miniaudio, mlx-lm, numba, numpy, protobuf, # (huggingface_hub, librosa, mlx-lm, numba, numpy, protobuf, pyloudnorm,
# pyloudnorm, sounddevice, tqdm) are already in requirements.txt. # sounddevice, tqdm) are already in requirements.txt or pulled in by
# other engines.