Labyricorn/voicebox
1
0
Fork 0
mirror of https://github.com/jamiepine/voicebox.git synced 2026-09-29 07:05:14 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix error detail serialization producing [object Object] in error messages

Browse Source 
Closes #290
This commit is contained in:
Jamie Pine
2026-03-16 22:47:01 -07:00
parent f1541701fb
commit 664178f0cf
1 changed files with 26 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/lib/api/client.ts
+26 -11
View File
@@ -35,6 +35,21 @@ import type {
WhisperModelSize, WhisperModelSize,
} from './types'; } from './types';
function formatErrorDetail(detail: unknown, fallback: string): string {
if (typeof detail === 'string') return detail;
if (Array.isArray(detail)) {
return detail
.map((e: Record<string, unknown>) => e.msg || e.message || JSON.stringify(e))
.join('; ');
}
if (detail && typeof detail === 'object') {
const obj = detail as Record<string, unknown>;
if (typeof obj.message === 'string') return obj.message;
return JSON.stringify(detail);
}
return fallback;
}
class ApiClient { class ApiClient {
private getBaseUrl(): string { private getBaseUrl(): string {
const serverUrl = useServerStore.getState().serverUrl; const serverUrl = useServerStore.getState().serverUrl;
@@ -55,7 +70,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -114,7 +129,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -148,7 +163,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.blob(); return response.blob();
@@ -168,7 +183,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -188,7 +203,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -258,7 +273,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.blob(); return response.blob();
@@ -272,7 +287,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.blob(); return response.blob();
@@ -298,7 +313,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -343,7 +358,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.json(); return response.json();
@@ -616,7 +631,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.blob(); return response.blob();
@@ -713,7 +728,7 @@ class ApiClient {
const error = await response.json().catch(() => ({ const error = await response.json().catch(() => ({
detail: response.statusText, detail: response.statusText,
})); }));
throw new Error(error.detail || `HTTP error! status: ${response.status}`); throw new Error(formatErrorDetail(error.detail, `HTTP error! status: ${response.status}`));
} }
return response.blob(); return response.blob();