From 3d2506767d73acbf3c3cabb45ad270255ecf3a30 Mon Sep 17 00:00:00 2001 From: pandego <7780875+pandego@users.noreply.github.com> Date: Fri, 13 Mar 2026 05:08:25 +0100 Subject: [PATCH] docs: address review nits for API generator --- CHANGELOG.md | 1 + scripts/generate-api.sh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b7116d39..141977c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Audio export failing when Tauri save dialog returns object instead of string path +- OpenAPI client generator script now documents the local backend port and avoids an unused loop variable warning ### Added - **Makefile** - Comprehensive development workflow automation with commands for setup, development, building, testing, and code quality checks diff --git a/scripts/generate-api.sh b/scripts/generate-api.sh index b6239981..c2de5293 100755 --- a/scripts/generate-api.sh +++ b/scripts/generate-api.sh @@ -26,12 +26,12 @@ if ! curl -s http://localhost:17493/openapi.json > /dev/null 2>&1; then # Start backend in background echo "Starting backend server..." - uvicorn main:app --port 17493 & + uvicorn main:app --port 17493 & # Keep the generator on the app's documented local backend port. BACKEND_PID=$! # Wait for server to be ready echo "Waiting for server to start..." - for i in {1..30}; do + for _ in {1..30}; do if curl -s http://localhost:17493/openapi.json > /dev/null 2>&1; then break fi