mirror of
https://github.com/jamiepine/voicebox.git
synced 2026-09-17 05:40:42 -07:00
fix(build): runtime hook to work around PyInstaller + Python 3.12 import breakages
Four distinct bundling-specific crashes blocked Kokoro and Qwen CustomVoice
from loading in the frozen binary:
1. torch._dynamo import triggered via class-body decorators
(@torch._dynamo.allow_in_graph on PreTrainedModel,
@torch.compiler.disable in flex_attention) pulls in torch._numpy._ufuncs
which crashes on module load with NameError: name 'name' is not defined.
2. AlbertModel (Kokoro) triggers @auto_docstring -> modeling_auto ->
GenerationMixin -> candidate_generator -> sklearn -> scipy, which hits
the same class of bug in scipy.stats._distn_infrastructure (NameError:
name 'obj' is not defined).
3. AutoModel (Qwen) pulls the same sklearn -> scipy chain directly.
4. librosa (required by most TTS engines) -> scipy.signal -> scipy.stats
hits the _distn_infrastructure crash regardless of the transformers
stubs above.
The root cause of (1) and (4) is that PyInstaller's frozen importer runs
module-level `for X in [<list-comp using dir()>]:` loops with an empty
iterable, leaving the loop variable unbound. Trailing `del obj` / unrelated
references then crash.
Fix: a single runtime hook (pyi_rth_torch_compiler_disable.py) installs:
- sys.modules stubs for torch._dynamo and torch._dynamo.config, plus a
meta-path finder for torch._dynamo.* submodules — voicebox never uses
torch.compile/dynamo for inference, so a permissive no-op stub (callable
as decorator, falsey as predicate, context-manager-safe for
TransformGetItemToIndex) is drop-in safe.
- meta-path finder stubs for transformers.utils.auto_docstring and
transformers.generation.candidate_generator — both import-chain
short-circuits; docstrings and speculative decoding aren't used for TTS.
- meta-path finder for scipy.stats._distn_infrastructure that reads the
real .py source via the wrapped loader's get_source(), replaces the
bundling-broken `del obj` with `globals().pop('obj', None)`, and
compile+exec's the patched source. This keeps the real scipy module
intact so librosa and everything downstream works normally.
Supporting changes:
- backend/pyi_hooks/hook-scipy.stats._distn_infrastructure.py sets
module_collection_mode = "pyz+py" so the .py source is actually in the
bundle for the runtime patcher to read.
- build_binary.py and voicebox-server.spec register the runtime hook and
the new hooks dir.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
9bc5b261fe
commit
2076114972
@@ -59,6 +59,16 @@ def build_server(cuda=False):
|
||||
[
|
||||
"--runtime-hook",
|
||||
str(backend_dir / "pyi_rth_numpy_compat.py"),
|
||||
# Stub torch.compiler.disable before transformers imports
|
||||
# flex_attention, which otherwise triggers torch._dynamo →
|
||||
# torch._numpy._ufuncs and crashes at module load under
|
||||
# PyInstaller. See pyi_rth_torch_compiler_disable.py.
|
||||
"--runtime-hook",
|
||||
str(backend_dir / "pyi_rth_torch_compiler_disable.py"),
|
||||
# Per-module collection overrides (e.g. forcing scipy.stats._distn_infrastructure
|
||||
# to bundle .py source alongside .pyc so the runtime hook can source-patch it).
|
||||
"--additional-hooks-dir",
|
||||
str(backend_dir / "pyi_hooks"),
|
||||
]
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user