From 35b274bbd379b1682d83fd9f102fa075f4df27c8 Mon Sep 17 00:00:00 2001 From: Chris Beck Date: Fri, 5 Dec 2025 19:42:30 -0700 Subject: [PATCH] clippy --- signal-gateway-bin/src/json/mod.rs | 2 +- signal-gateway/src/gateway/log_handler.rs | 10 +++------- signal-gateway/src/log_message.rs | 4 ++-- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/signal-gateway-bin/src/json/mod.rs b/signal-gateway-bin/src/json/mod.rs index d5675a3..65482c3 100644 --- a/signal-gateway-bin/src/json/mod.rs +++ b/signal-gateway-bin/src/json/mod.rs @@ -239,7 +239,7 @@ where D: serde::Deserializer<'de>, { let opt: Option = Option::deserialize(deserializer)?; - Ok(opt.and_then(|s| Level::from_str(&s))) + Ok(opt.and_then(|s| Level::parse(&s))) } /// Deserialize a timestamp from Unix epoch (int or string) or RFC3339 string diff --git a/signal-gateway/src/gateway/log_handler.rs b/signal-gateway/src/gateway/log_handler.rs index 03c8bd5..b1b06bf 100644 --- a/signal-gateway/src/gateway/log_handler.rs +++ b/signal-gateway/src/gateway/log_handler.rs @@ -123,10 +123,8 @@ impl LogHandler { for (origin, buffer) in buffers.iter() { // Apply filter if present - if let Some(f) = filter { - if !origin.matches_filter(f) { - continue; - } + if filter.is_some_and(|f| !origin.matches_filter(f)) { + continue; } use std::fmt::Write; @@ -287,9 +285,7 @@ impl LogHandler { } // Check if message matches route's filter (if any) - let filter_matches = route.filter.as_ref().map_or(true, |f| f.matches(log_msg)); - - if !filter_matches { + if !route.filter.as_ref().is_none_or(|f| f.matches(log_msg)) { continue; } diff --git a/signal-gateway/src/log_message.rs b/signal-gateway/src/log_message.rs index 4c452fc..68555c4 100644 --- a/signal-gateway/src/log_message.rs +++ b/signal-gateway/src/log_message.rs @@ -57,7 +57,7 @@ impl Level { /// - info, information /// - debug /// - trace - pub fn from_str(s: &str) -> Option { + pub fn parse(s: &str) -> Option { match s.to_ascii_uppercase().as_str() { "EMERGENCY" | "EMERG" => Some(Self::EMERGENCY), "ALERT" => Some(Self::ALERT), @@ -79,7 +79,7 @@ impl<'de> Deserialize<'de> for Level { D: de::Deserializer<'de>, { let s = String::deserialize(deserializer)?; - Level::from_str(&s).ok_or_else(|| { + Level::parse(&s).ok_or_else(|| { de::Error::custom(format!( "unknown log level '{}', expected one of: emergency, alert, critical, error, warning, notice, info, debug, trace", s