Labyricorn/liquidjs
1
0
Fork 0
mirror of https://github.com/harttle/liquidjs.git synced 2026-09-16 04:40:39 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove_last was eating an extra character

Browse Source
This commit is contained in:
Francisco Soto
2023-08-17 21:43:21 +08:00
committed by Jun Yang
parent 3bd8d2e557
commit fc2731376f
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/filters/string.ts
+1 -1
View File
@@ -44,7 +44,7 @@ export function remove_last (v: string, l: string) {
const pattern = String(l) const pattern = String(l)
const index = str.lastIndexOf(pattern) const index = str.lastIndexOf(pattern)
if (index === -1) return str if (index === -1) return str
return str.substring(0, index) + str.substring(index + pattern.length + 1) return str.substring(0, index) + str.substring(index + pattern.length)
} }
export function rstrip (str: string, chars?: string) { export function rstrip (str: string, chars?: string) {
test/integration/filters/string.spec.ts
+4
View File
@@ -203,6 +203,10 @@ describe('filters/string', function () {
return test('{{ "I strained to see the train through the rain" | remove_last: "rain" }}', return test('{{ "I strained to see the train through the rain" | remove_last: "rain" }}',
'I strained to see the train through the ') 'I strained to see the train through the ')
}) })
it('should remove the last occurrence of substring in the middle of a string', function () {
return test('{{ "I strained to see the train through the rain and fog" | remove_last: "rain" }}',
'I strained to see the train through the and fog')
})
it('should handle substring not found', function () { it('should handle substring not found', function () {
return test('{{ "I strained to see the train through the rain" | remove_last: "no such thing" }}', return test('{{ "I strained to see the train through the rain" | remove_last: "no such thing" }}',
'I strained to see the train through the rain') 'I strained to see the train through the rain')