Labyricorn/liquidjs
1
0
Fork 0
mirror of https://github.com/harttle/liquidjs.git synced 2026-09-16 12:50:38 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: incorrect scope when using assign with for, fixes #115

Browse Source 
* remove AssignScope, CaptureScope, IncrementScope, DecrementScope concepts
* introduce Scope.environments for decrement/increment
* assign to scopes[0] for assign/capture
This commit is contained in:
harttle
2019-03-22 20:38:54 +08:00
parent b7b92c63cf
commit defbb58e66
10 changed files with 37 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/unit/scope/scope.ts
+5 -40
View File
@@ -126,41 +126,6 @@ describe('scope', function () {
expect(await scope.get('one.size')).to.equal(undefined)
})
})
describe('#set', function () {
it('should set nested value', async function () {
await scope.set('posts', {
'first': {
'name': 'A Nice Day'
}
})
await scope.set('category', {
'diary': ['first']
})
expect(await scope.get('posts[category.diary[0]].name'), 'A Nice Day')
})
it('should create parent if needed', async function () {
await scope.set('a.b.c.d', 'COO')
expect(await scope.get('a.b.c.d')).to.equal('COO')
})
it('should keep other properties of parent', async function () {
scope.push({ obj: { foo: 'FOO' } })
await scope.set('obj.bar', 'BAR')
expect(await scope.get('obj.foo')).to.equal('FOO')
})
it('should abort if property cannot be set', async function () {
scope.push({ obj: { foo: 'FOO' } })
await scope.set('obj.foo.bar', 'BAR')
expect(await scope.get('obj.foo')).to.equal('FOO')
})
it("should set parents' corresponding value", async function () {
scope.push({})
await scope.set('foo', 'bar')
scope.pop()
expect(await scope.get('foo')).to.equal('bar')
})
})
describe('strictVariables', async function () {
let scope: Scope
beforeEach(function () {
@@ -172,15 +137,15 @@ describe('scope', function () {
return expect(scope.get('notdefined')).to.be.rejectedWith(/undefined variable: notdefined/)
})
it('should throw when deep variable not exist', async function () {
await scope.set('foo', 'FOO')
scope.contexts.push({ 'foo': 'FOO' })
return expect(scope.get('foo.bar.not.defined')).to.be.rejectedWith(/undefined variable: bar/)
})
it('should throw when itself not defined', async function () {
await scope.set('foo', 'bar')
scope.contexts.push({ 'foo': 'FOO' })
return expect(scope.get('foo.BAR')).to.be.rejectedWith(/undefined variable: BAR/)
})
it('should find variable in parent scope', async function () {
await scope.set('foo', 'foo')
scope.contexts.push({ 'foo': 'foo' })
scope.push({
'bar': 'bar'
})
@@ -196,7 +161,7 @@ describe('scope', function () {
describe('.push()', function () {
it('should push scope', async function () {
await scope.set('bar', 'bar')
scope.contexts.push({ 'bar': 'bar' })
scope.push({
foo: 'foo'
})
@@ -204,7 +169,7 @@ describe('scope', function () {
expect(await scope.get('bar')).to.equal('bar')
})
it('should hide deep properties by push', async function () {
await scope.set('bar', { bar: 'bar' })
scope.contexts.push({ 'bar': { bar: 'bar' } })
scope.push({ bar: { foo: 'foo' } })
expect(await scope.get('bar.foo')).to.equal('foo')
expect(await scope.get('bar.bar')).to.equal(undefined)