mirror of
https://github.com/harttle/liquidjs.git
synced 2026-09-16 12:50:38 -07:00
fix: use drop valueOf when evaluated as condition (#705)
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
import { isTruthy, isFalsy } from './boolean'
|
||||
import { Context } from '../context'
|
||||
import { Drop } from '..'
|
||||
|
||||
describe('boolean Shopify', function () {
|
||||
describe('.isTruthy()', function () {
|
||||
@@ -8,7 +9,13 @@ describe('boolean Shopify', function () {
|
||||
jsTruthy: false
|
||||
}
|
||||
} as unknown as Context
|
||||
//
|
||||
|
||||
class BooleanDrop extends Drop {
|
||||
public valueOf () {
|
||||
return false
|
||||
}
|
||||
}
|
||||
|
||||
// Spec: https://shopify.github.io/liquid/basics/truthy-and-falsy/
|
||||
it('true is truthy', function () {
|
||||
expect(isTruthy(true, ctx)).toBeTruthy()
|
||||
@@ -40,6 +47,9 @@ describe('boolean Shopify', function () {
|
||||
it('[] is truthy', function () {
|
||||
expect(isTruthy([], ctx)).toBeTruthy()
|
||||
})
|
||||
it('drop valueOf determines truthy', function () {
|
||||
expect(isTruthy(new BooleanDrop(), ctx)).toBeFalsy()
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
|
||||
@@ -1,10 +1,13 @@
|
||||
import { Context } from '../context/context'
|
||||
import { toValue } from '../util'
|
||||
|
||||
export function isTruthy (val: any, ctx: Context): boolean {
|
||||
return !isFalsy(val, ctx)
|
||||
}
|
||||
|
||||
export function isFalsy (val: any, ctx: Context): boolean {
|
||||
val = toValue(val)
|
||||
|
||||
if (ctx.opts.jsTruthy) {
|
||||
return !val
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user