Labyricorn/liquidjs
1
0
Fork 0
mirror of https://github.com/harttle/liquidjs.git synced 2026-10-03 00:55:13 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor: drop redundant typeof in blocked key check

Browse Source 
Set.has already returns false for non-string PropertyKey values; widen
BLOCKED_SCOPE_KEYS type so TypeScript accepts the direct has(key) call.

Co-authored-by: Cursor <[email protected]>
This commit is contained in:
Yang Jun
2026-07-23 22:38:50 +08:00
co-authored by Cursor
parent 33e455282d
commit 5d0d884938
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/context/context.ts
+2 -2
View File
@@ -155,10 +155,10 @@ export class Context {
} }
} }
const BLOCKED_SCOPE_KEYS = new Set(['__proto__', 'constructor', 'prototype']) const BLOCKED_SCOPE_KEYS: ReadonlySet<PropertyKey> = new Set(['__proto__', 'constructor', 'prototype'])
export function readJSProperty (obj: Scope, key: PropertyKey, ownPropertyOnly: boolean) { export function readJSProperty (obj: Scope, key: PropertyKey, ownPropertyOnly: boolean) {
if (typeof key === 'string' && BLOCKED_SCOPE_KEYS.has(key)) { if (BLOCKED_SCOPE_KEYS.has(key)) {
if (ownPropertyOnly || !hasOwnProperty.call(obj, key)) return undefined if (ownPropertyOnly || !hasOwnProperty.call(obj, key)) return undefined
} }
if (ownPropertyOnly && !hasOwnProperty.call(obj, key) && !(obj instanceof Drop)) return undefined if (ownPropertyOnly && !hasOwnProperty.call(obj, key) && !(obj instanceof Drop)) return undefined