Labyricorn/liquidjs
1
0
Fork 0
mirror of https://github.com/harttle/liquidjs.git synced 2026-09-29 07:05:13 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: Windows compat for contains/containsSync and toLiquidAsync arg order

Browse Source 
Made-with: Cursor
This commit is contained in:
Yang Jun
2026-04-06 14:30:41 +08:00
parent b181b08543
commit 3538864119
8 changed files with 25 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.cursor/rules/architecture.mdc
+1 -1
View File
@@ -12,6 +12,6 @@ All core logic is written once as a `Generator` function (`function *`). Use `yi
Never duplicate logic into separate async and sync methods. A single generator serves both paths.
When wrapping an async+sync function pair (e.g. `contains`/`containsSync`, `exists`/`existsSync`, `readFile`/`readFileSync`), use `toLiquidAsync(syncFn, asyncFn?)` which returns a `LiquidAsync<F>` — one function that picks the sync or async implementation based on a leading `sync: boolean` arg. Then `yield` the result inside a generator to let the driver handle it in both modes.
When wrapping an async+sync function pair (e.g. `contains`/`containsSync`, `exists`/`existsSync`, `readFile`/`readFileSync`), use `toLiquidAsync(asyncFn, syncFn?)` which returns a `LiquidAsync<F>` — one function that picks the sync or async implementation based on a leading `sync: boolean` arg. Then `yield` the result inside a generator to let the driver handle it in both modes.
See `src/util/async.ts`.