mirror of
https://github.com/Shopify/liquid.git
synced 2026-09-12 23:40:45 -07:00
Ian Ker-SeymerandGitHub
59d8d0d22d
* feat: add cumulative resource score tracking across partial renders Add cumulative_render_score and cumulative_assign_score counters to ResourceLimits that accumulate across reset() calls, with optional cumulative_render_score_limit and cumulative_assign_score_limit to cap total work across all partial renders. Also add a reached? check in BlockBody's render loop so that once a cumulative limit triggers, the parent template stops processing further nodes. Bump version to 5.12.0. * refactor: move cumulative limit enforcement into reset() Instead of checking reached? in BlockBody's render loop, enforce cumulative limits in reset() itself. Since reset() is called before the begin/rescue MemoryError block in Template#render, the raise propagates to the parent naturally — no changes to BlockBody needed.
92 lines
2.6 KiB
Ruby
92 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'test_helper'
|
|
|
|
class ResourceLimitsUnitTest < Minitest::Test
|
|
def test_cumulative_scores_initialize_to_zero
|
|
limits = Liquid::ResourceLimits.new({})
|
|
assert_equal(0, limits.cumulative_render_score)
|
|
assert_equal(0, limits.cumulative_assign_score)
|
|
end
|
|
|
|
def test_cumulative_limits_default_to_nil
|
|
limits = Liquid::ResourceLimits.new({})
|
|
assert_nil(limits.cumulative_render_score_limit)
|
|
assert_nil(limits.cumulative_assign_score_limit)
|
|
end
|
|
|
|
def test_cumulative_limits_configurable_via_hash
|
|
limits = Liquid::ResourceLimits.new(
|
|
cumulative_render_score_limit: 500,
|
|
cumulative_assign_score_limit: 300,
|
|
)
|
|
assert_equal(500, limits.cumulative_render_score_limit)
|
|
assert_equal(300, limits.cumulative_assign_score_limit)
|
|
end
|
|
|
|
def test_cumulative_limits_configurable_via_accessor
|
|
limits = Liquid::ResourceLimits.new({})
|
|
limits.cumulative_render_score_limit = 500
|
|
assert_equal(500, limits.cumulative_render_score_limit)
|
|
end
|
|
|
|
def test_cumulative_scores_survive_reset
|
|
limits = Liquid::ResourceLimits.new({})
|
|
limits.increment_render_score(10)
|
|
limits.increment_assign_score(5)
|
|
|
|
limits.reset
|
|
|
|
assert_equal(0, limits.render_score)
|
|
assert_equal(0, limits.assign_score)
|
|
assert_equal(10, limits.cumulative_render_score)
|
|
assert_equal(5, limits.cumulative_assign_score)
|
|
end
|
|
|
|
def test_cumulative_scores_accumulate_across_resets
|
|
limits = Liquid::ResourceLimits.new({})
|
|
limits.increment_render_score(10)
|
|
limits.reset
|
|
limits.increment_render_score(20)
|
|
limits.reset
|
|
limits.increment_render_score(30)
|
|
|
|
assert_equal(30, limits.render_score)
|
|
assert_equal(60, limits.cumulative_render_score)
|
|
end
|
|
|
|
def test_cumulative_render_score_limit_raises
|
|
limits = Liquid::ResourceLimits.new(cumulative_render_score_limit: 25)
|
|
limits.increment_render_score(10)
|
|
limits.reset
|
|
limits.increment_render_score(10)
|
|
limits.reset
|
|
|
|
assert_raises(Liquid::MemoryError) do
|
|
limits.increment_render_score(10)
|
|
end
|
|
assert(limits.reached?)
|
|
end
|
|
|
|
def test_cumulative_assign_score_limit_raises
|
|
limits = Liquid::ResourceLimits.new(cumulative_assign_score_limit: 15)
|
|
limits.increment_assign_score(8)
|
|
limits.reset
|
|
|
|
assert_raises(Liquid::MemoryError) do
|
|
limits.increment_assign_score(8)
|
|
end
|
|
assert(limits.reached?)
|
|
end
|
|
|
|
def test_per_template_limits_still_work_with_cumulative
|
|
limits = Liquid::ResourceLimits.new(
|
|
render_score_limit: 50,
|
|
cumulative_render_score_limit: 1000,
|
|
)
|
|
assert_raises(Liquid::MemoryError) do
|
|
limits.increment_render_score(51)
|
|
end
|
|
end
|
|
end
|