Michael Go
6dafc19b6d
fix parsing comment tag delimiter with extra strings
2023-11-10 15:42:54 -04:00
Michael Go
41f65173b0
fix parsing comment block body inside a liquid tag
2023-11-09 16:27:23 -04:00
Michael Go
a681e73aec
refactor comment tag unit test to use test helper
2023-11-08 16:45:11 -04:00
Michael Go
2abf52d546
add a quirky comment tag unit test
2023-11-08 11:23:00 -04:00
Michael Go and Alex Coco
dbf0aa8cd5
don't parse nodes inside a comment tag
...
Co-authored-by: Alex Coco <[email protected] >
2023-11-07 18:38:13 -04:00
Ieva Grazuleviciute
407a8e5b0f
Fix for custom tag rendering
2023-10-20 11:42:54 +03:00
Guillaume Malette and GitHub
7b60b7fef5
Merge pull request #1746 from Shopify/gm/base64-encoding
...
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 11:13:18 -04:00
Guillaume Malette
cc47fa8f03
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 09:39:59 -04:00
Adam Klingbaum
75e7725f57
Streamline new tests for sum filter
2023-08-08 16:15:48 +00:00
James Prior and Adam Klingbaum
de6d15a73e
Test sum floats from properties.
2023-08-08 16:10:04 +00:00
James Prior and Adam Klingbaum
2c5d2be193
Don't render sum filter results in scientific notation.
2023-08-08 16:10:03 +00:00
Marco Rudilosso
21d6197533
Call to_liquid_value when short circuiting conditions
2023-07-19 15:22:12 +00:00
Marco Concetto Rudilosso
7f2cf1fe67
Recursively parse for liquid tag
2023-07-07 11:20:34 +01:00
Marco Concetto Rudilosso
10e0fb795e
Allow liquid tag inside liquid tag
2023-07-06 10:45:12 +01:00
Michael Go
dd7bbf26bc
include error mode to partial cache key
2023-06-23 18:48:07 -03:00
Adam Klingbaum
98ce25cb40
Ensure sum filter calls to_liquid
2023-06-22 16:25:11 +00:00
Adam Klingbaum
af66bc8a5f
Add sum filter to standard filters
2023-06-19 19:11:05 +00:00
Guillaume Malette
649cca1349
[trim] Fix trimming at end of raw block when specified in the opening tag
2023-05-19 11:41:45 -04:00
Michael Go
1d97389fb0
render template name with Liquid Syntax errors
2023-03-02 16:50:55 -04:00
Michael Go
24dceef552
set context's template_name with template's name
2023-02-28 10:55:38 -04:00
Michael Go
428c66ffac
add name attribute to Template for more flexibility to set context's template name
2023-02-27 17:11:52 -04:00
Michael Go
0fe4a5d144
render error message with actual template path
2023-02-27 11:01:21 -04:00
Dylan Thacker-Smith and GitHub
e650dc4195
Revert "Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )" ( #1677 )
...
This reverts commit c743936a78 .
2023-02-22 12:48:18 -05:00
Guilherme Carreiro and GitHub
9ab688eada
Update rubocop-shopify (2.7.0 -> 2.12.0) ( #1687 )
2023-02-15 08:40:59 +01:00
Michael Go and GitHub
4599e5459f
Merge pull request #1684 from Shopify/fix-variable-lookup-parse-timeout
...
fix variable lookup parse timing out with missing closing bracket
2023-02-02 10:39:46 -04:00
Dylan Thacker-Smith and GitHub
59c445f0e1
Avoid a couple of duplicate assertions ( #1675 )
2023-02-02 09:31:01 -05:00
Michael Go
bd9c3802c8
add variable parser timeout unit tests
2023-02-01 21:15:35 -04:00
Michael Go
2b40850e4a
fix variable lookup parse timing out with missing closing bracket
2023-02-01 19:52:30 -04:00
Marco Concetto Rudilosso
ddc32b7bd8
actually test whitespace stripping
2023-02-01 15:52:34 +00:00
Marco Concetto Rudilosso
74e505f6fa
Allow raw tag to be used with whitespace control
2023-02-01 13:49:51 +00:00
Michael Go
dd257b3d66
add an unit test for double nest variable lookup
2023-01-30 20:36:14 -04:00
Michael Go
1aaf6ed019
recursively parse brackets on variable lookup
2023-01-30 20:19:35 -04:00
Michael Go
0f11c97623
raise invalid integer argument error from tablerow
2023-01-16 18:53:53 -04:00
Dylan Thacker-Smith
619ed3fcd7
Add some additional to_liquid_value assertions
2023-01-13 15:46:12 -05:00
Dylan Thacker-Smith
cdb5cb06b2
Remove == method from drops from testing to_liquid_value
...
Since they could cause tests to pass without to_liquid_value being called
on the left side of the equality comparison.
2023-01-13 15:37:27 -05:00
Dylan Thacker-Smith and GitHub
c743936a78
Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )
2023-01-11 14:05:50 -05:00
Dylan Thacker-Smith and GitHub
bf711a0521
Provide another assertion for to_liquid_value unless tag test ( #1672 )
...
Since the original one would pass even if to_liquid_value isn't called on
the BooleanDrop object.
2023-01-11 14:05:27 -05:00
Dylan Thacker-Smith and GitHub
c2c6cb2b15
Allow commas to separate for tag attributes ( #1658 )
...
For consistency with tags like the `render` tag, where we actually
prefer to use commas to separate attributes
2022-11-29 09:00:55 -05:00
Dylan Thacker-Smith and GitHub
1cd5ec54f0
Merge pull request #1641 from Shopify/assert-template-result-static-env
...
Use static environment assert_template_result input values
2022-11-02 10:05:52 -04:00
Peter Zhu
abed47547c
Fix tags in comment
2022-11-01 13:04:41 -04:00
Dylan Thacker-Smith
db8e85ab31
Prevent an internal error in include tag from non-string template_name
...
which would otherwise happen on `template_name.split('/')`
2022-10-28 13:59:00 -04:00
Dylan Thacker-Smith
f484b868d0
assert_template_result: Avoid using the BlankFileSystem
...
Since it doesn't reflect the real liquid usage that we are trying
to test against.
2022-10-28 13:55:33 -04:00
Dylan Thacker-Smith and GitHub
96b5325f87
Remove Usage.increment calls that have been shown to in fact be used ( #1645 )
...
I think these were added for undocumented features to see if they were
actually used and they were being used.
2022-10-26 09:21:43 -04:00
Dylan Thacker-Smith and GitHub
6ce4ec1011
tablerow: Avoid accidental special case for constant nil cols ( #1644 )
...
It should behave the same as an expression that evaluates to nil
2022-10-25 10:21:03 -04:00
Dylan Thacker-Smith
a39422feac
Use static environment assert_template_result input values
...
To match how we use liquid in practice
2022-10-21 11:45:29 -04:00
Dylan Thacker-Smith
2c2f5826d5
Change increment/decrement tests to avoid relying on input
...
So these can be tested using language tests, without needing support
for counter value input, which isn't needed if input is provided
through the static environment.
2022-10-21 11:43:58 -04:00
Dylan Thacker-Smith
c0c191cabd
Add assertions for truncate filter with large integers
2022-10-11 12:44:33 -04:00
Dylan Thacker-Smith
6765d93938
Avoid internal errors for large arguments to slice filter
...
Use saturating conversion, which has expected semantics for large integers.
2022-10-11 12:44:32 -04:00
Dylan Thacker-Smith
4f17abfb4a
Handle truncatewords word length out of range as if no truncation is needed
2022-10-11 12:44:32 -04:00
Michael Go
fbab19ac8c
fix tablerow drop's last attribute with missing cols param
2022-10-05 11:15:23 -03:00