Tobi Lutke
9fd7cec564
split filter parsing: scan no-arg filters directly, only invoke Lexer when args present
2026-03-11 08:26:04 -04:00
Tobi Lutke
2543fdc1a1
autoresearch: add autoresearch.md/sh, increase benchmark warmup to 20 iterations
2026-03-11 08:23:51 -04:00
Tobi Lutke
17daac92da
extend fast-path to handle quoted string literal variables (262 more fast-pathed)
2026-03-11 08:20:39 -04:00
Tobi Lutke
283961d6c9
skip filter arg splat for no-arg filters, trim render loop comments
2026-03-11 08:06:23 -04:00
Tobi Lutke
db434923d0
hoist write score check out of render loop: skip increment_write_score when no limits active
2026-03-11 08:04:40 -04:00
Tobi Lutke
b86143eb0e
use frozen EMPTY_ARRAY for disabled_tags in Variable
2026-03-11 07:47:51 -04:00
Tobi Lutke
58d2514521
return [tag_name, markup, newlines] from parse_tag_token: avoid 2 whitespace string allocs
2026-03-11 07:45:15 -04:00
Tobi Lutke
82407092cc
use getbyte dispatch instead of start_with? in parse_for_document
2026-03-11 07:44:12 -04:00
Tobi Lutke
544d8f1c17
avoid empty array allocation in evaluate_filter_expressions for no-arg filters
2026-03-11 07:43:09 -04:00
Tobi Lutke
cfa0dfe3ca
replace For tag Syntax regex with manual byte-level parser
2026-03-11 07:39:36 -04:00
Tobi Lutke
2d3b856b36
expose expression_cache/string_scanner via attr_reader, skip regex in filter args without colon
2026-03-11 07:38:16 -04:00
Tobi Lutke
8a92a4e451
unified fast-path Variable parsing: handle both plain lookups and filter chains without full Lexer pass for name
2026-03-11 07:36:29 -04:00
Tobi Lutke
f8b015646a
fast-path render for filter-less variables: skip render method overhead
2026-03-11 07:33:18 -04:00
Tobi Lutke
6bcc2936a2
skip TagAttributes scan in for tag when no colon present
2026-03-11 07:32:39 -04:00
Tobi Lutke
fe7a2f5aa8
fast-path simple if conditions: skip ExpressionsAndOperators scan for single conditions
2026-03-11 07:31:26 -04:00
Tobi Lutke
3939d74531
replace SIMPLE_VARIABLE regex with byte-level scanner to avoid MatchData
2026-03-11 07:30:34 -04:00
Tobi Lutke
25f9224c85
fast-path simple variable parsing: skip Lexer/Parser for plain dot-separated lookups
2026-03-11 07:29:47 -04:00
Tobi Lutke
5da223275a
use frozen EMPTY_ARRAY for Variable filters when no filters present
2026-03-11 07:28:04 -04:00
Tobi Lutke
1a79cf6266
fast-path variable_lookups: skip mutable string alloc when no dot/bracket follows
2026-03-11 07:26:40 -04:00
Tobi Lutke
c1113ad2f8
fast-path String in render_obj_to_output, avoid Utils.to_s dispatch for common case
2026-03-11 07:24:30 -04:00
Tobi Lutke
fa412245f7
short-circuit parse_number with first-byte check before regex
2026-03-11 07:23:41 -04:00
Tobi Lutke
d79b9fa254
avoid unnecessary strip allocation in Expression.parse, use byteslice for string literals
2026-03-11 07:23:08 -04:00
Tobi Lutke
d291e63006
use equal? for frozen array comparison in Lexer, skip whitespace with \s+
2026-03-11 07:21:55 -04:00
Tobi Lutke
2b78e4bf72
use getbyte instead of string indexing in whitespace_handler and create_variable
2026-03-11 07:19:26 -04:00
Tobi Lutke
7aded8e61f
add auto/bench.sh: unit tests + liquid-spec + perf benchmark
2026-03-11 07:17:01 -04:00
Tobi Lutke
97e6893c1a
replace VariableParser regex scan with manual byte parser in VariableLookup
2026-03-11 07:14:14 -04:00
Tobi Lutke
3329b09dd4
replace FullToken regex with manual byte parsing in parse_for_document
2026-03-11 07:12:38 -04:00
Tobi Lutke
4ea835ae04
add quick benchmark script for autoresearch
2026-03-11 07:10:28 -04:00
Gray Gilmore and GitHub
5fa36267aa
Merge pull request #2054 from Shopify/gg-fix-rubocop-offenses
...
Fix rubocop offenses in test file
2026-03-06 13:28:54 -08:00
Gray Gilmore
a72b604680
Fix rubocop offenses in test file
2026-03-06 13:27:05 -08:00
Gray Gilmore and GitHub
3e76244cd2
Merge pull request #2050 from bakura10/squish-filter
...
Add squish filter
2026-03-06 13:22:18 -08:00
Michaël Gallego
d589c51697
Add squish filter
2026-02-19 10:03:52 +09:00
CP Clermont and GitHub
d897899f66
Merge pull request #2036 from Shopify/cp-fix-rubocop
...
Update the specs to new signature and fix CI
2026-01-14 09:14:01 -05:00
Charles-P. Clermont and Claude Opus 4.5
aa817c4cfd
Update liquid-spec adapters for new ctx-based API
...
liquid-spec main changed the adapter API:
- compile block now receives (ctx, source, options) and should store
the template in ctx[:template]
- render block now receives (ctx, assigns, options) and retrieves
the template from ctx[:template]
Co-Authored-By: Claude Opus 4.5 <[email protected] >
2026-01-13 13:06:55 -05:00
Charles-P. Clermont
7d90b524ea
Remove on pull_request trigger. It's redundant.
2026-01-12 13:27:53 -05:00
Charles-P. Clermont
bbcf8d6ad8
Better matrix CI check names
2026-01-12 13:27:52 -05:00
Charles-P. Clermont
51ff08db7b
Fix CI
2026-01-12 13:06:13 -05:00
Tobi Lutke and Claude Opus 4.5
eaa9f215bf
Add lax and YJIT liquid-spec adapters
...
- ruby_liquid_lax.rb: Tests lax parsing mode with :lax_parsing feature
- ruby_liquid_yjit.rb: Tests YJIT + strict mode + ActiveSupport
Matrix results: 4483 matched, 18 different (lax edge cases), 61 skipped
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <[email protected] >
2026-01-05 15:11:29 -10:00
Tobi Lutke and Claude Opus 4.5
ccd05e869c
Make blank/empty comparisons invariant to ActiveSupport
...
- Implement liquid_blank? and liquid_empty? methods in Condition
to emulate ActiveSupport's behavior when it's not loaded
- This ensures templates like `{% if x == blank %}` work identically
whether ActiveSupport is loaded or not
- Update liquid-spec adapters for new API (ctx parameter)
- Add rake spec task for running liquid-spec matrix
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <[email protected] >
2026-01-05 14:54:43 -10:00
Tobias Lütke and GitHub
a4a29f3e08
Merge pull request #2034 from Shopify/fix-liquid-spec-without-activesupport
...
Require liquid-spec to be run on commit automatically and related fixes
2026-01-01 22:32:38 -05:00
Tobi Lutke
0058e4322b
Add fail-fast: false to prevent job cancellation
2026-01-01 22:30:14 -05:00
Tobi Lutke
50e1789537
Use liquid-spec feature branch until PR is merged
2026-01-01 22:29:32 -05:00
Tobi Lutke
79a2e042ff
Use liquid-spec main branch
2026-01-01 22:24:00 -05:00
Tobi Lutke
ddee08fb95
Add activesupport feature to with_active_support adapter
...
Both adapters now pass with 0 failures:
- ruby_liquid.rb: 4194 passed (skips activesupport and shopify_error_handling specs)
- ruby_liquid_with_active_support.rb: 4203 passed (skips shopify_error_handling specs)
2026-01-01 22:21:47 -05:00
Tobi Lutke
2988f1a500
Update liquid-spec to branch with per-spec required_features support
2026-01-01 22:15:38 -05:00
Tobi Lutke
ef13b2dfd5
Fix empty? semantics and string first/last for empty strings
...
- nil is NOT empty (but IS blank) - matches Shopify production
- String first/last returns '' for empty strings, not nil - matches ActiveSupport
- Add test for nil not being empty
2026-01-01 22:06:22 -05:00
Tobi Lutke
b0fb0ad83f
Run liquid-spec for all adapters in spec/*.rb
2026-01-01 22:02:42 -05:00
Tobi Lutke
ae26cb29ac
Disable auto-require for activesupport gem
2026-01-01 22:00:49 -05:00
Tobi Lutke
608a877053
Add spec adapter with ActiveSupport for comparison testing
2026-01-01 22:00:38 -05:00
Tobi Lutke
d321adae77
Fix spec adapter for liquid-spec API (template, assigns, options)
2026-01-01 21:59:16 -05:00