Dylan Thacker-Smith
23a8438fa6
Use liquid-c master branch again, it now has inline comment support
2022-04-28 09:39:16 -04:00
Charles-P. Clermont and Dylan Thacker-Smith
1f0a0ad55c
Add # inline comment tag.
...
This commit adds a new tag named `#` that behaves like a comment.
Therefore it behaves as you'd expect any tag would work. The difference
with the comment tag is that the comment is in the tag markup and that
there is no block delimiter.
What it looks like in practice:
```liquid
{%- # this is an inline comment -%}
{% # this too is an inline comment %}
{% liquid
# required args:
assign product = product
# optional args:
assign should_show_border = should_show_border | default: true
assign should_show_cursor = should_show_cursor | default: true
%}
{% liquid
# This is a very long comment that spans multiple lines.
# It looks very similar to what it would look like if you wrote
# ruby code instead of liquid. But it doesn't have all the clunk
# of having an open tag and a close tag with so many characters.
%}
```
Co-authored-by: Dylan Thacker-Smith <[email protected]
2022-04-28 09:38:44 -04:00
Dylan Thacker-Smith
9dac68cce1
Use the rubocop-shopify gem
2021-02-21 12:22:03 -05:00
Dylan Thacker-Smith
f3e2be9f85
Update rubocop
2020-12-11 14:14:15 -05:00
Dylan Thacker-Smith
67eca3f58d
Upgrade rubocop and style guide for ruby 2.7 compatibility
2020-01-09 13:15:34 -05:00
0d26f05bb8
Enabled frozen string literals ( #1154 )
...
* Enabled frozen string literals
* Update rubocop config
* Prefer string interpolation in simple cases
Co-Authored-By: Dylan Thacker-Smith <[email protected]
2019-09-18 13:19:45 +10:00
Justin Li
806b2622da
Switch back to Liquid-C master, since https://github.com/Shopify/liquid-c/pull/50 is merged
2019-09-04 15:12:51 -04:00
Mike Angell and GitHub
cf4e77ab0c
Merge branch 'master' into bump-ruby-2-4
2019-08-29 00:24:45 +10:00
Tobias Lütke and GitHub
0ce8aef229
Merge pull request #1103 from ashmaroli/ci-profile-memory
...
Add a CI job to profile memory usage of commit
2019-08-27 15:11:55 -04:00
Tobias Lütke and GitHub
6eab595fae
Merge pull request #1086 from Shopify/liquid-tag
...
Add {% liquid %} and {% echo %} tags
2019-08-27 15:10:20 -04:00
Mike Angell
b16b109a80
Bump Minimum version to 2.4 and bump Rubocop
2019-08-28 00:31:44 +10:00
Ashwin Maroli
ab698191b9
Add a CI job to profile memory usage of commit
2019-05-17 22:47:05 +05:30
Ashwin Maroli
1c577c5b62
Don't attempt to install stackprof gem on JRuby
2019-04-24 11:31:20 +05:30
Florian Weingarten
c67b77709d
rake memory_profile:run
2019-04-17 19:09:26 +01:00
Justin Li
8d1cd41453
Add {% liquid %}, {% echo %}, and {% local %} tags
2019-04-01 20:08:38 -04:00
Richard Monette
06c4789dc5
update Rubocop for trailing comma styles
2019-03-19 11:05:05 -04:00
Dylan Thacker-Smith
04d552fabb
Gemfile: Use https rather than git protocol to fetch liquid-c
2018-02-01 07:08:19 -05:00
Dylan Thacker-Smith and GitHub
5106466a2d
Add a regression test for a liquid-c trim mode bug ( #972 )
2018-01-25 10:55:01 -05:00
Justin Li
a7c5e247c8
Bump rubocop
2017-11-22 11:59:06 -05:00
Dylan Thacker-Smith and GitHub
48a6d86ac2
Use stackprof to test to lack of object allocations ( #896 )
2017-05-12 09:20:51 -04:00
Jerry Liu
85463e1753
add benchmark-ips to benchmark group in Gemfile
2017-01-20 16:04:42 -05:00
Kevin Wojniak and GitHub
9bfd04da2d
Update liquid-c
2016-09-10 09:23:15 -07:00
Florian Weingarten
5876dff326
Bump LiquidC for whitespace changes
2016-08-11 13:21:39 -04:00
Dylan Thacker-Smith
4f81c0a658
Lock rubocop version to avoid CI failures from new releases.
2015-09-25 19:42:35 -04:00
Dylan Thacker-Smith
c535af021a
Rename options instance variable in Variable and Tag.
2015-07-08 19:59:44 -04:00
Justin Li
9cf0d264e1
Require RuboCop v0.32.0 or later
2015-07-06 15:58:36 -04:00
Florian Weingarten
01420e8014
fix gem platforms
2015-06-08 18:38:40 +00:00
Florian Weingarten and Florian Weingarten
e2323332cd
Run tests with latest liquid/c gem
2015-06-08 18:38:35 +00:00
Florian Weingarten
3372ca8136
Rubocop
2015-05-14 14:37:18 +00:00
Florian Weingarten
a74d40f1e5
benchmark/ips
2014-08-11 19:22:06 +00:00
Jason Hiltz-Laforge
fd8c30070a
Adding tests, spy dependency
2014-07-16 15:05:45 +00:00
Jean Boussier
1372274fca
Do not intall stackprof under jruby nor rubinius
2014-06-28 16:09:14 -04:00
Dylan Thacker-Smith
f373b1003d
Use stackprof for profiling.
2014-03-14 10:03:50 -04:00
Dylan Thacker-Smith