Ian Ker-Seymer
1b484da9e4
Merge branch 'main' into fix/custom_tag_rendering
...
* main:
implement whitespace control to comment tag
fix parsing comment tag delimiter
fix parsing nested comment tag with extra strings
fix parsing comment tag delimiter with extra strings
fix parsing comment block body inside a liquid tag
allow incomplete tags inside a comment tag
refactor comment tag unit test to use test helper
add a quirky comment tag unit test
clean up comment tag body parsing
don't parse nodes inside a comment tag
2023-12-10 10:33:59 -05:00
Michael Go
24d461a9e3
implement whitespace control to comment tag
2023-12-01 16:04:03 -04:00
Michael Go
bf0f79f36c
fix parsing comment tag delimiter
2023-11-30 13:24:54 -04:00
Michael Go and GitHub
cf2787791e
Merge pull request #1755 from Shopify/non-parsing-comment
...
Don't parse nodes inside a comment tag
2023-11-29 14:10:20 -04:00
Michael Go
6a5ebb0e85
fix parsing nested comment tag with extra strings
2023-11-11 12:19:44 -04:00
Michael Go
6dafc19b6d
fix parsing comment tag delimiter with extra strings
2023-11-10 15:42:54 -04:00
Michael Go
41f65173b0
fix parsing comment block body inside a liquid tag
2023-11-09 16:27:23 -04:00
Michael Go
e180535784
allow incomplete tags inside a comment tag
2023-11-08 16:50:41 -04:00
eada2b65a2
clean up comment tag body parsing
...
Co-authored-by: Peter Zhu <[email protected]
2023-11-08 11:13:13 -04:00
Michael Go and Alex Coco
dbf0aa8cd5
don't parse nodes inside a comment tag
...
Co-authored-by: Alex Coco <[email protected]
2023-11-07 18:38:13 -04:00
Ieva Grazuleviciute
407a8e5b0f
Fix for custom tag rendering
2023-10-20 11:42:54 +03:00
Guillaume Malette and GitHub
7b60b7fef5
Merge pull request #1746 from Shopify/gm/base64-encoding
...
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 11:13:18 -04:00
Guillaume Malette
33e1a8ffbc
fix style
2023-09-29 09:50:42 -04:00
Guillaume Malette
cc47fa8f03
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 09:39:59 -04:00
Adam Klingbaum
75e7725f57
Streamline new tests for sum filter
2023-08-08 16:15:48 +00:00
James Prior and Adam Klingbaum
2c5d2be193
Don't render sum filter results in scientific notation.
2023-08-08 16:10:03 +00:00
Marco Rudilosso
21d6197533
Call to_liquid_value when short circuiting conditions
2023-07-19 15:22:12 +00:00
Marco Concetto Rudilosso
7f2cf1fe67
Recursively parse for liquid tag
2023-07-07 11:20:34 +01:00
Marco Concetto Rudilosso
10e0fb795e
Allow liquid tag inside liquid tag
2023-07-06 10:45:12 +01:00
Michelle Vinci
9a77e3e923
update desc
2023-07-05 08:44:06 -07:00
Michael Go
dd7bbf26bc
include error mode to partial cache key
2023-06-23 18:48:07 -03:00
Adam Klingbaum
98ce25cb40
Ensure sum filter calls to_liquid
2023-06-22 16:25:11 +00:00
Adam Klingbaum
af66bc8a5f
Add sum filter to standard filters
2023-06-19 19:11:05 +00:00
Guillaume Malette
649cca1349
[trim] Fix trimming at end of raw block when specified in the opening tag
2023-05-19 11:41:45 -04:00
Michael Go
1d97389fb0
render template name with Liquid Syntax errors
2023-03-02 16:50:55 -04:00
Michael Go
24dceef552
set context's template_name with template's name
2023-02-28 10:55:38 -04:00
Michael Go
428c66ffac
add name attribute to Template for more flexibility to set context's template name
2023-02-27 17:11:52 -04:00
Michael Go
0fe4a5d144
render error message with actual template path
2023-02-27 11:01:21 -04:00
Dylan Thacker-Smith and GitHub
e650dc4195
Revert "Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )" ( #1677 )
...
This reverts commit c743936a78
2023-02-22 12:48:18 -05:00
Guilherme Carreiro and GitHub
9ab688eada
Update rubocop-shopify (2.7.0 -> 2.12.0) ( #1687 )
2023-02-15 08:40:59 +01:00
Erin Morrissey
940c3a4207
update link paths in docs markup
2023-02-14 10:34:15 -08:00
Michael Go
2b40850e4a
fix variable lookup parse timing out with missing closing bracket
2023-02-01 19:52:30 -04:00
Marco Concetto Rudilosso
74e505f6fa
Allow raw tag to be used with whitespace control
2023-02-01 13:49:51 +00:00
Michael Go
1aaf6ed019
recursively parse brackets on variable lookup
2023-01-30 20:19:35 -04:00
Michael Go
e889a9da0b
use to_i to parse parameters of tablerow tag
2023-01-17 17:48:16 -04:00
Michael Go
0f11c97623
raise invalid integer argument error from tablerow
2023-01-16 18:53:53 -04:00
Jemma Issroff
128b4e35be
Initialize context to nil on the Drop class
...
We believe this will reduce megamorphic exits in YJIT. There are
currently 241 separate shapes generated with edge_name "@context" in
SFR. Initializing it to nil will significantly reduce this number.
2023-01-12 15:35:22 -05:00
Dylan Thacker-Smith and GitHub
c743936a78
Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )
2023-01-11 14:05:50 -05:00
liamgriffin
936f803a4e
Removed trailing space
2023-01-06 11:36:20 +00:00
liamgriffin
5cd8a83fa6
Adding more content to divided_by filter
...
Adding more content to divided_by filter, by detailing the behaviour of how different results are generated by different types of divisors.
2023-01-06 11:19:13 +00:00
Dylan Thacker-Smith and GitHub
c2c6cb2b15
Allow commas to separate for tag attributes ( #1658 )
...
For consistency with tags like the `render` tag, where we actually
prefer to use commas to separate attributes
2022-11-29 09:00:55 -05:00
Shaina Raskas
8b1b9f649a
remove separate inline comment tag for IA reasons
2022-11-11 16:21:18 -05:00
Shaina Raskas
474315c6bb
edits
2022-11-11 16:03:52 -05:00
Shaina Raskas
667664bb22
clarify inline_comment
2022-11-11 15:34:35 -05:00
Dylan Thacker-Smith and GitHub
1cdd1f0834
refactor: Advance tokenizer array offset instead of using Array#shift ( #1653 )
...
Array#shift would move all the remaining elements of the array, which
is slower for larger arrays.
2022-11-09 13:03:33 -05:00
Peter Zhu
abed47547c
Fix tags in comment
2022-11-01 13:04:41 -04:00
Dylan Thacker-Smith
db8e85ab31
Prevent an internal error in include tag from non-string template_name
...
which would otherwise happen on `template_name.split('/')`
2022-10-28 13:59:00 -04:00
Dylan Thacker-Smith and GitHub
3e8994c258
Have subclasses of a tag inherit superclass's disabled tags ( #1646 )
2022-10-27 11:13:50 -04:00
Erin Morrissey and GitHub
7ccac29688
Merge pull request #1635 from Shopify/update-doc-links
...
Update link paths in docs markup
2022-10-26 11:07:46 -07:00
Dylan Thacker-Smith and GitHub
96b5325f87
Remove Usage.increment calls that have been shown to in fact be used ( #1645 )
...
I think these were added for undocumented features to see if they were
actually used and they were being used.
2022-10-26 09:21:43 -04:00
Ian Ker-Seymer