Michael Go and GitHub
c44d1d9193
Merge pull request #1727 from Shopify/partial-cache-with-error-mode
...
include parse mode to partial cache key
2023-06-27 15:06:58 -03:00
Michael Go
dd7bbf26bc
include error mode to partial cache key
2023-06-23 18:48:07 -03:00
Adam Klingbaum and GitHub
cca24a2226
Merge pull request #1726 from Shopify/klingbaum/ensure_sum_filter_calls_#to_liquid
...
Ensure `sum` filter calls `to_liquid` on evaluated property value
2023-06-22 15:47:36 -04:00
Adam Klingbaum
98ce25cb40
Ensure sum filter calls to_liquid
2023-06-22 16:25:11 +00:00
Adam Klingbaum and GitHub
77293d4524
Merge pull request #1722 from Shopify/klingbaum/sum-filter
...
Add `sum` filter to standard filters
2023-06-19 15:15:49 -04:00
Adam Klingbaum
af66bc8a5f
Add sum filter to standard filters
2023-06-19 19:11:05 +00:00
Guillaume Malette and GitHub
42e5c52336
Merge pull request #1717 from Shopify/gm/fix-raw-trimmode-at-end-of-block
...
[trim] Fix trimming at end of raw block when specified in the opening tag
2023-05-19 14:08:02 -04:00
Guillaume Malette
649cca1349
[trim] Fix trimming at end of raw block when specified in the opening tag
2023-05-19 11:41:45 -04:00
Ian Ker-Seymer and GitHub
81ed65f2a1
Merge pull request #1688 from Shopify/fix-readme-docs-link
...
Fix broken documentantion link in README
2023-05-11 18:48:09 -04:00
Jeffrey Loppert and GitHub
6ca06c22b8
Merge pull request #1712 from Shopify/jloppert/update-readme-docs-link
...
Update Liquid Documentation from Shopify URL
2023-05-10 16:20:40 -04:00
Jeffrey Loppert and GitHub
80bc7ffdf2
Update Liquid Documentation from Shopify URL
...
Current url https://shopify.dev/docs/docs/api/liquid 404s. Updated to https://shopify.dev/docs/api/liquid
2023-05-10 14:47:16 -04:00
Michael Go and GitHub
48cb643c02
Merge pull request #1695 from Shopify/syntax-error-with-filename
...
render template name with Liquid Syntax errors
2023-03-02 17:08:27 -04:00
Michael Go
1d97389fb0
render template name with Liquid Syntax errors
2023-03-02 16:50:55 -04:00
Michael Go and GitHub
3ff4170cb0
Merge pull request #1692 from Shopify/error-message-with-filepath
...
set context's template_name with template.name in render and include tag
2023-02-28 10:57:24 -04:00
Michael Go
24dceef552
set context's template_name with template's name
2023-02-28 10:55:38 -04:00
Michael Go
428c66ffac
add name attribute to Template for more flexibility to set context's template name
2023-02-27 17:11:52 -04:00
Michael Go
0fe4a5d144
render error message with actual template path
2023-02-27 11:01:21 -04:00
Dylan Thacker-Smith and GitHub
e650dc4195
Revert "Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )" ( #1677 )
...
This reverts commit c743936a78 .
2023-02-22 12:48:18 -05:00
Robertas Godelis
a75517e2c7
Fix broken documentantion link in README
2023-02-15 18:27:36 +02:00
Guilherme Carreiro and GitHub
9ab688eada
Update rubocop-shopify (2.7.0 -> 2.12.0) ( #1687 )
2023-02-15 08:40:59 +01:00
Erin Morrissey and GitHub
abef59d129
Merge pull request #1685 from Shopify/update-liquid-paths
...
Update link paths in docs markup
2023-02-14 10:37:15 -08:00
Erin Morrissey
940c3a4207
update link paths in docs markup
2023-02-14 10:34:15 -08:00
Guilherme Carreiro and GitHub
84a0289ebc
Fix CI (as it installs RuboCop 1.45.1 and fails) ( #1686 )
2023-02-14 12:24:38 +01:00
Michael Go and GitHub
4599e5459f
Merge pull request #1684 from Shopify/fix-variable-lookup-parse-timeout
...
fix variable lookup parse timing out with missing closing bracket
2023-02-02 10:39:46 -04:00
Dylan Thacker-Smith and GitHub
59c445f0e1
Avoid a couple of duplicate assertions ( #1675 )
2023-02-02 09:31:01 -05:00
Michael Go
bd9c3802c8
add variable parser timeout unit tests
2023-02-01 21:15:35 -04:00
Michael Go
2b40850e4a
fix variable lookup parse timing out with missing closing bracket
2023-02-01 19:52:30 -04:00
Marco Concetto Rudilosso and GitHub
22ded5f304
Merge pull request #1683 from Shopify/marco/raw-tag-whitespace-control
...
Allow raw tag to be used with whitespace control
2023-02-01 16:51:46 +00:00
Marco Concetto Rudilosso
ddc32b7bd8
actually test whitespace stripping
2023-02-01 15:52:34 +00:00
Marco Concetto Rudilosso
74e505f6fa
Allow raw tag to be used with whitespace control
2023-02-01 13:49:51 +00:00
Michael Go and GitHub
6a888d4564
Merge pull request #1680 from Shopify/recursively-parse-brackets
...
recursively parse brackets on variable lookup
2023-01-31 16:29:54 -04:00
Michael Go
dd257b3d66
add an unit test for double nest variable lookup
2023-01-30 20:36:14 -04:00
Michael Go
1aaf6ed019
recursively parse brackets on variable lookup
2023-01-30 20:19:35 -04:00
Michael Go and GitHub
daf93a83c2
Merge pull request #1676 from Shopify/tablerow-nil-params
...
raise invalid integer argument error from tablerow
2023-01-18 11:08:04 -04:00
Michael Go
e889a9da0b
use to_i to parse parameters of tablerow tag
2023-01-17 17:48:16 -04:00
Michael Go
0f11c97623
raise invalid integer argument error from tablerow
2023-01-16 18:53:53 -04:00
Dylan Thacker-Smith and GitHub
e804f36681
Merge pull request #1674 from Shopify/better-test-to-liquid-value
...
Improve test coverage of the to_liquid_value feature.
2023-01-16 10:44:41 -05:00
Dylan Thacker-Smith
619ed3fcd7
Add some additional to_liquid_value assertions
2023-01-13 15:46:12 -05:00
Dylan Thacker-Smith
cdb5cb06b2
Remove == method from drops from testing to_liquid_value
...
Since they could cause tests to pass without to_liquid_value being called
on the left side of the equality comparison.
2023-01-13 15:37:27 -05:00
Jean byroot Boussier and GitHub
bc153159e6
Merge pull request #1673 from Shopify/initialize-context
...
Initialize context to nil on the Drop class
2023-01-12 22:19:28 +01:00
Jemma Issroff
128b4e35be
Initialize context to nil on the Drop class
...
We believe this will reduce megamorphic exits in YJIT. There are
currently 241 separate shapes generated with edge_name "@context" in
SFR. Initializing it to nil will significantly reduce this number.
2023-01-12 15:35:22 -05:00
Dylan Thacker-Smith and GitHub
c743936a78
Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )
2023-01-11 14:05:50 -05:00
Dylan Thacker-Smith and GitHub
bf711a0521
Provide another assertion for to_liquid_value unless tag test ( #1672 )
...
Since the original one would pass even if to_liquid_value isn't called on
the BooleanDrop object.
2023-01-11 14:05:27 -05:00
Dylan Thacker-Smith and GitHub
e8731f27d9
Merge pull request #1671 from ashmaroli/use-builtin-bundle-cache
...
Use cache built into `ruby/setup-ruby` action
2023-01-11 11:40:11 -05:00
Ashwin Maroli
6a44c1ec77
Do not set ENV["BUNDLE_PATH"]
2023-01-11 22:06:47 +05:30
Ashwin Maroli
1beb87b446
Bump latest Ruby version in CI matrix
2023-01-11 20:58:17 +05:30
Ashwin Maroli
b839deb3a8
Use cache built into ruby/setup-ruby action
2023-01-11 20:50:44 +05:30
liamgriffin and GitHub
0b826120c0
Merge pull request #1665 from Shopify/update-description-divided_by-filter
...
[Liquid reference docs] Adding more content to divided_by filter
2023-01-09 14:12:23 +00:00
liamgriffin
936f803a4e
Removed trailing space
2023-01-06 11:36:20 +00:00
liamgriffin
5cd8a83fa6
Adding more content to divided_by filter
...
Adding more content to divided_by filter, by detailing the behaviour of how different results are generated by different types of divisors.
2023-01-06 11:19:13 +00:00