Jemma Issroff
128b4e35be
Initialize context to nil on the Drop class
...
We believe this will reduce megamorphic exits in YJIT. There are
currently 241 separate shapes generated with edge_name "@context" in
SFR. Initializing it to nil will significantly reduce this number.
2023-01-12 15:35:22 -05:00
Dylan Thacker-Smith and GitHub
c743936a78
Instrument usage of bug with iteration of String with offset or 0 limit ( #1667 )
2023-01-11 14:05:50 -05:00
Dylan Thacker-Smith and GitHub
bf711a0521
Provide another assertion for to_liquid_value unless tag test ( #1672 )
...
Since the original one would pass even if to_liquid_value isn't called on
the BooleanDrop object.
2023-01-11 14:05:27 -05:00
Dylan Thacker-Smith and GitHub
e8731f27d9
Merge pull request #1671 from ashmaroli/use-builtin-bundle-cache
...
Use cache built into `ruby/setup-ruby` action
2023-01-11 11:40:11 -05:00
Ashwin Maroli
6a44c1ec77
Do not set ENV["BUNDLE_PATH"]
2023-01-11 22:06:47 +05:30
Ashwin Maroli
1beb87b446
Bump latest Ruby version in CI matrix
2023-01-11 20:58:17 +05:30
Ashwin Maroli
b839deb3a8
Use cache built into ruby/setup-ruby action
2023-01-11 20:50:44 +05:30
liamgriffin and GitHub
0b826120c0
Merge pull request #1665 from Shopify/update-description-divided_by-filter
...
[Liquid reference docs] Adding more content to divided_by filter
2023-01-09 14:12:23 +00:00
liamgriffin
936f803a4e
Removed trailing space
2023-01-06 11:36:20 +00:00
liamgriffin
5cd8a83fa6
Adding more content to divided_by filter
...
Adding more content to divided_by filter, by detailing the behaviour of how different results are generated by different types of divisors.
2023-01-06 11:19:13 +00:00
Dylan Thacker-Smith and GitHub
c2c6cb2b15
Allow commas to separate for tag attributes ( #1658 )
...
For consistency with tags like the `render` tag, where we actually
prefer to use commas to separate attributes
2022-11-29 09:00:55 -05:00
shainaraskas and GitHub
9ccbf64571
Merge pull request #1656 from Shopify/sr-inline-comment
...
clarify inline_comment
2022-11-14 10:38:55 -05:00
Shaina Raskas
8b1b9f649a
remove separate inline comment tag for IA reasons
2022-11-11 16:21:18 -05:00
Shaina Raskas
474315c6bb
edits
2022-11-11 16:03:52 -05:00
Shaina Raskas
667664bb22
clarify inline_comment
2022-11-11 15:34:35 -05:00
Dylan Thacker-Smith and GitHub
1cdd1f0834
refactor: Advance tokenizer array offset instead of using Array#shift ( #1653 )
...
Array#shift would move all the remaining elements of the array, which
is slower for larger arrays.
2022-11-09 13:03:33 -05:00
Dylan Thacker-Smith and GitHub
1cd5ec54f0
Merge pull request #1641 from Shopify/assert-template-result-static-env
...
Use static environment assert_template_result input values
2022-11-02 10:05:52 -04:00
Peter Zhu and GitHub
29732f4305
Merge pull request #1345 from Shopify/pz-fix-tags-in-comment
...
Fix tags in comment
2022-11-01 13:07:03 -04:00
Peter Zhu
abed47547c
Fix tags in comment
2022-11-01 13:04:41 -04:00
Dylan Thacker-Smith and GitHub
ace3fe15ac
Merge pull request #1648 from Shopify/fix-include-internal-error
...
Prevent an internal error in include tag from non-string template_name
2022-10-28 14:29:03 -04:00
Dylan Thacker-Smith
db8e85ab31
Prevent an internal error in include tag from non-string template_name
...
which would otherwise happen on `template_name.split('/')`
2022-10-28 13:59:00 -04:00
Dylan Thacker-Smith
f484b868d0
assert_template_result: Avoid using the BlankFileSystem
...
Since it doesn't reflect the real liquid usage that we are trying
to test against.
2022-10-28 13:55:33 -04:00
Dylan Thacker-Smith and GitHub
3e8994c258
Have subclasses of a tag inherit superclass's disabled tags ( #1646 )
2022-10-27 11:13:50 -04:00
Erin Morrissey and GitHub
7ccac29688
Merge pull request #1635 from Shopify/update-doc-links
...
Update link paths in docs markup
2022-10-26 11:07:46 -07:00
Dylan Thacker-Smith and GitHub
96b5325f87
Remove Usage.increment calls that have been shown to in fact be used ( #1645 )
...
I think these were added for undocumented features to see if they were
actually used and they were being used.
2022-10-26 09:21:43 -04:00
Erin Morrissey
b8f05267a9
update link paths in docs markup
2022-10-25 11:53:27 -07:00
Dylan Thacker-Smith and GitHub
6ce4ec1011
tablerow: Avoid accidental special case for constant nil cols ( #1644 )
...
It should behave the same as an expression that evaluates to nil
2022-10-25 10:21:03 -04:00
Dylan Thacker-Smith
a39422feac
Use static environment assert_template_result input values
...
To match how we use liquid in practice
2022-10-21 11:45:29 -04:00
Dylan Thacker-Smith
2c2f5826d5
Change increment/decrement tests to avoid relying on input
...
So these can be tested using language tests, without needing support
for counter value input, which isn't needed if input is provided
through the static environment.
2022-10-21 11:43:58 -04:00
Dylan Thacker-Smith and GitHub
c99c93255d
Merge pull request #1617 from Shopify/better-filter-overflow-handling
...
Support big integers in truncatewords and slice filters
2022-10-11 12:55:33 -04:00
Dylan Thacker-Smith
c0c191cabd
Add assertions for truncate filter with large integers
2022-10-11 12:44:33 -04:00
Dylan Thacker-Smith
6765d93938
Avoid internal errors for large arguments to slice filter
...
Use saturating conversion, which has expected semantics for large integers.
2022-10-11 12:44:32 -04:00
Dylan Thacker-Smith
4f17abfb4a
Handle truncatewords word length out of range as if no truncation is needed
2022-10-11 12:44:32 -04:00
Michael Go and GitHub
eff2a63204
Merge pull request #1633 from Shopify/fix-tablerow-drop-cols-last-attr
...
fix tablerow drop's last attribute with missing cols param
2022-10-05 14:15:03 -03:00
Michael Go
fbab19ac8c
fix tablerow drop's last attribute with missing cols param
2022-10-05 11:15:23 -03:00
Jan Gregor Triebel and GitHub
b14bf94c98
Merge pull request #1636 from Shopify/documentation-clarification-for-comment
...
Clarifying description for {% comment %}
2022-10-05 14:54:29 +02:00
Thierry Joyal and GitHub
347a2418c4
Update homepage url
...
`http://www.liquidmarkup.org ` is `http`
`http://www.liquidmarkup.org ` redirects to `https://shopify.github.io/liquid/ `
`https://www.liquidmarkup.org ` can’t provide a secure connection (ERR_SSL_PROTOCOL_ERROR)
2022-10-03 16:52:22 -04:00
Jan Emge-Triebel
951be6c1f5
Clarified comment's liquid description
2022-09-30 09:07:06 +00:00
liamgriffin and GitHub
c8f3cfa8fc
Merge pull request #1628 from Shopify/updating-escape-filter-reference
...
Update escape filter reference summary
2022-09-29 14:32:36 +01:00
liamgriffin
f21d1c5d9d
Update escape filter reference summary
...
Added more context/ explanation for escape filter
Fixes issue in dev docs https://github.com/Shopify/shopify-dev/pull/26494
2022-09-28 12:24:46 +01:00
Dylan Thacker-Smith and GitHub
456be2f75e
Add a test and improve one for testing break ( #1616 )
2022-09-15 10:08:15 -04:00
Dylan Thacker-Smith and GitHub
ff1c35b986
Stop using assert_template_result in some tests depending on language extension ( #1622 )
2022-09-14 17:03:48 -04:00
Dylan Thacker-Smith and GitHub
cab08cfe57
Stop freezing the static environment hashes to allow Proc memoization ( #1623 )
2022-09-14 15:00:57 -04:00
Dylan Thacker-Smith and GitHub
bb7027138e
Merge pull request #1620 from Shopify/use-partials-test-option
...
Use assert_template_result partials option to specify file system state
2022-09-13 15:36:50 -04:00
Dylan Thacker-Smith
34512df8e9
Use assert_template_result partials option to specify file system state
2022-09-13 10:11:01 -04:00
Dylan Thacker-Smith
bca01e8944
Add assert_syntax_error convenience method
2022-09-13 10:11:01 -04:00
Dylan Thacker-Smith and GitHub
d3647e280d
Merge pull request #1615 from Shopify/render-expose-for-alias
...
Expose alias_name and for_loop? in render tag
2022-09-08 10:40:27 -04:00
Marco Concetto Rudilosso and Dylan Thacker-Smith
c0f565ce7b
Update lib/liquid/tags/render.rb
...
Co-authored-by: Dylan Thacker-Smith <[email protected] >
2022-09-08 10:37:23 -04:00
Marco Concetto Rudilosso and GitHub
753015d8fc
remove question mark
2022-09-08 15:59:46 +02:00
Marco Concetto Rudilosso and GitHub
f4e32d2214
Expose alias_name and for_loop? in render tag
2022-09-08 15:38:18 +02:00