Michael Go
a5e5fab82a
update variable's context before invoking its to_liquid
2024-02-12 16:48:20 -04:00
Ian Ker-Seymer and GitHub
02ecaab9d1
Merge pull request #1783 from Shopify/contains-encoding
...
Fallback to binary comparison when `contains` RHS is UTF8 encoded
2024-01-31 11:14:01 -05:00
Ian Ker-Seymer
1b2b62964e
Allow for binary comparison of incompatible strings
2024-01-30 19:03:05 -05:00
Michael Go and GitHub
9b38a15282
Merge pull request #1776 from Shopify/refactor/invalid-encoding-error
...
add new TemplateEncodingError
2024-01-12 12:38:34 -04:00
Michael Go
7b25b770af
add new TemplateEncodingError
2024-01-12 12:17:20 -04:00
Michael Go and GitHub
cf76c0bbec
Merge pull request #1775 from Shopify/allow-nil-template-source
...
allow non-string template source
2024-01-12 10:48:30 -04:00
Michael Go
6a0fe3f7e3
convert template source to string to ensure encoding validity
2024-01-10 16:50:31 -04:00
Michael Go
730ad3684a
allow nil template source
2024-01-10 16:32:08 -04:00
Michael Go and GitHub
3ac7e470e6
Merge pull request #1774 from Shopify/check-utf8-validity
...
check template UTF8 validity before parsing
2024-01-10 15:27:49 -04:00
Michael Go
369a6c55e3
check template UTF8 validity before parsing
2024-01-10 18:58:15 +00:00
Michael Go and GitHub
f5ed5404b5
Merge pull request #1773 from Shopify/liquid-tag-whitespace-control-with-comment
...
don't reset Liquid tag's whitespace control from comment tag
2024-01-05 10:54:32 -04:00
Michael Go
a3c837687e
don't reset Liquid tag's whitespace control from comment tag
2024-01-05 10:21:33 -04:00
Michael Go and GitHub
96a036372d
Merge pull request #1770 from Shopify/revert-invalid-comment-body
...
don't allow invalid syntax inside comment tag
2024-01-02 11:07:05 -04:00
Mamoru TASAKA
4924822c88
change: make nil_safe_casecmp judge compatible for nil-nil comparison
...
Ruby returns 0 (not nil) for nil <=> nil, i.e. nil and nil are judged
as equal for comparison, and so returns nil_safe_compare .
ref: https://github.com/Shopify/liquid/pull/1476
To make the behavior of nil_safe_casecmp consistent with
nil_safe_compare , change nil_safe_casecmp so that comparison between
nil <=> nil return 0 (equal).
Also change testsuite to reflect this change.
Fixes #1759 .
2023-12-15 15:09:57 +09:00
Michael Go
fc9c338682
refactor: rename comment tag unit test
2023-12-14 17:08:26 -04:00
Michael Go
3c5ad7db61
don't allow invalid syntax inside comment tag
2023-12-14 17:01:03 -04:00
Michael Go and GitHub
c658bf970a
Merge pull request #1769 from Shopify/comment-tag-with-extra-string
...
fix parsing comment tag with extra string
2023-12-13 14:16:44 -04:00
Michael Go
c618ac1c9f
fix parsing comment tag with extra string
2023-12-12 16:23:37 -04:00
Ian Ker-Seymer and GitHub
0f0d5d889f
Merge pull request #1750 from IevaGraz/fix/custom_tag_rendering
...
Fix for custom tag rendering
2023-12-10 11:28:50 -05:00
Michael Go and GitHub
11a1f8e673
Merge pull request #1764 from Shopify/fix-comment-tag-whitespace-control
...
implement whitespace control to comment tag
2023-12-06 14:30:16 -05:00
Michael Go
24d461a9e3
implement whitespace control to comment tag
2023-12-01 16:04:03 -04:00
Michael Go and GitHub
cbb422e5d3
Merge pull request #1763 from Shopify/fix-comment-tag-delim-parsing
...
fix parsing comment tag delimiter
2023-12-01 15:35:32 -04:00
Michael Go
bf0f79f36c
fix parsing comment tag delimiter
2023-11-30 13:24:54 -04:00
Michael Go and GitHub
cf2787791e
Merge pull request #1755 from Shopify/non-parsing-comment
...
Don't parse nodes inside a comment tag
2023-11-29 14:10:20 -04:00
Michael Go
6a5ebb0e85
fix parsing nested comment tag with extra strings
2023-11-11 12:19:44 -04:00
Michael Go
6dafc19b6d
fix parsing comment tag delimiter with extra strings
2023-11-10 15:42:54 -04:00
Michael Go
41f65173b0
fix parsing comment block body inside a liquid tag
2023-11-09 16:27:23 -04:00
Michael Go
e180535784
allow incomplete tags inside a comment tag
2023-11-08 16:50:41 -04:00
Michael Go
a681e73aec
refactor comment tag unit test to use test helper
2023-11-08 16:45:11 -04:00
Michael Go
2abf52d546
add a quirky comment tag unit test
2023-11-08 11:23:00 -04:00
eada2b65a2
clean up comment tag body parsing
...
Co-authored-by: Peter Zhu <[email protected]
2023-11-08 11:13:13 -04:00
Michael Go and Alex Coco
dbf0aa8cd5
don't parse nodes inside a comment tag
...
Co-authored-by: Alex Coco <[email protected]
2023-11-07 18:38:13 -04:00
Ieva Grazuleviciute
407a8e5b0f
Fix for custom tag rendering
2023-10-20 11:42:54 +03:00
Ateş Göral and GitHub
e3dcc75ab5
Merge pull request #1748 from Shopify/atesgoral/update-ci-status-badge
...
Update CI status badge
2023-10-16 11:23:04 -04:00
Ates Goral
ceb7a4237f
Update CI status badge
2023-10-16 11:17:24 -04:00
Guillaume Malette and GitHub
7b60b7fef5
Merge pull request #1746 from Shopify/gm/base64-encoding
...
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 11:13:18 -04:00
Guillaume Malette
33e1a8ffbc
fix style
2023-09-29 09:50:42 -04:00
Guillaume Malette
cc47fa8f03
[base64] Respect string encoding of input in base64_decode filters
2023-09-29 09:39:59 -04:00
Adam Klingbaum and GitHub
b1b9b9f691
Merge pull request #1739 from Shopify/klingbaum/fix-sum-filter-float-output
...
Fix `BigDecimal` output in `sum` filter
2023-09-27 13:34:27 -04:00
Adam Klingbaum
75e7725f57
Streamline new tests for sum filter
2023-08-08 16:15:48 +00:00
James Prior and Adam Klingbaum
de6d15a73e
Test sum floats from properties.
2023-08-08 16:10:04 +00:00
James Prior and Adam Klingbaum
2c5d2be193
Don't render sum filter results in scientific notation.
2023-08-08 16:10:03 +00:00
Samuel Doiron and GitHub
0b9318222b
Merge pull request #1735 from Shopify/marco-condition-to-liquid-value
...
Call to_liquid_value when short circuiting conditions
2023-07-19 15:05:00 -03:00
Marco Rudilosso
21d6197533
Call to_liquid_value when short circuiting conditions
2023-07-19 15:22:12 +00:00
Marco Concetto Rudilosso and GitHub
5e92b3a89a
Merge pull request #1731 from Shopify/allow-recursive-liquid-tags
...
Allow liquid tag inside liquid tag
2023-07-10 13:25:13 +01:00
Marco Concetto Rudilosso
7f2cf1fe67
Recursively parse for liquid tag
2023-07-07 11:20:34 +01:00
Marco Concetto Rudilosso
10e0fb795e
Allow liquid tag inside liquid tag
2023-07-06 10:45:12 +01:00
Michelle Vinci and GitHub
546dd9bc06
Merge pull request #1730 from Shopify/capitalize-desc-fix
...
[Liquid reference]: Update description of `capitalize`
2023-07-05 08:52:26 -07:00
Michelle Vinci
9a77e3e923
update desc
2023-07-05 08:44:06 -07:00
Michael Go and GitHub
c44d1d9193
Merge pull request #1727 from Shopify/partial-cache-with-error-mode
...
include parse mode to partial cache key
2023-06-27 15:06:58 -03:00
Michael Go