From f78c443ccd2ceb9b4c6fe6367843e0adff1e857b Mon Sep 17 00:00:00 2001 From: Julia Boutin Date: Tue, 4 Nov 2025 14:44:56 -0700 Subject: [PATCH] Update resource limit handling This commit aligns snippet tag's resource limit handling with assign tag's `assign_score_of` method where the snippet variable acts as a pointer to a block body - increasing assign score by one --- lib/liquid/tags/snippet.rb | 8 +------- test/integration/tags/snippet_test.rb | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/liquid/tags/snippet.rb b/lib/liquid/tags/snippet.rb index 87e2a0de..0341f082 100644 --- a/lib/liquid/tags/snippet.rb +++ b/lib/liquid/tags/snippet.rb @@ -28,18 +28,12 @@ module Liquid def render_to_output_buffer(context, output) snippet_drop = SnippetDrop.new(@body, @to, context.template_name) context.scopes.last[@to] = snippet_drop - context.resource_limits.increment_assign_score(assign_score_of(snippet_drop)) + context.resource_limits.increment_assign_score(1) output end def blank? true end - - private - - def assign_score_of(snippet_drop) - snippet_drop.body.nodelist.sum { |node| node.to_s.bytesize } - end end end diff --git a/test/integration/tags/snippet_test.rb b/test/integration/tags/snippet_test.rb index 6d1cb35d..466aaa12 100644 --- a/test/integration/tags/snippet_test.rb +++ b/test/integration/tags/snippet_test.rb @@ -1081,7 +1081,7 @@ class SnippetTest < Minitest::Test def test_increment_assign_score_by_bytes_not_characters t = Template.parse("{% snippet foo %}すごい{% endsnippet %}") t.render! - assert_equal(9, t.resource_limits.assign_score) + assert_equal(1, t.resource_limits.assign_score) end end end