Fix empty? semantics and string first/last for empty strings

- nil is NOT empty (but IS blank) - matches Shopify production
- String first/last returns '' for empty strings, not nil - matches ActiveSupport
- Add test for nil not being empty
This commit is contained in:
Tobi Lutke
2026-01-01 22:06:22 -05:00
parent b0fb0ad83f
commit ef13b2dfd5
5 changed files with 21 additions and 7 deletions
+10
View File
@@ -353,6 +353,16 @@ class ConditionUnitTest < Minitest::Test
assert_evaluates_true(VariableLookup.new('empty_hash'), '==', empty_literal)
end
def test_nil_is_not_empty
# nil is NOT empty - empty? checks if a collection has zero elements.
# nil is not a collection, so it cannot be empty.
# This differs from blank: nil IS blank, but nil is NOT empty.
@context['nil_value'] = nil
empty_literal = Condition.class_variable_get(:@@method_literals)['empty']
assert_evaluates_false(VariableLookup.new('nil_value'), '==', empty_literal)
end
private
def assert_evaluates_true(left, op, right)