Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-28 22:55:12 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1951 from Shopify/actual-revert

Browse Source 
Fully revert calling to_s on filter array
This commit is contained in:
Marco Concetto Rudilosso
2025-04-14 17:49:47 +02:00
committed by GitHub
parent cc04892e54 c34dd812c5
commit ea864f1177
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/standardfilters.rb
-2
View File
@@ -982,8 +982,6 @@ module Liquid
return default_value if ary.empty? return default_value if ary.empty?
property = Utils.to_s(property)
block.call(ary) do |item| block.call(ary) do |item|
if target_value.nil? if target_value.nil?
item[property] item[property]
lib/liquid/version.rb
+1 -1
View File
@@ -2,5 +2,5 @@
# frozen_string_literal: true # frozen_string_literal: true
module Liquid module Liquid
VERSION = "5.8.5" VERSION = "5.8.6"
end end
test/integration/standard_filter_test.rb
+3 -2
View File
@@ -1054,10 +1054,11 @@ class StandardFiltersTest < Minitest::Test
def test_where_with_nil_is_a_no_op def test_where_with_nil_is_a_no_op
environment = { "array" => ["alpha", "beta", "gamma"] } environment = { "array" => ["alpha", "beta", "gamma"] }
expected_output = "alpha beta gamma"
template = "{{ array | where: nil | join: ' ' }}" template = "{{ array | where: nil | join: ' ' }}"
assert_template_result(expected_output, template, environment) assert_raises(Liquid::ArgumentError) do
assert_template_result("alpha beta gamma", template, environment)
end
end end
def test_where_with_value def test_where_with_value