From e57b7efe4e1cb3bc1ecf65887d07e881c0132448 Mon Sep 17 00:00:00 2001
From: Guilherme Carreiro <guilherme.carreiro@shopify.com>
Date: Fri, 24 Oct 2025 09:10:00 +0200
Subject: [PATCH] Simplify render/include tags following PR review feedback

---
 lib/liquid/tags/include.rb   | 18 +++---------------
 lib/liquid/tags/render.rb    | 20 +++++---------------
 lib/liquid/tags/table_row.rb |  3 +--
 3 files changed, 9 insertions(+), 32 deletions(-)

diff --git a/lib/liquid/tags/include.rb b/lib/liquid/tags/include.rb
index 8dc9567a..5b2aaa43 100644
--- a/lib/liquid/tags/include.rb
+++ b/lib/liquid/tags/include.rb
@@ -88,20 +88,9 @@ module Liquid
       p = @parse_context.new_parser(markup)
 
       @template_name_expr = safe_parse_expression(p)
-      with_or_for = p.id?("for") || p.id?("with") || nil
-      @variable_name_expr = nil
-      if with_or_for
-        @variable_name_expr = safe_parse_expression(p)
-      end
+      @variable_name_expr = safe_parse_expression(p) if p.id?("for") || p.id?("with")
+      @alias_name         = p.consume(:id) if p.id?("as")
 
-      alias_name = nil
-      if p.id?("as")
-        alias_name = p.consume(:id)
-      end
-
-      @alias_name = alias_name
-
-      # optional comma
       p.consume?(:comma)
 
       @attributes = {}
@@ -109,7 +98,7 @@ module Liquid
         key = p.consume
         p.consume(:colon)
         @attributes[key] = safe_parse_expression(p)
-        p.consume?(:comma) # optional comma
+        p.consume?(:comma)
       end
 
       p.consume(:end_of_string)
@@ -121,7 +110,6 @@ module Liquid
 
     def lax_parse(markup)
       if markup =~ SYNTAX
-
         template_name = Regexp.last_match(1)
         variable_name = Regexp.last_match(3)
 
diff --git a/lib/liquid/tags/render.rb b/lib/liquid/tags/render.rb
index efe83b0d..4d29e420 100644
--- a/lib/liquid/tags/render.rb
+++ b/lib/liquid/tags/render.rb
@@ -89,21 +89,11 @@ module Liquid
       p = @parse_context.new_parser(markup)
 
       @template_name_expr = parse_expression(rigid_template_name(p), safe: true)
-      @variable_name_expr = nil
-      with_or_for = p.id?("for") || p.id?("with") || nil
-      if with_or_for
-        @variable_name_expr = safe_parse_expression(p)
-      end
+      with_or_for         = p.id?("for") || p.id?("with")
+      @variable_name_expr = safe_parse_expression(p) if with_or_for
+      @alias_name         = p.consume(:id) if p.id?("as")
+      @is_for_loop        = (with_or_for == FOR)
 
-      alias_name = nil
-      if p.id?("as")
-        alias_name = p.consume(:id)
-      end
-
-      @alias_name = alias_name
-      @is_for_loop = (with_or_for == FOR)
-
-      # optional comma
       p.consume?(:comma)
 
       @attributes = {}
@@ -111,7 +101,7 @@ module Liquid
         key = p.consume
         p.consume(:colon)
         @attributes[key] = safe_parse_expression(p)
-        p.consume?(:comma) # optional comma
+        p.consume?(:comma)
       end
 
       p.consume(:end_of_string)
diff --git a/lib/liquid/tags/table_row.rb b/lib/liquid/tags/table_row.rb
index 11aa4ef5..7348b5d9 100644
--- a/lib/liquid/tags/table_row.rb
+++ b/lib/liquid/tags/table_row.rb
@@ -45,7 +45,6 @@ module Liquid
 
       @collection_name = safe_parse_expression(p)
 
-      # optional comma
       p.consume?(:comma)
 
       @attributes = {}
@@ -57,7 +56,7 @@ module Liquid
 
         p.consume(:colon)
         @attributes[key] = safe_parse_expression(p)
-        p.consume?(:comma) # optional comma
+        p.consume?(:comma)
       end
 
       p.consume(:end_of_string)