Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-10-03 00:55:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

Add memoization comment

Browse Source
This commit is contained in:
Thierry Joyal
2022-03-04 13:31:16 -05:00
parent 90d4de1ad9
commit e2450af4e6
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/context.rb
+7 -1
View File
@@ -203,8 +203,14 @@ module Liquid
value = contextualize(original) value = contextualize(original)
# TODO: I'd like to fold this under the liquid sanitization # TODO: This memoization layer knows about the Proc behaviour and it does not put me at ease
# Also to note: VariableLookup command flags do not know about it which might be ok
#
# Original text from VariableLookup: if its a proc we will replace the entry with the proc # Original text from VariableLookup: if its a proc we will replace the entry with the proc
#
# Removing original.is_a?(Proc) from condition leads to: FrozenError: can't modify frozen Hash: {}
# Removing obj.respond_to?(:[]=) from condition leads to: Test suite passes
# obj[key] = value (no conditions): FrozenError + NoMethodError: undefined method `[]=' for <ObjectInContext>
if original.is_a?(Proc) && obj.respond_to?(:[]=) if original.is_a?(Proc) && obj.respond_to?(:[]=)
obj[key] = value obj[key] = value
end end