Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-15 08:50:45 -07:00
Code Issues Packages Projects Releases Wiki Activity

avoid unnecessary strip allocation in Expression.parse, use byteslice for string literals

Browse Source
This commit is contained in:
Tobi Lutke
2026-03-11 07:23:08 -04:00
parent d291e63006
commit d79b9fa254
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/expression.rb
+9 -2
View File
@@ -35,11 +35,18 @@ module Liquid
def parse(markup, ss = StringScanner.new(""), cache = nil) def parse(markup, ss = StringScanner.new(""), cache = nil)
return unless markup return unless markup
markup = markup.strip # markup can be a frozen string # Only strip if there's leading/trailing whitespace (avoids allocation)
first_byte = markup.getbyte(0)
if first_byte == 32 || first_byte == 9 || first_byte == 10 || first_byte == 13 # space, tab, \n, \r
markup = markup.strip
else
last_byte = markup.getbyte(markup.bytesize - 1)
markup = markup.strip if last_byte == 32 || last_byte == 9 || last_byte == 10 || last_byte == 13
end
if (markup.start_with?('"') && markup.end_with?('"')) || if (markup.start_with?('"') && markup.end_with?('"')) ||
(markup.start_with?("'") && markup.end_with?("'")) (markup.start_with?("'") && markup.end_with?("'"))
return markup[1..-2] return markup.byteslice(1, markup.bytesize - 2)
elsif LITERALS.key?(markup) elsif LITERALS.key?(markup)
return LITERALS[markup] return LITERALS[markup]
end end