Merge pull request #412 from Shopify/assign-strict

Pass through options on assign tag
This commit is contained in:
Tristan Hume
2014-08-11 15:37:49 -04:00
2 changed files with 12 additions and 1 deletions
+1 -1
View File
@@ -15,7 +15,7 @@ module Liquid
super super
if markup =~ Syntax if markup =~ Syntax
@to = $1 @to = $1
@from = Variable.new($2) @from = Variable.new($2,options)
else else
raise SyntaxError.new options[:locale].t("errors.syntax.assign".freeze) raise SyntaxError.new options[:locale].t("errors.syntax.assign".freeze)
end end
+11
View File
@@ -24,4 +24,15 @@ class AssignTest < Minitest::Test
'{% assign foo not values %}.', '{% assign foo not values %}.',
'values' => "foo,bar,baz") 'values' => "foo,bar,baz")
end end
def test_assign_uses_error_mode
with_error_mode(:strict) do
assert_raises(SyntaxError) do
Template.parse("{% assign foo = ('X' | downcase) %}")
end
end
with_error_mode(:lax) do
assert Template.parse("{% assign foo = ('X' | downcase) %}")
end
end
end # AssignTest end # AssignTest