Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-12 23:40:45 -07:00
Code Issues Packages Projects Releases Wiki Activity

Support prop spreading

Browse Source
This commit is contained in:
Julia Boutin
2025-10-30 12:00:44 +01:00
committed by Guilherme Carreiro
parent 0ceeefba02
commit d4d2237b90
3 changed files with 329 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/tags/snippet_test.rb
+274
View File
@@ -446,6 +446,154 @@ class SnippetTest < Minitest::Test
assert_template_result(expected, template)
end
def test_render_inline_snippet_with_spread_hash
template = <<~LIQUID.strip
{% snippet header %}
<div>
{{ word }} {{ number }}
</div>
{% endsnippet %}
{% render header, ...details %}
LIQUID
expected = <<~OUTPUT
<div>
potato 5
</div>
OUTPUT
assert_template_result(expected, template, { 'details' => { 'word' => 'potato', 'number' => 5 } })
end
def test_render_inline_snippet_with_spread_drop
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
def price
99
end
def vendor
'Acme'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>
{{ title }} - ${{ price }} by {{ vendor }}
</div>
{% endsnippet %}
{% render card, ...product %}
LIQUID
expected = <<~OUTPUT
<div>
Cool Product - $99 by Acme
</div>
OUTPUT
assert_template_result(expected, template, { 'product' => product_drop.new })
end
def test_render_inline_snippet_with_overwritten_spread_drop
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
def price
99
end
def vendor
'Acme'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>
{{ title }} - ${{ price }} by {{ vendor }}
</div>
{% endsnippet %}
{% render card, ...product, price: 10 %}
LIQUID
expected = <<~OUTPUT
<div>
Cool Product - $10 by Acme
</div>
OUTPUT
assert_template_result(expected, template, { 'product' => product_drop.new })
end
def test_render_inline_snippet_spread_before_explicit_args
template = <<~LIQUID.strip
{% snippet card %}
<div>{{ price }}</div>
{% endsnippet %}
{% render card, ...details, price: 10 %}
LIQUID
expected = <<~OUTPUT
<div>10</div>
OUTPUT
assert_template_result(expected, template, { 'details' => { 'price' => 99 } })
end
def test_render_inline_snippet_multiple_spreads
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>{{ title }} - {{ price }} {{ color }}</div>
{% endsnippet %}
{% render card, ...defaults, ...product %}
LIQUID
expected = <<~OUTPUT
<div>Cool Product - 10 </div>
OUTPUT
assert_template_result(
expected,
template,
{
'defaults' => { 'title' => 'Default', 'price' => 10 },
'product' => product_drop.new,
},
)
end
def test_render_captured_snippet
template = <<~LIQUID
{% assign color_scheme = 'dark' %}
@@ -1063,6 +1211,132 @@ class SnippetTest < Minitest::Test
assert_template_result(expected, template, error_mode: :rigid)
end
def test_render_inline_snippet_with_spread_drop
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
def price
99
end
def vendor
'Acme'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>
{{ title }} - ${{ price }} by {{ vendor }}
</div>
{% endsnippet %}
{% render card, ...product %}
LIQUID
expected = <<~OUTPUT
<div>
Cool Product - $99 by Acme
</div>
OUTPUT
assert_template_result(expected, template, { 'product' => product_drop.new }, error_mode: :rigid)
end
def test_render_inline_snippet_with_overwritten_spread_drop
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
def price
99
end
def vendor
'Acme'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>
{{ title }} - ${{ price }} by {{ vendor }}
</div>
{% endsnippet %}
{% render card, ...product, price: 10 %}
LIQUID
expected = <<~OUTPUT
<div>
Cool Product - $10 by Acme
</div>
OUTPUT
assert_template_result(expected, template, { 'product' => product_drop.new }, error_mode: :rigid)
end
def test_render_inline_snippet_spread_before_explicit_args
template = <<~LIQUID.strip
{% snippet card %}
<div>{{ price }}</div>
{% endsnippet %}
{% render card, ...details, price: 10 %}
LIQUID
expected = <<~OUTPUT
<div>10</div>
OUTPUT
assert_template_result(expected, template, { 'details' => { 'price' => 99 } }, error_mode: :rigid)
end
def test_render_inline_snippet_multiple_spreads
product_drop = Class.new(Liquid::Drop) do
def title
'Cool Product'
end
end
template = <<~LIQUID.strip
{% snippet card %}
<div>{{ title }} - {{ price }} {{ color }}</div>
{% endsnippet %}
{% render card, ...defaults, ...product %}
LIQUID
expected = <<~OUTPUT
<div>Cool Product - 10 </div>
OUTPUT
assert_template_result(
expected,
template,
{
'defaults' => { 'title' => 'Default', 'price' => 10 },
'product' => product_drop.new,
},
error_mode: :rigid,
)
end
def test_render_captured_snippet
template = <<~LIQUID
{% assign color_scheme = 'dark' %}