Remove unneeded read method

This commit is contained in:
Julia Boutin
2025-10-27 12:41:59 -06:00
parent 47288ccca0
commit d109bc9242
3 changed files with 11 additions and 9 deletions
-8
View File
@@ -12,14 +12,6 @@ module Liquid
@p = point
end
def read(type = nil)
token = @tokens[@p]
if type && token[0] != type
raise SyntaxError, "Expected #{type} but found #{@tokens[@p].first}"
end
token[1]
end
def consume(type = nil)
token = @tokens[@p]
if type && token[0] != type
+1 -1
View File
@@ -113,7 +113,7 @@ module Liquid
return p.consume(:string) if p.look(:string)
return p.consume(:id) if p.look(:id)
found = p.look(:end_of_string) ? "nothing" : p.read
found = p.consume || "nothing"
raise SyntaxError, options[:locale].t("errors.syntax.render_invalid_template_name", found: found)
end
+10
View File
@@ -953,6 +953,16 @@ class SnippetTest < Minitest::Test
assert_match("Expected a string or identifier, found nothing", exception.message)
end
def test_render_with_invalid_identifier
template = "{% render 123 %}"
exception = assert_raises(SyntaxError) do
Liquid::Template.parse(template, error_mode: :rigid)
end
assert_match("Expected a string or identifier, found 123", exception.message)
end
end
class ResourceLimits < SnippetTest