From cdb5cb06b280b48f5128c7b0db221a08c4d1ee70 Mon Sep 17 00:00:00 2001 From: Dylan Thacker-Smith Date: Fri, 13 Jan 2023 15:37:27 -0500 Subject: [PATCH] Remove == method from drops from testing to_liquid_value Since they could cause tests to pass without to_liquid_value being called on the left side of the equality comparison. --- test/test_helper.rb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/test_helper.rb b/test/test_helper.rb index 67900df8..49b1cc76 100755 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -131,10 +131,6 @@ class IntegerDrop < Liquid::Drop @value = value.to_i end - def ==(other) - @value == other - end - def to_s @value.to_s end @@ -150,10 +146,6 @@ class BooleanDrop < Liquid::Drop @value = value end - def ==(other) - @value == other - end - def to_liquid_value @value end