From c34dd812c5a8031dfa13a44b4130f4564ca70757 Mon Sep 17 00:00:00 2001 From: Marco Concetto Rudilosso Date: Mon, 14 Apr 2025 17:36:45 +0200 Subject: [PATCH] Fully revert calling to_s on filter array --- lib/liquid/standardfilters.rb | 2 -- lib/liquid/version.rb | 2 +- test/integration/standard_filter_test.rb | 5 +++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb index 7359062e..6e072fcf 100644 --- a/lib/liquid/standardfilters.rb +++ b/lib/liquid/standardfilters.rb @@ -982,8 +982,6 @@ module Liquid return default_value if ary.empty? - property = Utils.to_s(property) - block.call(ary) do |item| if target_value.nil? item[property] diff --git a/lib/liquid/version.rb b/lib/liquid/version.rb index 2eee338a..f1d61ada 100644 --- a/lib/liquid/version.rb +++ b/lib/liquid/version.rb @@ -2,5 +2,5 @@ # frozen_string_literal: true module Liquid - VERSION = "5.8.5" + VERSION = "5.8.6" end diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb index 6b931de5..e1370fae 100644 --- a/test/integration/standard_filter_test.rb +++ b/test/integration/standard_filter_test.rb @@ -1054,10 +1054,11 @@ class StandardFiltersTest < Minitest::Test def test_where_with_nil_is_a_no_op environment = { "array" => ["alpha", "beta", "gamma"] } - expected_output = "alpha beta gamma" template = "{{ array | where: nil | join: ' ' }}" - assert_template_result(expected_output, template, environment) + assert_raises(Liquid::ArgumentError) do + assert_template_result("alpha beta gamma", template, environment) + end end def test_where_with_value