Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-16 17:30:43 -07:00
Code Issues Packages Projects Releases Wiki Activity

Support usecase where a nil variable value is used in a logical expression

Browse Source
This commit is contained in:
Albert Chu
2025-03-10 21:20:43 -06:00
parent 26ccec12ab
commit b57f4fcbcb
4 changed files with 44 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/unit/boolean_unit_test.rb
+20 -6
View File
@@ -106,10 +106,10 @@ class BooleanUnitTest < Minitest::Test
end
def test_nil_comparison_with_blank
assert_parity_todo!("nil_value == blank", "false")
assert_parity_todo!("nil_value != blank", "true")
assert_parity_todo!("undefined != blank", "true")
assert_parity_todo!("undefined == blank", "false")
assert_parity("nil_value == blank", "false")
assert_parity("nil_value != blank", "true")
assert_parity("undefined != blank", "true")
assert_parity("undefined == blank", "false")
end
def test_if_with_variables
@@ -121,7 +121,13 @@ class BooleanUnitTest < Minitest::Test
end
def test_nil_variable_in_and_expression
assert_parity_todo!("x and true", "false", { "x" => nil })
assert_parity("x and true", "false", { "x" => nil })
assert_parity("true and x", "false", { "x" => nil })
end
def test_boolean_variable_in_and_expression
assert_parity("true and x", "false", { "x" => false })
assert_parity("x and true", "false", { "x" => false })
end
private
@@ -133,10 +139,18 @@ class BooleanUnitTest < Minitest::Test
end
def assert_parity(liquid_expression, expected_result, args = {})
assert_parity_scenario(:condition, "{% if #{liquid_expression} %}true{% else %}false{% endif %}", expected_result, args)
assert_condition(liquid_expression, expected_result, args)
assert_expression(liquid_expression, expected_result, args)
end
def assert_expression(liquid_expression, expected_result, args = {})
assert_parity_scenario(:expression, "{{ #{liquid_expression} }}", expected_result, args)
end
def assert_condition(liquid_condition, expected_result, args = {})
assert_parity_scenario(:condition, "{% if #{liquid_condition} %}true{% else %}false{% endif %}", expected_result, args)
end
def assert_parity_scenario(kind, template, exp_output, args = {})
act_output = Liquid::Template.parse(template).render(args)