mirror of
https://github.com/Shopify/liquid.git
synced 2026-09-12 23:40:45 -07:00
Merge pull request #398 from Shopify/fix_order_of_constructor_initialize
Reorder constructor to avoid referencing uninitialized variable when environment contains a self-referencing proc
This commit is contained in:
@@ -24,6 +24,7 @@ module Liquid
|
||||
@registers = registers
|
||||
@errors = []
|
||||
@resource_limits = (resource_limits || {}).merge!({ :render_score_current => 0, :assign_score_current => 0 })
|
||||
@parsed_variables = Hash.new{ |cache, markup| cache[markup] = variable_parse(markup) }
|
||||
squash_instance_assigns_with_environments
|
||||
|
||||
if rethrow_errors
|
||||
@@ -32,7 +33,6 @@ module Liquid
|
||||
|
||||
@interrupts = []
|
||||
@filters = []
|
||||
@parsed_variables = Hash.new{ |cache, markup| cache[markup] = variable_parse(markup) }
|
||||
end
|
||||
|
||||
def increment_used_resources(key, obj)
|
||||
|
||||
@@ -483,4 +483,12 @@ class ContextUnitTest < Test::Unit::TestCase
|
||||
assert_equal 1, mock_scan.calls.size
|
||||
end
|
||||
|
||||
def test_context_initialization_with_a_proc_in_environment
|
||||
contx = Context.new([:test => lambda { |c| c['poutine']}], {:test => :foo})
|
||||
|
||||
assert contx
|
||||
assert_nil contx['poutine']
|
||||
end
|
||||
|
||||
|
||||
end # ContextTest
|
||||
|
||||
Reference in New Issue
Block a user