Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-18 02:10:41 -07:00
Code Issues Packages Projects Releases Wiki Activity

use frozen EMPTY_ARRAY for Variable filters when no filters present

Browse Source
This commit is contained in:
Tobi Lutke
2026-04-04 17:33:53 -07:00
committed by Chris Pak
parent a404cf10d0
commit 98e29aa4a7
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/variable.rb
+9 -4
View File
@@ -42,7 +42,7 @@ module Liquid
end end
def lax_parse(markup) def lax_parse(markup)
@filters = [] @filters = Const::EMPTY_ARRAY
return unless markup =~ MarkupWithQuotedFragment return unless markup =~ MarkupWithQuotedFragment
name_markup = Regexp.last_match(1) name_markup = Regexp.last_match(1)
@@ -54,19 +54,21 @@ module Liquid
next unless f =~ /\w+/ next unless f =~ /\w+/
filtername = Regexp.last_match(0) filtername = Regexp.last_match(0)
filterargs = f.scan(FilterArgsRegex).flatten filterargs = f.scan(FilterArgsRegex).flatten
@filters = [] if @filters.frozen?
@filters << lax_parse_filter_expressions(filtername, filterargs) @filters << lax_parse_filter_expressions(filtername, filterargs)
end end
end end
end end
def strict_parse(markup) def strict_parse(markup)
@filters = [] @filters = Const::EMPTY_ARRAY
p = @parse_context.new_parser(markup) p = @parse_context.new_parser(markup)
return if p.look(:end_of_string) return if p.look(:end_of_string)
@name = parse_context.safe_parse_expression(p) @name = parse_context.safe_parse_expression(p)
while p.consume?(:pipe) while p.consume?(:pipe)
@filters = [] if @filters.frozen?
filtername = p.consume(:id) filtername = p.consume(:id)
filterargs = p.consume?(:colon) ? parse_filterargs(p) : Const::EMPTY_ARRAY filterargs = p.consume?(:colon) ? parse_filterargs(p) : Const::EMPTY_ARRAY
@filters << lax_parse_filter_expressions(filtername, filterargs) @filters << lax_parse_filter_expressions(filtername, filterargs)
@@ -75,13 +77,16 @@ module Liquid
end end
def strict2_parse(markup) def strict2_parse(markup)
@filters = [] @filters = Const::EMPTY_ARRAY
p = @parse_context.new_parser(markup) p = @parse_context.new_parser(markup)
return if p.look(:end_of_string) return if p.look(:end_of_string)
@name = parse_context.safe_parse_expression(p) @name = parse_context.safe_parse_expression(p)
@filters << strict2_parse_filter_expressions(p) while p.consume?(:pipe) while p.consume?(:pipe)
@filters = [] if @filters.frozen?
@filters << strict2_parse_filter_expressions(p)
end
p.consume(:end_of_string) p.consume(:end_of_string)
end end