Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-28 22:55:12 -07:00
Code Issues Packages Projects Releases Wiki Activity

Resolve failing rubocop issues

Browse Source
This commit is contained in:
Mike Angell
2019-08-29 00:45:38 +10:00
parent dd27d0fd1d
commit 8f68cffdf1
3 changed files with 58 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.rubocop_todo.yml
+9 -8
View File
@@ -1,6 +1,6 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config` # `rubocop --auto-gen-config`
# on 2019-08-27 22:42:50 +1000 using RuboCop version 0.74.0. # on 2019-08-29 00:43:36 +1000 using RuboCop version 0.74.0.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
@@ -46,7 +46,7 @@ Layout/ClosingHeredocIndentation:
Exclude: Exclude:
- 'test/integration/tags/for_tag_test.rb' - 'test/integration/tags/for_tag_test.rb'
# Offense count: 25 # Offense count: 27
# Cop supports --auto-correct. # Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause: Layout/EmptyLineAfterGuardClause:
Exclude: Exclude:
@@ -104,7 +104,7 @@ Lint/Void:
Exclude: Exclude:
- 'lib/liquid/parse_context.rb' - 'lib/liquid/parse_context.rb'
# Offense count: 52 # Offense count: 53
Metrics/AbcSize: Metrics/AbcSize:
Max: 56 Max: 56
@@ -112,7 +112,7 @@ Metrics/AbcSize:
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 13 Max: 13
# Offense count: 114 # Offense count: 118
# Configuration parameters: CountComments, ExcludedMethods. # Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength: Metrics/MethodLength:
Max: 38 Max: 38
@@ -144,11 +144,12 @@ Naming/UncommunicativeMethodParamName:
- 'test/integration/template_test.rb' - 'test/integration/template_test.rb'
- 'test/unit/condition_unit_test.rb' - 'test/unit/condition_unit_test.rb'
# Offense count: 3 # Offense count: 5
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: inline, group # SupportedStyles: inline, group
Style/AccessModifierDeclarations: Style/AccessModifierDeclarations:
Exclude: Exclude:
- 'lib/liquid/block_body.rb'
- 'lib/liquid/tag.rb' - 'lib/liquid/tag.rb'
- 'lib/liquid/tags/include.rb' - 'lib/liquid/tags/include.rb'
- 'test/unit/strainer_unit_test.rb' - 'test/unit/strainer_unit_test.rb'
@@ -220,7 +221,7 @@ Style/FormatStringToken:
- 'test/integration/filter_test.rb' - 'test/integration/filter_test.rb'
- 'test/integration/hash_ordering_test.rb' - 'test/integration/hash_ordering_test.rb'
# Offense count: 103 # Offense count: 106
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: always, never # SupportedStyles: always, never
@@ -244,7 +245,7 @@ Style/GuardClause:
- 'lib/liquid/variable.rb' - 'lib/liquid/variable.rb'
- 'test/unit/tokenizer_unit_test.rb' - 'test/unit/tokenizer_unit_test.rb'
# Offense count: 52 # Offense count: 53
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: literals, strict # SupportedStyles: literals, strict
@@ -336,7 +337,7 @@ Style/WhileUntilModifier:
Exclude: Exclude:
- 'lib/liquid/tags/case.rb' - 'lib/liquid/tags/case.rb'
# Offense count: 650 # Offense count: 665
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https # URISchemes: http, https
performance/memory_profile.rb
+1
View File
@@ -30,6 +30,7 @@ class Profiler
@retained << "#{report.scale_bytes(report.total_retained_memsize)} (#{report.total_retained} objects)" @retained << "#{report.scale_bytes(report.total_retained_memsize)} (#{report.total_retained} objects)"
return if ENV['CI'] return if ENV['CI']
require 'fileutils' require 'fileutils'
report_file = File.join(REPORTS_DIR, "#{sanitize(phase)}.txt") report_file = File.join(REPORTS_DIR, "#{sanitize(phase)}.txt")
FileUtils.mkdir_p(REPORTS_DIR) FileUtils.mkdir_p(REPORTS_DIR)