Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-19 10:52:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Make Strainer also raise when registered method is overriden as protected

Browse Source
This commit is contained in:
Gaurav Chande
2016-02-24 20:23:49 +00:00
parent 8be38d1795
commit 8e6b9d503d
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/strainer.rb
+3 -3
View File
@@ -28,9 +28,9 @@ module Liquid
def self.add_filter(filter)
raise ArgumentError, "Expected module but got: #{filter.class}" unless filter.is_a?(Module)
unless self.class.include?(filter)
invokable_private_methods = filter.private_instance_methods.select { |m| invokable?(m) }
if invokable_private_methods.any?
raise MethodOverrideError, "Filter overrides registered public methods as private: #{invokable_private_methods.join(', ')}"
invokable_non_public_methods = (filter.private_instance_methods + filter.protected_instance_methods).select { |m| invokable?(m) }
if invokable_non_public_methods.any?
raise MethodOverrideError, "Filter overrides registered public methods as non public: #{invokable_non_public_methods.join(', ')}"
else
send(:include, filter)
@filter_methods.merge(filter.public_instance_methods.map(&:to_s))