Labyricorn/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2026-09-12 23:40:45 -07:00
Code Issues Packages Projects Releases Wiki Activity

fast-path find_variable: check top scope first before find_index

Browse Source
This commit is contained in:
Tobi Lutke
2026-03-11 08:48:16 -04:00
parent 526af22574
commit 76ae8f13e9
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liquid/context.rb
+13 -7
View File
@@ -199,14 +199,20 @@ module Liquid
# Fetches an object starting at the local scope and then moving up the hierachy # Fetches an object starting at the local scope and then moving up the hierachy
def find_variable(key, raise_on_not_found: true) def find_variable(key, raise_on_not_found: true)
# This was changed from find() to find_index() because this is a very hot # Fast path: check top scope first (most common in for loops)
# path and find_index() is optimized in MRI to reduce object allocation scope = @scopes[0]
index = @scopes.find_index { |s| s.key?(key) } if scope.key?(key)
variable = lookup_and_evaluate(scope, key, raise_on_not_found: raise_on_not_found)
variable = if index
lookup_and_evaluate(@scopes[index], key, raise_on_not_found: raise_on_not_found)
else else
try_variable_find_in_environments(key, raise_on_not_found: raise_on_not_found) # This was changed from find() to find_index() because this is a very hot
# path and find_index() is optimized in MRI to reduce object allocation
index = @scopes.find_index { |s| s.key?(key) }
variable = if index
lookup_and_evaluate(@scopes[index], key, raise_on_not_found: raise_on_not_found)
else
try_variable_find_in_environments(key, raise_on_not_found: raise_on_not_found)
end
end end
# update variable's context before invoking #to_liquid # update variable's context before invoking #to_liquid